From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA8B0C433E2 for ; Tue, 15 Sep 2020 11:12:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A7DA421D43 for ; Tue, 15 Sep 2020 11:12:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="RRzfh5+I" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726155AbgIOLMI (ORCPT ); Tue, 15 Sep 2020 07:12:08 -0400 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:45344 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726172AbgIOLLQ (ORCPT ); Tue, 15 Sep 2020 07:11:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1600168262; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=tiWWA5WPIJE1R4aNQnzFviD2WfhvbCKqrfBZuXGN+7s=; b=RRzfh5+IvGmEk78OEvlkp+Pg60w8e8osrPzu8u6R0J7zy+vPdA/Du4mVyhex+XKi/GDdU+ Fi9jpyHnhTlF7vTR3BNkqQ7hp38etQTYkgBWV3he+3DWAvN/zCXk8owNktsCW6hMvu0Wgy JeIri+sYCk7iLRSvzFwrl5kjNPAJw08= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-17-RBpMLzO2Phej0Rfe0eTmBw-1; Tue, 15 Sep 2020 07:02:12 -0400 X-MC-Unique: RBpMLzO2Phej0Rfe0eTmBw-1 Received: by mail-wm1-f72.google.com with SMTP id m125so764851wmm.7 for ; Tue, 15 Sep 2020 04:02:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=tiWWA5WPIJE1R4aNQnzFviD2WfhvbCKqrfBZuXGN+7s=; b=ErNVZKkPpHzSyz8S+5d7tFaaSWNULmf8n3d9Fsppja9ixnjbkmMgWib/a4JtkUIHIK DyOS13O7q2jg3Rj0NinarIu+DaGHGkRjbF6WMiIihYyic0NRReAwwt0A5Tv2EQOGVEIg zsxesGXjDegX41mgiNNq9py+cWJH2XdofAUpDM1aevHkcvgDttA2IWanH8tT65OQtNh+ UXfSx6QYnfISXkNq6LK/jUBG7261KMqdbf519LfrYiXnZ4BsWt/pGFrYOxnTIUm+L0Kr lN1195jouPhKNlQIQ4kvL3cn3jlmLzZ7FVScEztTfr9bzxt0LHgEVoTbDLGda7smBjcA 2EQg== X-Gm-Message-State: AOAM533ctqQY7bopUqYAQrJx/ZLRwhtjN9RCQD0ISKtnWS28FqsOiYw2 AMoXpB8eP+/3PIqMAcIW4lYasqcHoN6Anm99yXjn95IUQtCNNAfMj6UuYBw+uTjAN7st1VCDMoi ffqyZ/HsXiAI0+fTG/KGlKv42 X-Received: by 2002:adf:f24d:: with SMTP id b13mr20494611wrp.316.1600167731108; Tue, 15 Sep 2020 04:02:11 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxlb3plOi5NIG6+FaUC+KmbrIuYLV1hdg3p4P3m7Jsr5kxBr0w1XwcAmImBMjoeZWSiZxGoww== X-Received: by 2002:adf:f24d:: with SMTP id b13mr20494569wrp.316.1600167730881; Tue, 15 Sep 2020 04:02:10 -0700 (PDT) Received: from vitty.brq.redhat.com (g-server-2.ign.cz. [91.219.240.2]) by smtp.gmail.com with ESMTPSA id m23sm8009179wmi.19.2020.09.15.04.02.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Sep 2020 04:02:10 -0700 (PDT) From: Vitaly Kuznetsov To: Wei Liu Cc: Wei Liu , Linux on Hyper-V List , virtualization@lists.linux-foundation.org, Linux Kernel List , Michael Kelley , Vineeth Pillai , Sunil Muthuswamy , Nuno Das Neves , Lillian Grassin-Drake , "K. Y. Srinivasan" , Haiyang Zhang , Stephen Hemminger , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "maintainer\:X86 ARCHITECTURE \(32-BIT AND 64-BIT\)" , "H. Peter Anvin" Subject: Re: [PATCH RFC v1 08/18] x86/hyperv: handling hypercall page setup for root In-Reply-To: <20200915103710.cqmdvzh5lys4wsqo@liuwe-devbox-debian-v2> References: <20200914112802.80611-1-wei.liu@kernel.org> <20200914112802.80611-9-wei.liu@kernel.org> <87v9gfjpoi.fsf@vitty.brq.redhat.com> <20200915103710.cqmdvzh5lys4wsqo@liuwe-devbox-debian-v2> Date: Tue, 15 Sep 2020 13:02:08 +0200 Message-ID: <87pn6njob3.fsf@vitty.brq.redhat.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-hyperv-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-hyperv@vger.kernel.org Wei Liu writes: > On Tue, Sep 15, 2020 at 12:32:29PM +0200, Vitaly Kuznetsov wrote: >> Wei Liu writes: >> >> > When Linux is running as the root partition, the hypercall page will >> > have already been setup by Hyper-V. Copy the content over to the >> > allocated page. >> >> And we can't setup a new hypercall page by writing something different >> to HV_X64_MSR_HYPERCALL, right? >> > > My understanding is that we can't, but Sunil can maybe correct me. > >> > >> > The suspend, resume and cleanup paths remain untouched because they are >> > not supported in this setup yet. >> > >> > Signed-off-by: Lillian Grassin-Drake >> > Signed-off-by: Sunil Muthuswamy >> > Signed-off-by: Nuno Das Neves >> > Co-Developed-by: Lillian Grassin-Drake >> > Co-Developed-by: Sunil Muthuswamy >> > Co-Developed-by: Nuno Das Neves >> > Signed-off-by: Wei Liu >> > --- >> > arch/x86/hyperv/hv_init.c | 26 ++++++++++++++++++++++++-- >> > 1 file changed, 24 insertions(+), 2 deletions(-) >> > >> > diff --git a/arch/x86/hyperv/hv_init.c b/arch/x86/hyperv/hv_init.c >> > index 0eec1ed32023..26233aebc86c 100644 >> > --- a/arch/x86/hyperv/hv_init.c >> > +++ b/arch/x86/hyperv/hv_init.c >> > @@ -25,6 +25,7 @@ >> > #include >> > #include >> > #include >> > +#include >> > >> > /* Is Linux running as the root partition? */ >> > bool hv_root_partition; >> > @@ -448,8 +449,29 @@ void __init hyperv_init(void) >> > >> > rdmsrl(HV_X64_MSR_HYPERCALL, hypercall_msr.as_uint64); >> > hypercall_msr.enable = 1; >> > - hypercall_msr.guest_physical_address = vmalloc_to_pfn(hv_hypercall_pg); >> > - wrmsrl(HV_X64_MSR_HYPERCALL, hypercall_msr.as_uint64); >> > + >> > + if (hv_root_partition) { >> > + struct page *pg; >> > + void *src, *dst; >> > + >> > + /* >> > + * Order is important here. We must enable the hypercall page >> > + * so it is populated with code, then copy the code to an >> > + * executable page. >> > + */ >> > + wrmsrl(HV_X64_MSR_HYPERCALL, hypercall_msr.as_uint64); >> > + >> > + pg = vmalloc_to_page(hv_hypercall_pg); >> > + dst = kmap(pg); >> > + src = memremap(hypercall_msr.guest_physical_address << PAGE_SHIFT, PAGE_SIZE, >> > + MEMREMAP_WB); >> >> memremap() can fail... > > And we don't care here, if it fails, we would rather it panic or oops. > > I was relying on the fact that copying from / to a NULL pointer will > cause the kernel to crash. But of course it wouldn't hurt to explicitly > panic here. > >> >> > + memcpy(dst, src, PAGE_SIZE); >> > + memunmap(src); >> > + kunmap(pg); >> > + } else { >> > + hypercall_msr.guest_physical_address = vmalloc_to_pfn(hv_hypercall_pg); >> > + wrmsrl(HV_X64_MSR_HYPERCALL, hypercall_msr.as_uint64); >> > + } >> >> Why can't we do wrmsrl() for both cases here? >> > > Because the hypercall page has already been set up when Linux is the > root. But you already do wrmsrl(HV_X64_MSR_HYPERCALL, hypercall_msr.as_uint64) in 'if (hv_root_partition)' case above, that's why I asked. > > I could've tried writing to the MSR again, but because the behaviour > here is not documented and subject to change so I didn't bother trying. > > Wei. > >> > >> > /* >> > * Ignore any errors in setting up stimer clockevents >> >> -- >> Vitaly >> > -- Vitaly