From: "Thomas Weißschuh" <linux@weissschuh.net>
To: Michael Kelley <mhklinux@outlook.com>
Cc: "K. Y. Srinivasan" <kys@microsoft.com>,
Haiyang Zhang <haiyangz@microsoft.com>,
Wei Liu <wei.liu@kernel.org>, Dexuan Cui <decui@microsoft.com>,
Long Li <longli@microsoft.com>,
"linux-hyperv@vger.kernel.org" <linux-hyperv@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 4/4] drivers: hv: mark channel attributes as const
Date: Fri, 3 Apr 2026 18:15:35 +0200 [thread overview]
Message-ID: <8d8fdf46-5374-4e23-9c79-140117724441@t-8ch.de> (raw)
In-Reply-To: <SN6PR02MB4157D5F04608E4E3C21AB56ED45EA@SN6PR02MB4157.namprd02.prod.outlook.com>
On 2026-04-03 15:56:54+0000, Michael Kelley wrote:
> From: Thomas Weißschuh <linux@weissschuh.net> Sent: Friday, April 3, 2026 1:29 AM
> >
> > These attributes are never modified, mark them as const.
> >
> > Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
> > Tested-by: Michael Kelley <mhklinux@outlook.com>
>
> Reviewed-by: Michael Kelley <mhklinux@outlook.com>
Thanks.
> But take a look at this analysis from Sashiko AI:
> https://sashiko.dev/#/patchset/20260403-sysfs-const-hv-v2-0-8932ab8d41db%40weissschuh.net
>
> This seems to be a valid concern with your earlier commit 7dd9fdb4939b9
> "sysfs: attribute_group: enable const variants of is_visible()".
Indeed, I missed this user of ->is_visible.
I'll send a fix for that, but it shouldn't affect this series.
Thomas
next prev parent reply other threads:[~2026-04-03 16:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-03 8:29 [PATCH v2 0/4] drivers: hv: mark some sysfs attribute as const Thomas Weißschuh
2026-04-03 8:29 ` [PATCH v2 1/4] drivers: hv: mark chan_attr_ring_buffer " Thomas Weißschuh
2026-04-03 8:29 ` [PATCH v2 2/4] drivers: hv: use ATTRIBUTE_GROUPS helper Thomas Weißschuh
2026-04-03 8:29 ` [PATCH v2 3/4] drivers: hv: mark bus attributes as const Thomas Weißschuh
2026-04-03 8:29 ` [PATCH v2 4/4] drivers: hv: mark channel " Thomas Weißschuh
2026-04-03 15:56 ` Michael Kelley
2026-04-03 16:15 ` Thomas Weißschuh [this message]
2026-04-03 17:46 ` Michael Kelley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8d8fdf46-5374-4e23-9c79-140117724441@t-8ch.de \
--to=linux@weissschuh.net \
--cc=decui@microsoft.com \
--cc=haiyangz@microsoft.com \
--cc=kys@microsoft.com \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=longli@microsoft.com \
--cc=mhklinux@outlook.com \
--cc=wei.liu@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox