From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DAB09C433FE for ; Tue, 22 Nov 2022 14:30:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233240AbiKVOa6 (ORCPT ); Tue, 22 Nov 2022 09:30:58 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49496 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233239AbiKVOa5 (ORCPT ); Tue, 22 Nov 2022 09:30:57 -0500 Received: from fanzine2.igalia.com (fanzine2.igalia.com [213.97.179.56]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EE9A36317F; Tue, 22 Nov 2022 06:30:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=9So0O8Pi8i8JHhFiG20jjK2ykR3NF1IMBTGdS9HzvSc=; b=gfoaakATo3McgEoQ5zIJQ3Gsom dufqZdgPKM+yw0jFFN/K6+V7g7l5QwaZOV/0S2RmCXXt15cNLAvk2VhphewPoXa2YAcaOECIr2gzj pP/kEwIlL2NbJOX4eTQidYlo/snxWt1FO1oIKfU5ewy12GTREQtKId7G2AJGDrYUl/GGDIwUtfuDy vNGyHBkQ5D11aIgDyyyXqfReJn5NyJiQtwx9VSsqkqWz3H58/Q0jf0A88u5Ryn7UkSAYIOiFRY3MP UITEbCNj1Wp77PuPX5qEZ7voLPw36j5yCi+XjucIaEBqYPOrBRSQhGun0A700bXW3ntCeLuarNZlC SXGIR7Rw==; Received: from [177.102.6.147] (helo=[192.168.1.60]) by fanzine2.igalia.com with esmtpsa (Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_128_GCM:128) (Exim) id 1oxTM4-006y2D-7E; Tue, 22 Nov 2022 14:30:28 +0100 Message-ID: <9d9823a9-255b-84c7-53b1-47fe51e1d756@igalia.com> Date: Tue, 22 Nov 2022 10:30:22 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.2 Subject: Re: [PATCH V3 07/11] notifiers: Add tracepoints to the notifiers infrastructure Content-Language: en-US To: Arjan van de Ven , Xiaoming Ni Cc: Cong Wang , Sebastian Andrzej Siewior , Valentin Schneider , rostedt@goodmis.org, pmladek@suse.com, akpm@linux-foundation.org, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, linux-hyperv@vger.kernel.org, netdev@vger.kernel.org, x86@kernel.org, kernel-dev@igalia.com, kernel@gpiccoli.net References: <20220819221731.480795-1-gpiccoli@igalia.com> <20220819221731.480795-8-gpiccoli@igalia.com> From: "Guilherme G. Piccoli" In-Reply-To: <20220819221731.480795-8-gpiccoli@igalia.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-hyperv@vger.kernel.org On 19/08/2022 19:17, Guilherme G. Piccoli wrote: > Currently there is no way to show the callback names for registered, > unregistered or executed notifiers. This is very useful for debug > purposes, hence add this functionality here in the form of notifiers' > tracepoints, one per operation. > > Cc: Arjan van de Ven > Cc: Cong Wang > Cc: Sebastian Andrzej Siewior > Cc: Steven Rostedt > Cc: Valentin Schneider > Cc: Xiaoming Ni > Signed-off-by: Guilherme G. Piccoli > > --- > > V3: > - Yet another major change - thanks to Arjan's great suggestion, > refactored the code to make use of tracepoints instead of guarding > the output with a Kconfig debug setting. > > V2: > - Major improvement thanks to the great idea from Xiaoming - changed > all the ksym wheel reinvention to printk %ps modifier; > > - Instead of ifdefs, using IS_ENABLED() - thanks Steven. > > - Removed an unlikely() hint on debug path. > > > include/trace/events/notifiers.h | 69 ++++++++++++++++++++++++++++++++ > kernel/notifier.c | 6 +++ > 2 files changed, 75 insertions(+) > create mode 100644 include/trace/events/notifiers.h > Hi Arjan / Xiaoming / all, monthly ping heh If there's any advice on how to move things here, I would appreciate! Thanks in advance and apologies for the re-pings. Cheers, Guilherme