From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B448AC433F5 for ; Tue, 11 Oct 2022 19:15:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229896AbiJKTPo (ORCPT ); Tue, 11 Oct 2022 15:15:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35582 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229827AbiJKTPl (ORCPT ); Tue, 11 Oct 2022 15:15:41 -0400 Received: from mail-pj1-x102f.google.com (mail-pj1-x102f.google.com [IPv6:2607:f8b0:4864:20::102f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BC01558B50 for ; Tue, 11 Oct 2022 12:15:38 -0700 (PDT) Received: by mail-pj1-x102f.google.com with SMTP id l1-20020a17090a72c100b0020a6949a66aso14171443pjk.1 for ; Tue, 11 Oct 2022 12:15:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=gyuABnJw/T589iuhSb5mht/YLLE+xLjud9zjMiPRJI4=; b=mHljrkmgI8NGzkYjKAyz3szyp2BEF52+qwqaVnORtSZMYF+dhEncTMEL7eIQQSX5aw 8GFwqpOJYQ97b2P7GU352b62eUOIxPu/9NlmXwY0t2oh9AUgkkufZOTT8TNAAmgL+6ZM T3YqlbNiW1zSg1TUrnm9yONL4mc+raRqs9G4y9vYNprVKRbDdtAu9D7H/jZ2TZJYqSpy uw8gDr4RGrkWNZgiUGAWg0gEmaWtjh0k2tyWMhXJmTkxkZd7VZYWMZ4nxf4fnB0FQ79J fHQer3d3HP6qCqNRWpLfQ30QItCMRiheraiau6EzHjPb+GCS0hQjaLIP9JsbmbPV7lQv u2cQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=gyuABnJw/T589iuhSb5mht/YLLE+xLjud9zjMiPRJI4=; b=x6g74gzXMD+2aV2jk7Ad0ZpMdTTLCMaOTSXq9jy4ea3eoRO6zlCldsXl7EauwNVV37 L94kQUp9MPry3NxnOf70DvQNkPDqesKna/S1GLV5d/E5Eyc4V18Fy03bCw2VJo+30JoS 5jtVp6UmQGJjWTKnx+j80qyD5/qP6CdCROHA0o3jw/s5qoSEb7DaQNcWnlaZShPvWVv9 smWjcJOteDEUVm0bFlawAqLpXHwjAqexhV0BZpNm2BNntKSBQxBkpnUIQ/Hdl2av3UcL tByqFPUHS5y7eGvGSVdlDUzmRwwTu9pyCb8iuq9uUxwYkZj2wm/Y7CNtFFHRlzD+oC27 GCcg== X-Gm-Message-State: ACrzQf0fj/LceBxEFvIY4GNoNLxgfQOyp7kIvc+xD0bMT2wFcapKgf0S s9fwl2Hkp+Rqn79da76AvjXPMw== X-Google-Smtp-Source: AMsMyM6r7Mgl+VA2MqserQBZOFIzFB2iRK0PYyXc5YH0R7A5S8wz05QJ76hddhlqdl7inBV2w7raWQ== X-Received: by 2002:a17:903:2616:b0:17f:8042:723a with SMTP id jd22-20020a170903261600b0017f8042723amr26791188plb.106.1665515737936; Tue, 11 Oct 2022 12:15:37 -0700 (PDT) Received: from google.com (7.104.168.34.bc.googleusercontent.com. [34.168.104.7]) by smtp.gmail.com with ESMTPSA id b8-20020a17090a7ac800b00205d70ccfeesm11134681pjl.33.2022.10.11.12.15.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Oct 2022 12:15:37 -0700 (PDT) Date: Tue, 11 Oct 2022 19:15:33 +0000 From: Sean Christopherson To: Vitaly Kuznetsov Cc: kvm@vger.kernel.org, Paolo Bonzini , Wanpeng Li , Jim Mattson , Maxim Levitsky , Michael Kelley , linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 2/6] KVM: x86: Introduce CPUID_8000_0007_EDX 'scattered' leaf Message-ID: References: <20220922143655.3721218-1-vkuznets@redhat.com> <20220922143655.3721218-3-vkuznets@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220922143655.3721218-3-vkuznets@redhat.com> Precedence: bulk List-ID: X-Mailing-List: linux-hyperv@vger.kernel.org On Thu, Sep 22, 2022, Vitaly Kuznetsov wrote: > diff --git a/arch/x86/kvm/reverse_cpuid.h b/arch/x86/kvm/reverse_cpuid.h > index a19d473d0184..a5514c89dc29 100644 > --- a/arch/x86/kvm/reverse_cpuid.h > +++ b/arch/x86/kvm/reverse_cpuid.h > @@ -12,7 +12,8 @@ > * "bug" caps, but KVM doesn't use those. > */ > enum kvm_only_cpuid_leafs { > - CPUID_12_EAX = NCAPINTS, > + CPUID_12_EAX = NCAPINTS, > + CPUID_8000_0007_EDX = NCAPINTS + 1, No need to explicitly initialize the new leaf, only the first enum entry needs explicit initialization to NCAPINTS, i.e. let all other entries automatically increment. The order doesn't matter, so not caring about the exact value will avoid bugs due to mismerge and/or bad copy+paste.