From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1FC54C4332F for ; Wed, 19 Oct 2022 22:12:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230505AbiJSWMT (ORCPT ); Wed, 19 Oct 2022 18:12:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39976 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230496AbiJSWMS (ORCPT ); Wed, 19 Oct 2022 18:12:18 -0400 Received: from mail-pj1-x1036.google.com (mail-pj1-x1036.google.com [IPv6:2607:f8b0:4864:20::1036]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 99E9C1ACAB6 for ; Wed, 19 Oct 2022 15:12:16 -0700 (PDT) Received: by mail-pj1-x1036.google.com with SMTP id u8-20020a17090a5e4800b002106dcdd4a0so1504609pji.1 for ; Wed, 19 Oct 2022 15:12:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=zZDs+e1tEDSMDXlDBKyOmGP89CEFOInZ+U8nAdsCuEE=; b=j1dakIi1iaKRZtMmnvX1D9Kmxsc6ZHpVNV9DE90BDd4F66ePn6V6aTnueWQjRvgQCw B2NuPYsptjPdRHUX7ymf5cYiCrn0wnoUezJ5vNQAJp2xbkwXoWfDfLwA/qstHFKXbbMt Z2RgJUzXulnGact8b1OgHqQSugpFtaWSWbPTSF+JsYzcfNlmaS+QYqoRo2gB/goBTiNG d5AT7KGzZWV5g6quUAZXr6fuvo9ptvicHEJa8dfdAxNO5UVJX8Cxf20K26Clt0W7ZnK1 1HCXCTZbJNuueBnABeMWYQFpBC7dOC2lhWBjRLVLBtvNwJjsJlRnUufh4H2Zz9DH+fhv kRvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=zZDs+e1tEDSMDXlDBKyOmGP89CEFOInZ+U8nAdsCuEE=; b=auwFhVsmgvD2JEfbzIvk1jnIDI9doGWgJIOmCmU4cJyeVxiRH7ndSxscwCLK9rLikg MwImBsA2S6gvB4MyyEkl+H4SUEMVploQbL29qYg5BeosRzilOBeoLBBlBlnxLrEo2CBC SgH35K5QTm3/BDarpZ9VA9fnyokatKmNP7J4WkUZGJOVpTqx55b1LMdj+MwGnV9mAWfy Wyov5+h8Ssy+nfY1gQsuSoNQQIK1IHgw3GOb+aSR/EkqodFvueJ4ogN9az2e0UAgZBBU qpU9OJz/weZt13d8R9cugAl1sbYZF4F+kNfD7z0rJOXiVOFJZEjb+sgDzDPmf5diCxAa 6Ukg== X-Gm-Message-State: ACrzQf24RPImb1+AXcxP80RpHoW3bt4ZPROUj3WGVsv/Edy2O1GAga3L 8nv8ZhxC0rkg6ikzkNXjU+Qmnw== X-Google-Smtp-Source: AMsMyM6L/PGjPtkcMdIGqeJkmX7cnb7wWT3a81geGEN3ptnDQfA5XicnzE/kfC7aYvJNXjEqAnAq1A== X-Received: by 2002:a17:90a:354:b0:20a:6867:4a2b with SMTP id 20-20020a17090a035400b0020a68674a2bmr47829614pjf.157.1666217535953; Wed, 19 Oct 2022 15:12:15 -0700 (PDT) Received: from google.com (7.104.168.34.bc.googleusercontent.com. [34.168.104.7]) by smtp.gmail.com with ESMTPSA id u15-20020a17090341cf00b0017f93a4e330sm11206871ple.193.2022.10.19.15.12.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Oct 2022 15:12:15 -0700 (PDT) Date: Wed, 19 Oct 2022 22:12:11 +0000 From: Sean Christopherson To: Vitaly Kuznetsov Cc: kvm@vger.kernel.org, Paolo Bonzini , Wanpeng Li , Jim Mattson , Michael Kelley , Siddharth Chandrasekaran , Yuan Yao , Maxim Levitsky , linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v11 37/46] KVM: selftests: Hyper-V PV TLB flush selftest Message-ID: References: <20221004123956.188909-1-vkuznets@redhat.com> <20221004123956.188909-38-vkuznets@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221004123956.188909-38-vkuznets@redhat.com> Precedence: bulk List-ID: X-Mailing-List: linux-hyperv@vger.kernel.org On Tue, Oct 04, 2022, Vitaly Kuznetsov wrote: > +static void *vcpu_thread(void *arg) > +{ > + struct kvm_vcpu *vcpu = (struct kvm_vcpu *)arg; > + struct ucall uc; > + int old; > + int r; > + unsigned int exit_reason; > + > + r = pthread_setcanceltype(PTHREAD_CANCEL_ASYNCHRONOUS, &old); > + TEST_ASSERT(r == 0, > + "pthread_setcanceltype failed on vcpu_id=%u with errno=%d", > + vcpu->id, r); If possible, TEST_ASSERT(!r, pthread_setcanceltype() failed on vcpu_id=%u, vcpu->id); > + > + vcpu_run(vcpu); > + exit_reason = vcpu->run->exit_reason; > + > + TEST_ASSERT(exit_reason == KVM_EXIT_IO, > + "vCPU %u exited with unexpected exit reason %u-%s, expected KVM_EXIT_IO", > + vcpu->id, exit_reason, exit_reason_str(exit_reason)); > + > + if (get_ucall(vcpu, &uc) == UCALL_ABORT) { > + TEST_ASSERT(false, > + "vCPU %u exited with error: %s.\n", > + vcpu->id, (const char *)uc.args[0]); REPORT_GUEST_ASSERT_N? > + } > + > + return NULL; > +} > + > +static void cancel_join_vcpu_thread(pthread_t thread, struct kvm_vcpu *vcpu) > +{ > + void *retval; > + int r; > + > + r = pthread_cancel(thread); > + TEST_ASSERT(r == 0, > + "pthread_cancel on vcpu_id=%d failed with errno=%d", > + vcpu->id, r); > + > + r = pthread_join(thread, &retval); > + TEST_ASSERT(r == 0, > + "pthread_join on vcpu_id=%d failed with errno=%d", > + vcpu->id, r); Same assert/errno comment here. > + while (true) { > + r = _vcpu_run(vcpu[0]); > + exit_reason = vcpu[0]->run->exit_reason; > + > + TEST_ASSERT(!r, "vcpu_run failed: %d", r); Just use vcpu_run(). > + TEST_ASSERT(exit_reason == KVM_EXIT_IO, > + "unexpected exit reason: %u (%s)", > + exit_reason, exit_reason_str(exit_reason)); > + > + switch (get_ucall(vcpu[0], &uc)) { > + case UCALL_SYNC: > + TEST_ASSERT(uc.args[1] == stage, > + "Unexpected stage: %ld (%d expected)\n", > + uc.args[1], stage); > + break; > + case UCALL_ABORT: > + REPORT_GUEST_ASSERT(uc); > + /* NOT REACHED */ > + case UCALL_DONE: > + return 0; > + } > + > + stage++; > + } > + > + cancel_join_vcpu_thread(threads[0], vcpu[1]); > + cancel_join_vcpu_thread(threads[1], vcpu[2]); > + kvm_vm_free(vm); > + > + return 0; > +} > -- > 2.37.3 >