From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CDDFDC38A2D for ; Wed, 26 Oct 2022 21:59:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231706AbiJZV75 (ORCPT ); Wed, 26 Oct 2022 17:59:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57788 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233699AbiJZV7z (ORCPT ); Wed, 26 Oct 2022 17:59:55 -0400 Received: from mail-pj1-x1029.google.com (mail-pj1-x1029.google.com [IPv6:2607:f8b0:4864:20::1029]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 02366209BD for ; Wed, 26 Oct 2022 14:59:52 -0700 (PDT) Received: by mail-pj1-x1029.google.com with SMTP id d59-20020a17090a6f4100b00213202d77e1so4202089pjk.2 for ; Wed, 26 Oct 2022 14:59:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=nR7s6MCaEHlCMlVxMummbX5Q2r2GgdQOaJT5qk5VOZM=; b=CqlBImQlgpjUHO0Rx0GwhsgUlHmg4p7+TZLDG7ab2pLnDCf4XoxoBytUinJVpAsGS7 SGlwn+ELkfhVBLxn/UtORgFKweK0bFONWynDJ0yID6dsF5AxmnEJX7PLOCOdaRVeREci 3ISpIUyQ7nL2WmBExE4rV2wPgdKHgCc4CLsfL8El4BmGAUEmeB25K7YvHgF+rhSId4L8 RaijAmPi34k+krFIkTijdPWTsj6FGHdK85wDlx6y7DpR67/O/6jNkwbnM9EMQ/7zeui/ Ig1gAMZh1qdU46fru5yksFizzP5cP9+Sw8zTySCh9irsWwLkiCX9pU0Krm0bKfefui0c dO0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=nR7s6MCaEHlCMlVxMummbX5Q2r2GgdQOaJT5qk5VOZM=; b=68ywhOXZGbayFmDQyk08s8koz3aYpqUYD1/9XP/RLkmee6ciMLCU5fBF50lvWmzPLU JGEPGcW0X0CsSePRWW+lct1Y0D4vr3nNEOWXJ1fZJ3B2g8ArYrue2FDYVkvNwJAQ2Bgd 7O3CnQTO+7qaFSQcyeaOQj2njKzyW5fwj8WpDACb9MKpOl+Vn8ekRYPsLseYWPkhqXLs xw/2v51wZHb1WfUE0sCLshr+2PzvYdHjefRpCAx2/5z0ivTAgEhGuBaY9LOjmU+eVM65 AIR6L5mte9hpv4keOrF7kCbbrOrCZ+xDhV3jReRQpFtYzE1Rv+IiIAgqfQQIfqtaqtWV sr2w== X-Gm-Message-State: ACrzQf1VJaHdm8eKgu7IBmJu/1ceLu1eJqv9zUFE3ndY3K+GXie69Dsv er+Nc3YVAn848xQXvifxiHXCmA== X-Google-Smtp-Source: AMsMyM5SQDNPjD7thnUy1UQuQk1M2SqagZHBjw0JQz6NiII0qQZ/kCP/JGKefog2ciVFBuEb60AoWA== X-Received: by 2002:a17:902:ee8b:b0:186:a226:7207 with SMTP id a11-20020a170902ee8b00b00186a2267207mr18657114pld.49.1666821592090; Wed, 26 Oct 2022 14:59:52 -0700 (PDT) Received: from google.com (7.104.168.34.bc.googleusercontent.com. [34.168.104.7]) by smtp.gmail.com with ESMTPSA id ik12-20020a170902ab0c00b00186c9d17af2sm2749143plb.17.2022.10.26.14.59.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Oct 2022 14:59:51 -0700 (PDT) Date: Wed, 26 Oct 2022 21:59:48 +0000 From: Sean Christopherson To: Vitaly Kuznetsov Cc: kvm@vger.kernel.org, Paolo Bonzini , Wanpeng Li , Jim Mattson , Michael Kelley , Siddharth Chandrasekaran , Yuan Yao , Maxim Levitsky , linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v12 36/46] KVM: selftests: Drop helpers to read/write page table entries Message-ID: References: <20221021153521.1216911-1-vkuznets@redhat.com> <20221021153521.1216911-37-vkuznets@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221021153521.1216911-37-vkuznets@redhat.com> Precedence: bulk List-ID: X-Mailing-List: linux-hyperv@vger.kernel.org On Fri, Oct 21, 2022, Vitaly Kuznetsov wrote: > From: Sean Christopherson > > Drop vm_{g,s}et_page_table_entry() and instead expose the "inner" > helper (was _vm_get_page_table_entry()) that returns a _pointer_ to the > PTE, i.e. let tests directly modify PTEs instead of bouncing through > helpers that just make life difficult. > > Opportunsitically use BIT_ULL() in emulator_error_test, and use the > MAXPHYADDR define to set the "rogue" GPA bit instead of open coding the > same value. > > No functional change intended. > > Signed-off-by: Sean Christopherson Missing your SOB, though maybe Paolo will merge my series first and make this a moot point :-)