linux-hyperv.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Alexander Graf <graf@amazon.com>
Cc: "Jason A. Donenfeld" <Jason@zx2c4.com>,
	kvm@vger.kernel.org, linux-crypto@vger.kernel.org,
	linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org,
	adrian@parity.io, ardb@kernel.org, ben@skyportsystems.com,
	berrange@redhat.com, colmmacc@amazon.com, decui@microsoft.com,
	dwmw@amazon.co.uk, ebiggers@kernel.org, ehabkost@redhat.com,
	haiyangz@microsoft.com, imammedo@redhat.com, jannh@google.com,
	kys@microsoft.com, lersek@redhat.com, linux@dominikbrodowski.net,
	mst@redhat.com, qemu-devel@nongnu.org, raduweis@amazon.com,
	sthemmin@microsoft.com, tytso@mit.edu, wei.liu@kernel.org
Subject: Re: [PATCH v4] virt: vmgenid: introduce driver for reinitializing RNG on VM fork
Date: Fri, 25 Feb 2022 15:36:54 +0100	[thread overview]
Message-ID: <YhjphtYyXoYZ9lXY@kroah.com> (raw)
In-Reply-To: <05c9f2a9-accb-e0de-aac7-b212adac7eb2@amazon.com>

On Fri, Feb 25, 2022 at 02:57:38PM +0100, Alexander Graf wrote:
> > +
> > +       phys_addr = (obj->package.elements[0].integer.value << 0) |
> > +                   (obj->package.elements[1].integer.value << 32);
> > +       state->next_id = devm_memremap(&device->dev, phys_addr, VMGENID_SIZE, MEMREMAP_WB);
> > +       if (!state->next_id) {
> > +               ret = -ENOMEM;
> > +               goto out;
> > +       }
> > +
> > +       memcpy(state->this_id, state->next_id, sizeof(state->this_id));
> > +       add_device_randomness(state->this_id, sizeof(state->this_id));
> 
> 
> Please expose the vmgenid via /sysfs so that user space even remotely has a
> chance to check if it's been cloned.

Export it how?  And why, who would care?

thanks,

greg k-h

  parent reply	other threads:[~2022-02-25 14:37 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-24 13:39 [PATCH v3 0/2] VM fork detection for RNG Jason A. Donenfeld
2022-02-24 13:39 ` [PATCH v3 1/2] random: add mechanism for VM forks to reinitialize crng Jason A. Donenfeld
2022-02-25 11:26   ` Ard Biesheuvel
2022-02-25 11:43     ` Jason A. Donenfeld
2022-02-25 11:44       ` Ard Biesheuvel
2022-02-24 13:39 ` [PATCH v3 2/2] virt: vmgenid: introduce driver for reinitializing RNG on VM fork Jason A. Donenfeld
2022-02-25 10:37   ` Laszlo Ersek
2022-02-25 11:24   ` Ard Biesheuvel
2022-02-25 11:51     ` Michael S. Tsirkin
2022-02-25 12:01       ` Jason A. Donenfeld
2022-02-25 12:00     ` Jason A. Donenfeld
2022-02-25 12:48       ` [PATCH v4] " Jason A. Donenfeld
2022-02-25 12:52         ` Greg KH
2022-02-25 12:53         ` Greg KH
2022-02-25 12:56           ` Jason A. Donenfeld
2022-02-25 15:04           ` Ard Biesheuvel
2022-02-25 13:57         ` Alexander Graf
2022-02-25 14:12           ` Jason A. Donenfeld
2022-02-25 14:18             ` Jason A. Donenfeld
2022-02-25 14:18             ` Alexander Graf
2022-02-25 14:33               ` Jason A. Donenfeld
2022-02-25 15:11                 ` Alexander Graf
2022-02-25 15:16                   ` Ard Biesheuvel
2022-02-25 15:22                     ` Alexander Graf
2022-02-25 15:43                       ` Jason A. Donenfeld
2022-02-25 15:57                         ` Alexander Graf
2022-02-25 15:34                     ` Jason A. Donenfeld
2022-02-25 15:37                       ` Alexander Graf
2022-02-25 15:45                         ` Jason A. Donenfeld
2022-02-25 14:36           ` Greg KH [this message]
2022-02-25 15:31             ` Alexander Graf
2022-02-25 15:36               ` Jason A. Donenfeld
2022-02-25 14:54           ` Jason A. Donenfeld
2022-02-25 15:15             ` Alexander Graf
2022-02-25 15:28               ` Jason A. Donenfeld
2022-02-25 15:03           ` Ard Biesheuvel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YhjphtYyXoYZ9lXY@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=Jason@zx2c4.com \
    --cc=adrian@parity.io \
    --cc=ardb@kernel.org \
    --cc=ben@skyportsystems.com \
    --cc=berrange@redhat.com \
    --cc=colmmacc@amazon.com \
    --cc=decui@microsoft.com \
    --cc=dwmw@amazon.co.uk \
    --cc=ebiggers@kernel.org \
    --cc=ehabkost@redhat.com \
    --cc=graf@amazon.com \
    --cc=haiyangz@microsoft.com \
    --cc=imammedo@redhat.com \
    --cc=jannh@google.com \
    --cc=kvm@vger.kernel.org \
    --cc=kys@microsoft.com \
    --cc=lersek@redhat.com \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-hyperv@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@dominikbrodowski.net \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=raduweis@amazon.com \
    --cc=sthemmin@microsoft.com \
    --cc=tytso@mit.edu \
    --cc=wei.liu@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).