Re: [PATCH 17/30] tracing: Improve panic/die notifiers

Guilherme G. Piccoli
2022-04-29T14:45:33Z

On 29/04/2022 10:56, Steven Rostedt wrote:
> [...]
> No. The fallthrough keyword is only needed when there's code between case
> labels. As it is very common to list multiple cases for the same code path.
> That is:
>
> case DIE_OOPS:
> case PANIC_NOTIFIER:
> do_dump = 1;
> break;
>
> Does not need a fall through label, as there's no code between the DIE_OOPS
> and the PANIC_NOTIFIER. But if you had:
>
> case DIE_OOPS:
> x = true;
> case PANIC_NOTIFIER:
> do_dump = 1;
> break;
>
> Then you do.
>
> -- Steve

Thanks a bunch for the clarification, changed that for V2 =)