From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1EDDC433F5 for ; Mon, 16 May 2022 20:25:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347319AbiEPUZg (ORCPT ); Mon, 16 May 2022 16:25:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41410 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1347243AbiEPUXe (ORCPT ); Mon, 16 May 2022 16:23:34 -0400 Received: from mail-pl1-x629.google.com (mail-pl1-x629.google.com [IPv6:2607:f8b0:4864:20::629]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 909514B405 for ; Mon, 16 May 2022 13:09:57 -0700 (PDT) Received: by mail-pl1-x629.google.com with SMTP id q18so15472188pln.12 for ; Mon, 16 May 2022 13:09:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=wzx7NT/bkCjJnHFo5lwIctB7nDe602qxHRo5R1R5KC0=; b=AMws03KWgp7hhyS5yH0ZZgkyrQGUxWWjom10rEHGW9HVJe/B39vQdFbOzZDngRLz85 11ztlJ90TsfQUyhk0y91m3LCis4j0lmBDTWy8wpzsiElk1XXuk6fnX788cAE6k8QrYwL yT0zTxFfM5QPl22vfnBxoEpoR2ZT9FwAzIynCVhKMued/cmd7czQiTSWJbnLSO8jhzlw 6WSvtvN6wUH++ILH1ZQIUrxoVSwjrESLNF6kRwOXQ/lcD3Fp66CwtWMylB5F7do4Wmqj S4qD+3iee59hXjru6GsfvY4Z89JrB+dkWA6OcH6fkzib1ntLAajlQQMdEXjuzmzzOscb p/bg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=wzx7NT/bkCjJnHFo5lwIctB7nDe602qxHRo5R1R5KC0=; b=XkvD/R9IxjlYOy3tOrREiYhbp6POmWUrPtR7iEhnDdhw3UGqtuMX39qSB1likAJ4HC M1boP4g3/bMgVOQVah+nt0U7T84cg4R1OB5bDMu8PhMk0YFa7b4lZVticobbEox1mDIC v/3FqpyIcPvonvb/3e2KMH30uU1ovyLFv9wmhDTn9cuBZ3tXX15mvGzJDKWH7PmMmED/ YjxjNzJ4sGVtfjkgzdtWIi/1aeOJE9kJ9oajjmYN0cDK4KX/fxlVE8RZxqRscErtvVz6 xuhAbyoKUdCAqQBp/EMbFaxD4POQtjUVaFKmjTRlaf0o3zvwCO/e2ryHewwx9Xlae6qO gx5w== X-Gm-Message-State: AOAM532PPI8Hp2J6KiDch3uI0wmWT8IUSMZtFUTBPvqI3ubxOxHiFCnt 1y2t6TG5g7VW32qJWuVvHwkmlg== X-Google-Smtp-Source: ABdhPJz0Ftz1ke7eSHpyZ28XpMixfb3ZztfsWTYIdzRosBnT6uhFx3Dm1ZEtu6S5LaqcUQfV0PLhHA== X-Received: by 2002:a17:903:1c9:b0:161:89e8:229 with SMTP id e9-20020a17090301c900b0016189e80229mr4616450plh.106.1652731796204; Mon, 16 May 2022 13:09:56 -0700 (PDT) Received: from google.com (157.214.185.35.bc.googleusercontent.com. [35.185.214.157]) by smtp.gmail.com with ESMTPSA id p14-20020a170902780e00b00161a16f0050sm229094pll.222.2022.05.16.13.09.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 May 2022 13:09:55 -0700 (PDT) Date: Mon, 16 May 2022 20:09:52 +0000 From: Sean Christopherson To: Vitaly Kuznetsov Cc: kvm@vger.kernel.org, Paolo Bonzini , Wanpeng Li , Jim Mattson , Michael Kelley , Siddharth Chandrasekaran , linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 15/34] KVM: x86: hyper-v: Introduce kvm_hv_is_tlb_flush_hcall() Message-ID: References: <20220414132013.1588929-1-vkuznets@redhat.com> <20220414132013.1588929-16-vkuznets@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220414132013.1588929-16-vkuznets@redhat.com> Precedence: bulk List-ID: X-Mailing-List: linux-hyperv@vger.kernel.org On Thu, Apr 14, 2022, Vitaly Kuznetsov wrote: > The newly introduced helper checks whether vCPU is performing a > Hyper-V TLB flush hypercall. This is required to filter out L2 TLB > flush hypercalls for processing. > > Signed-off-by: Vitaly Kuznetsov > --- > arch/x86/kvm/hyperv.h | 18 ++++++++++++++++++ > 1 file changed, 18 insertions(+) > > diff --git a/arch/x86/kvm/hyperv.h b/arch/x86/kvm/hyperv.h > index d59f96700104..ca67c18cef2c 100644 > --- a/arch/x86/kvm/hyperv.h > +++ b/arch/x86/kvm/hyperv.h > @@ -170,6 +170,24 @@ static inline void kvm_hv_vcpu_empty_flush_tlb(struct kvm_vcpu *vcpu) > tlb_flush_ring = kvm_hv_get_tlb_flush_ring(vcpu); > tlb_flush_ring->read_idx = tlb_flush_ring->write_idx; > } > + > +static inline bool kvm_hv_is_tlb_flush_hcall(struct kvm_vcpu *vcpu) > +{ > + struct kvm_vcpu_hv *hv_vcpu = to_hv_vcpu(vcpu); > + u16 code; > + > + if (!hv_vcpu) > + return false; > + > + code = is_64_bit_hypercall(vcpu) ? kvm_rcx_read(vcpu) : > + kvm_rax_read(vcpu); Nit, can you align the two expressions? code = is_64_bit_hypercall(vcpu) ? kvm_rcx_read(vcpu) : kvm_rax_read(vcpu); > + > + return (code == HVCALL_FLUSH_VIRTUAL_ADDRESS_SPACE || > + code == HVCALL_FLUSH_VIRTUAL_ADDRESS_LIST || > + code == HVCALL_FLUSH_VIRTUAL_ADDRESS_SPACE_EX || > + code == HVCALL_FLUSH_VIRTUAL_ADDRESS_LIST_EX); > +} > + > void kvm_hv_vcpu_flush_tlb(struct kvm_vcpu *vcpu); > > > -- > 2.35.1 >