* [PATCH] drm/hyperv-drm: Include framebuffer and EDID headers
@ 2022-06-22 8:34 Thomas Zimmermann
2022-06-22 11:57 ` Maxime Ripard
2022-06-22 13:50 ` Ville Syrjälä
0 siblings, 2 replies; 3+ messages in thread
From: Thomas Zimmermann @ 2022-06-22 8:34 UTC (permalink / raw)
To: drawat.floss, airlied, daniel
Cc: linux-hyperv, dri-devel, jani.nikula, ville.syrjala,
Thomas Zimmermann, Maarten Lankhorst, Maxime Ripard, stable
Fix a number of compile errors by including the correct header
files. Examples are shown below.
../drivers/gpu/drm/hyperv/hyperv_drm_modeset.c: In function 'hyperv_blit_to_vram_rect':
../drivers/gpu/drm/hyperv/hyperv_drm_modeset.c:25:48: error: invalid use of undefined type 'struct drm_framebuffer'
25 | struct hyperv_drm_device *hv = to_hv(fb->dev);
| ^~
../drivers/gpu/drm/hyperv/hyperv_drm_modeset.c: In function 'hyperv_connector_get_modes':
../drivers/gpu/drm/hyperv/hyperv_drm_modeset.c:59:17: error: implicit declaration of function 'drm_add_modes_noedid' [-Werror=implicit-function-declaration]
59 | count = drm_add_modes_noedid(connector,
| ^~~~~~~~~~~~~~~~~~~~
../drivers/gpu/drm/hyperv/hyperv_drm_modeset.c:62:9: error: implicit declaration of function 'drm_set_preferred_mode'; did you mean 'drm_mm_reserve_node'? [-Werror=implicit-function-declaration]
62 | drm_set_preferred_mode(connector, hv->preferred_width,
| ^~~~~~~~~~~~~~~~~~~~~~
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Fixes: 76c56a5affeb ("drm/hyperv: Add DRM driver for hyperv synthetic video device")
Cc: Deepak Rawat <drawat.floss@gmail.com>
Cc: Thomas Zimmermann <tzimmermann@suse.de>
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: Maxime Ripard <mripard@kernel.org>
Cc: linux-hyperv@vger.kernel.org
Cc: dri-devel@lists.freedesktop.org
Cc: <stable@vger.kernel.org> # v5.14+
---
drivers/gpu/drm/hyperv/hyperv_drm_modeset.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/hyperv/hyperv_drm_modeset.c b/drivers/gpu/drm/hyperv/hyperv_drm_modeset.c
index 27f4fcb058f9..b8e64dd8d3a6 100644
--- a/drivers/gpu/drm/hyperv/hyperv_drm_modeset.c
+++ b/drivers/gpu/drm/hyperv/hyperv_drm_modeset.c
@@ -7,9 +7,11 @@
#include <drm/drm_damage_helper.h>
#include <drm/drm_drv.h>
+#include <drm/drm_edid.h>
#include <drm/drm_fb_helper.h>
#include <drm/drm_format_helper.h>
#include <drm/drm_fourcc.h>
+#include <drm/drm_framebuffer.h>
#include <drm/drm_gem_atomic_helper.h>
#include <drm/drm_gem_framebuffer_helper.h>
#include <drm/drm_gem_shmem_helper.h>
--
2.36.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] drm/hyperv-drm: Include framebuffer and EDID headers
2022-06-22 8:34 [PATCH] drm/hyperv-drm: Include framebuffer and EDID headers Thomas Zimmermann
@ 2022-06-22 11:57 ` Maxime Ripard
2022-06-22 13:50 ` Ville Syrjälä
1 sibling, 0 replies; 3+ messages in thread
From: Maxime Ripard @ 2022-06-22 11:57 UTC (permalink / raw)
To: Thomas Zimmermann
Cc: drawat.floss, airlied, daniel, linux-hyperv, dri-devel,
jani.nikula, ville.syrjala, Maarten Lankhorst, stable
[-- Attachment #1: Type: text/plain, Size: 1721 bytes --]
On Wed, Jun 22, 2022 at 10:34:13AM +0200, Thomas Zimmermann wrote:
> Fix a number of compile errors by including the correct header
> files. Examples are shown below.
>
> ../drivers/gpu/drm/hyperv/hyperv_drm_modeset.c: In function 'hyperv_blit_to_vram_rect':
> ../drivers/gpu/drm/hyperv/hyperv_drm_modeset.c:25:48: error: invalid use of undefined type 'struct drm_framebuffer'
> 25 | struct hyperv_drm_device *hv = to_hv(fb->dev);
> | ^~
>
> ../drivers/gpu/drm/hyperv/hyperv_drm_modeset.c: In function 'hyperv_connector_get_modes':
> ../drivers/gpu/drm/hyperv/hyperv_drm_modeset.c:59:17: error: implicit declaration of function 'drm_add_modes_noedid' [-Werror=implicit-function-declaration]
> 59 | count = drm_add_modes_noedid(connector,
> | ^~~~~~~~~~~~~~~~~~~~
>
> ../drivers/gpu/drm/hyperv/hyperv_drm_modeset.c:62:9: error: implicit declaration of function 'drm_set_preferred_mode'; did you mean 'drm_mm_reserve_node'? [-Werror=implicit-function-declaration]
> 62 | drm_set_preferred_mode(connector, hv->preferred_width,
> | ^~~~~~~~~~~~~~~~~~~~~~
>
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> Fixes: 76c56a5affeb ("drm/hyperv: Add DRM driver for hyperv synthetic video device")
> Cc: Deepak Rawat <drawat.floss@gmail.com>
> Cc: Thomas Zimmermann <tzimmermann@suse.de>
> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> Cc: Maxime Ripard <mripard@kernel.org>
> Cc: linux-hyperv@vger.kernel.org
> Cc: dri-devel@lists.freedesktop.org
> Cc: <stable@vger.kernel.org> # v5.14+
Acked-by: Maxime Ripard <maxime@cerno.tech>
Maxime
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] drm/hyperv-drm: Include framebuffer and EDID headers
2022-06-22 8:34 [PATCH] drm/hyperv-drm: Include framebuffer and EDID headers Thomas Zimmermann
2022-06-22 11:57 ` Maxime Ripard
@ 2022-06-22 13:50 ` Ville Syrjälä
1 sibling, 0 replies; 3+ messages in thread
From: Ville Syrjälä @ 2022-06-22 13:50 UTC (permalink / raw)
To: Thomas Zimmermann
Cc: drawat.floss, airlied, daniel, linux-hyperv, dri-devel,
jani.nikula, Maarten Lankhorst, Maxime Ripard, stable
On Wed, Jun 22, 2022 at 10:34:13AM +0200, Thomas Zimmermann wrote:
> Fix a number of compile errors by including the correct header
> files. Examples are shown below.
>
> ../drivers/gpu/drm/hyperv/hyperv_drm_modeset.c: In function 'hyperv_blit_to_vram_rect':
> ../drivers/gpu/drm/hyperv/hyperv_drm_modeset.c:25:48: error: invalid use of undefined type 'struct drm_framebuffer'
> 25 | struct hyperv_drm_device *hv = to_hv(fb->dev);
> | ^~
>
> ../drivers/gpu/drm/hyperv/hyperv_drm_modeset.c: In function 'hyperv_connector_get_modes':
> ../drivers/gpu/drm/hyperv/hyperv_drm_modeset.c:59:17: error: implicit declaration of function 'drm_add_modes_noedid' [-Werror=implicit-function-declaration]
> 59 | count = drm_add_modes_noedid(connector,
> | ^~~~~~~~~~~~~~~~~~~~
>
> ../drivers/gpu/drm/hyperv/hyperv_drm_modeset.c:62:9: error: implicit declaration of function 'drm_set_preferred_mode'; did you mean 'drm_mm_reserve_node'? [-Werror=implicit-function-declaration]
> 62 | drm_set_preferred_mode(connector, hv->preferred_width,
> | ^~~~~~~~~~~~~~~~~~~~~~
>
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> Fixes: 76c56a5affeb ("drm/hyperv: Add DRM driver for hyperv synthetic video device")
Presumably should be
Fixes: 720cf96d8fec ("drm: Drop drm_framebuffer.h from drm_crtc.h")
Fixes: 255490f9150d ("drm: Drop drm_edid.h from drm_crtc.h")
Mea culpa
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Cc: Deepak Rawat <drawat.floss@gmail.com>
> Cc: Thomas Zimmermann <tzimmermann@suse.de>
> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> Cc: Maxime Ripard <mripard@kernel.org>
> Cc: linux-hyperv@vger.kernel.org
> Cc: dri-devel@lists.freedesktop.org
> Cc: <stable@vger.kernel.org> # v5.14+
> ---
> drivers/gpu/drm/hyperv/hyperv_drm_modeset.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/hyperv/hyperv_drm_modeset.c b/drivers/gpu/drm/hyperv/hyperv_drm_modeset.c
> index 27f4fcb058f9..b8e64dd8d3a6 100644
> --- a/drivers/gpu/drm/hyperv/hyperv_drm_modeset.c
> +++ b/drivers/gpu/drm/hyperv/hyperv_drm_modeset.c
> @@ -7,9 +7,11 @@
>
> #include <drm/drm_damage_helper.h>
> #include <drm/drm_drv.h>
> +#include <drm/drm_edid.h>
> #include <drm/drm_fb_helper.h>
> #include <drm/drm_format_helper.h>
> #include <drm/drm_fourcc.h>
> +#include <drm/drm_framebuffer.h>
> #include <drm/drm_gem_atomic_helper.h>
> #include <drm/drm_gem_framebuffer_helper.h>
> #include <drm/drm_gem_shmem_helper.h>
> --
> 2.36.1
--
Ville Syrjälä
Intel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-06-22 13:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-06-22 8:34 [PATCH] drm/hyperv-drm: Include framebuffer and EDID headers Thomas Zimmermann
2022-06-22 11:57 ` Maxime Ripard
2022-06-22 13:50 ` Ville Syrjälä
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).