From: Christoph Hellwig <hch@infradead.org>
To: Tianyu Lan <ltykernel@gmail.com>
Cc: hch@infradead.org, m.szyprowski@samsung.com,
robin.murphy@arm.com, michael.h.kelley@microsoft.com,
Tianyu Lan <tiala@microsoft.com>,
iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org,
linux-hyperv@vger.kernel.org
Subject: Re: [PATCH] swiotlb: Clean up some coding style and minor issues
Date: Fri, 22 Jul 2022 08:22:26 -0700 [thread overview]
Message-ID: <YtrAsjp0Fs0ThBa7@infradead.org> (raw)
In-Reply-To: <20220722033846.950237-1-ltykernel@gmail.com>
I've applied this, but then dropped the debugfs changes. I can't find
any good reason why we'd use the _unsafe variant here. Can you resend
that bit and write a commit log clearly documenting the considerations
for it?
next prev parent reply other threads:[~2022-07-22 15:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-22 3:38 [PATCH] swiotlb: Clean up some coding style and minor issues Tianyu Lan
2022-07-22 4:03 ` Michael Kelley (LINUX)
2022-07-22 5:04 ` hch
2022-07-22 5:17 ` Michael Kelley (LINUX)
2022-07-22 15:22 ` Christoph Hellwig [this message]
2022-07-24 13:30 ` Tianyu Lan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YtrAsjp0Fs0ThBa7@infradead.org \
--to=hch@infradead.org \
--cc=iommu@lists.linux-foundation.org \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ltykernel@gmail.com \
--cc=m.szyprowski@samsung.com \
--cc=michael.h.kelley@microsoft.com \
--cc=robin.murphy@arm.com \
--cc=tiala@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).