From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3EB6C19F28 for ; Wed, 3 Aug 2022 09:21:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234178AbiHCJVy (ORCPT ); Wed, 3 Aug 2022 05:21:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40110 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235286AbiHCJVx (ORCPT ); Wed, 3 Aug 2022 05:21:53 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 7501950732 for ; Wed, 3 Aug 2022 02:21:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1659518511; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=wC3/PO//oorDVUr2wMWH5HeOq129lBqXeyqiPu4d5kY=; b=iGuhZM8GEJVF208/FEBK/+yqF11Wo3CFORPoCkyDLXzsLM18IMBmnW7Y9DCX+fye1n7qNG tdtP7z/c9GeCKd/ASfY4QZfRQW5Tv+SM503TFVg96TYfpPK17XcN3dFeYj7AR005UqQRdT v9QoavFn61Zc3k/u73dnlWXWKPC9aSA= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-638-pfCCUwv0NiOp6IpbbF09sw-1; Wed, 03 Aug 2022 05:21:47 -0400 X-MC-Unique: pfCCUwv0NiOp6IpbbF09sw-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 20B4D1C06ED1; Wed, 3 Aug 2022 09:21:46 +0000 (UTC) Received: from localhost (ovpn-13-216.pek2.redhat.com [10.72.13.216]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5FB4E2026D4C; Wed, 3 Aug 2022 09:21:44 +0000 (UTC) Date: Wed, 3 Aug 2022 17:21:41 +0800 From: Baoquan He To: "Guilherme G. Piccoli" Cc: akpm@linux-foundation.org, pmladek@suse.com, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, linux-hyperv@vger.kernel.org, netdev@vger.kernel.org, x86@kernel.org, kernel-dev@igalia.com, kernel@gpiccoli.net, halves@canonical.com, fabiomirmar@gmail.com, alejandro.j.jimenez@oracle.com, andriy.shevchenko@linux.intel.com, arnd@arndb.de, bp@alien8.de, corbet@lwn.net, d.hatayama@jp.fujitsu.com, dave.hansen@linux.intel.com, dyoung@redhat.com, feng.tang@intel.com, gregkh@linuxfoundation.org, mikelley@microsoft.com, hidehiro.kawai.ez@hitachi.com, jgross@suse.com, john.ogness@linutronix.de, keescook@chromium.org, luto@kernel.org, mhiramat@kernel.org, mingo@redhat.com, paulmck@kernel.org, peterz@infradead.org, rostedt@goodmis.org, senozhatsky@chromium.org, stern@rowland.harvard.edu, tglx@linutronix.de, vgoyal@redhat.com, vkuznets@redhat.com, will@kernel.org, Arjan van de Ven , Cong Wang , Sebastian Andrzej Siewior , Valentin Schneider , Xiaoming Ni Subject: Re: [PATCH v2 02/13] notifier: Add panic notifiers info and purge trailing whitespaces Message-ID: References: <20220719195325.402745-1-gpiccoli@igalia.com> <20220719195325.402745-3-gpiccoli@igalia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220719195325.402745-3-gpiccoli@igalia.com> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 Precedence: bulk List-ID: X-Mailing-List: linux-hyperv@vger.kernel.org On 07/19/22 at 04:53pm, Guilherme G. Piccoli wrote: > Although many notifiers are mentioned in the comments, the panic > notifiers infrastructure is not. Also, the file contains some > trailing whitespaces. Fix both issues here. > > Cc: Arjan van de Ven > Cc: Cong Wang > Cc: Sebastian Andrzej Siewior > Cc: Valentin Schneider > Cc: Xiaoming Ni > Signed-off-by: Guilherme G. Piccoli > > --- > > V2: > - no change. > > include/linux/notifier.h | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/include/linux/notifier.h b/include/linux/notifier.h > index aef88c2d1173..d5b01f2e3fcc 100644 > --- a/include/linux/notifier.h > +++ b/include/linux/notifier.h > @@ -208,12 +208,12 @@ static inline int notifier_to_errno(int ret) > > /* > * Declared notifiers so far. I can imagine quite a few more chains > - * over time (eg laptop power reset chains, reboot chain (to clean > + * over time (eg laptop power reset chains, reboot chain (to clean > * device units up), device [un]mount chain, module load/unload chain, > - * low memory chain, screenblank chain (for plug in modular screenblankers) > + * low memory chain, screenblank chain (for plug in modular screenblankers) > * VC switch chains (for loadable kernel svgalib VC switch helpers) etc... > */ > - > + > /* CPU notfiers are defined in include/linux/cpu.h. */ > > /* netdevice notifiers are defined in include/linux/netdevice.h */ > @@ -224,6 +224,8 @@ static inline int notifier_to_errno(int ret) > > /* Virtual Terminal events are defined in include/linux/vt.h. */ > > +/* Panic notifiers are defined in include/linux/panic_notifier.h. */ > + LGTM, Reviewed-by: Baoquan He > #define NETLINK_URELEASE 0x0001 /* Unicast netlink socket released */ > > /* Console keyboard events. > -- > 2.37.1 >