From: Wei Liu <wei.liu@kernel.org>
To: Saurabh Sengar <ssengar@linux.microsoft.com>
Cc: kys@microsoft.com, haiyangz@microsoft.com,
sthemmin@microsoft.com, wei.liu@kernel.org, decui@microsoft.com,
jejb@linux.ibm.com, martin.petersen@oracle.com,
linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH] Drivers: hv: vmbus: Optimize vmbus_on_event
Date: Fri, 23 Sep 2022 09:27:57 +0000 [thread overview]
Message-ID: <Yy18HV8iAFLhF3P/@liuwe-devbox-debian-v2> (raw)
In-Reply-To: <20220815153141.x7q6qryxv25gvjgy@liuwe-devbox-debian-v2>
On Mon, Aug 15, 2022 at 03:31:41PM +0000, Wei Liu wrote:
> On Mon, Jul 25, 2022 at 02:37:28AM -0700, Saurabh Sengar wrote:
> > In the vmbus_on_event loop, 2 jiffies timer will not serve the purpose if
> > callback_fn takes longer. For effective use move this check inside of
> > callback functions where needed. Out of all the VMbus drivers using
> > vmbus_on_event, only storvsc has a high packet volume, thus add this limit
> > only in storvsc callback for now.
> > There is no apparent benefit of loop itself because this tasklet will be
> > scheduled anyway again if there are packets left in ring buffer. This
> > patch removes this unnecessary loop as well.
> >
> > Signed-off-by: Saurabh Sengar <ssengar@linux.microsoft.com>
>
> Unfortunately this missed the recent merge window so it will be picked
> up for the next release.
>
Applied to hyperv-next. Thanks.
prev parent reply other threads:[~2022-09-23 9:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-25 9:37 [PATCH] Drivers: hv: vmbus: Optimize vmbus_on_event Saurabh Sengar
2022-08-02 8:14 ` Praveen Kumar
2022-08-03 4:37 ` Saurabh Singh Sengar
2022-08-04 4:04 ` Michael Kelley (LINUX)
2022-08-15 15:31 ` Wei Liu
2022-09-23 9:27 ` Wei Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yy18HV8iAFLhF3P/@liuwe-devbox-debian-v2 \
--to=wei.liu@kernel.org \
--cc=decui@microsoft.com \
--cc=haiyangz@microsoft.com \
--cc=jejb@linux.ibm.com \
--cc=kys@microsoft.com \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=ssengar@linux.microsoft.com \
--cc=sthemmin@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox