From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7238EC6FA82 for ; Fri, 23 Sep 2022 10:15:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230015AbiIWKPq (ORCPT ); Fri, 23 Sep 2022 06:15:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60972 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231162AbiIWKPm (ORCPT ); Fri, 23 Sep 2022 06:15:42 -0400 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 450D92604; Fri, 23 Sep 2022 03:15:40 -0700 (PDT) Received: by mail-wm1-f52.google.com with SMTP id fn7-20020a05600c688700b003b4fb113b86so2940037wmb.0; Fri, 23 Sep 2022 03:15:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date; bh=H3k8nwYg9LM+0smtYDMfCrY2rja+gudmrYIAx1+mEps=; b=6/f8awuQNJ0pRmjE7SjNSRROM1eCeYPgvkSN0GPMjn/WBJh2zoeTL4X52y/aixVSss Gh3Gu4AtDakwpyrL4N6e9RGJGxH282rc7fBov32flqvO8NsuIkHQh1lcm3Zvyk3oOWO2 Q1pMqEUqXKuWzb5hhckFN6qZ4NxYjSvARjA9E0ocpn2ZoaP9WQIHYSv/PGCy+PLpf8jM Jc5q9TS997twPCVoLul0z861BwyEdlOlq06eWF8iUQFf6+dhVQXT/eRIpnypMRznRRCU Ncx/K+dnJKt87AomFYiP6gK47WsCGUu+bQpk2GWflDxO8XE+N1AMZd445Z4qh7q0PUYa Ov/w== X-Gm-Message-State: ACrzQf2sRJUDurHby/PhsWmfCgihioiQMGlDKDadTwyH1XdPq1hMyS7L o2fA60EPUeXEW9DbuplPTucfuZHbh4A= X-Google-Smtp-Source: AMsMyM6uVc1utll1leFSA3Ob9+kmyV0+mvx+mZpkH4OV2fn7yg3XyYhCkjXBv8PD3H23g3832TOSOw== X-Received: by 2002:a05:600c:2b88:b0:3b4:8680:165b with SMTP id j8-20020a05600c2b8800b003b48680165bmr13130181wmc.113.1663928138757; Fri, 23 Sep 2022 03:15:38 -0700 (PDT) Received: from liuwe-devbox-debian-v2 ([51.145.34.42]) by smtp.gmail.com with ESMTPSA id h6-20020a05600c2ca600b003b4c40378casm2165673wmc.39.2022.09.23.03.15.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Sep 2022 03:15:38 -0700 (PDT) Date: Fri, 23 Sep 2022 10:15:36 +0000 From: Wei Liu To: Saurabh Sengar Cc: ssengar@microsoft.com, drawat.floss@gmail.com, airlied@linux.ie, daniel@ffwll.ch, linux-hyperv@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, mikelley@microsoft.com, Wei Liu Subject: Re: [PATCH] drm/hyperv: Don't overwrite dirt_needed value set by host Message-ID: References: <1662996766-19304-1-git-send-email-ssengar@linux.microsoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1662996766-19304-1-git-send-email-ssengar@linux.microsoft.com> Precedence: bulk List-ID: X-Mailing-List: linux-hyperv@vger.kernel.org On Mon, Sep 12, 2022 at 08:32:46AM -0700, Saurabh Sengar wrote: > Existing code is causing a race condition where dirt_needed value is > already set by the host and gets overwritten with default value. Remove > this default setting of dirt_needed, to avoid overwriting the value > received in the channel callback set by vmbus_open. Removing this > setting also means the default value for dirt_needed is changed to false > as it's allocated by kzalloc which is similar to legacy hyperv_fb driver. > > Signed-off-by: Saurabh Sengar Applied to hyperv-next. Thanks. I ended up reconstructing the patch myself since the said driver changed. It is only a one line change so that's fine. If the committed patch is wrong, please let me know.