[PATCH v1] tools/hv: reduce resouce usage in hv_kvp_daemon

[PATCH v1] tools/hv: reduce resouce usage in hv_kvp_daemon

[Olaf Hering]

hv_kvp_daemon uses popen(3) and system(3) as convinience helper to
launch external helpers. These helpers are invoked via a
temporary shell process. There is no need to keep this temporary
process around while the helper runs. Replace this temporary shell
with the actual helper process via 'exec'.

Signed-off-by: Olaf Hering <olaf@aepfle.de>
---
 tools/hv/hv_kvp_daemon.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/tools/hv/hv_kvp_daemon.c b/tools/hv/hv_kvp_daemon.c
index ae57bf69ad4a..91b50cadfc52 100644
--- a/tools/hv/hv_kvp_daemon.c
+++ b/tools/hv/hv_kvp_daemon.c
@@ -725,7 +725,7 @@ static void kvp_get_ipconfig_info(char *if_name,
 	 * .
 	 */
 
-	sprintf(cmd, KVP_SCRIPTS_PATH "%s",  "hv_get_dns_info");
+	sprintf(cmd, "exec %s", KVP_SCRIPTS_PATH "hv_get_dns_info");
 
 	/*
 	 * Execute the command to gather DNS info.
@@ -742,7 +742,7 @@ static void kvp_get_ipconfig_info(char *if_name,
 	 * Enabled: DHCP enabled.
 	 */
 
-	sprintf(cmd, KVP_SCRIPTS_PATH "%s %s", "hv_get_dhcp_info", if_name);
+	sprintf(cmd, "exec %s %s", KVP_SCRIPTS_PATH "hv_get_dhcp_info", if_name);
 
 	file = popen(cmd, "r");
 	if (file == NULL)
@@ -1606,7 +1606,7 @@ static int kvp_set_ip_info(char *if_name, struct hv_kvp_ipaddr_value *new_val)
 	 * invoke the external script to do its magic.
 	 */
 
-	str_len = snprintf(cmd, sizeof(cmd), KVP_SCRIPTS_PATH "%s %s %s",
+	str_len = snprintf(cmd, sizeof(cmd), "exec %s %s %s", KVP_SCRIPTS_PATH
 			   "hv_set_ifconfig", if_filename, nm_filename);
 	/*
 	 * This is a little overcautious, but it's necessary to suppress some

Re: [PATCH v1] tools/hv: reduce resouce usage in hv_kvp_daemon

[Wei Liu]

On Mon, Dec 02, 2024 at 01:35:16PM +0100, Olaf Hering wrote:
> hv_kvp_daemon uses popen(3) and system(3) as convinience helper to
> launch external helpers. These helpers are invoked via a
> temporary shell process. There is no need to keep this temporary
> process around while the helper runs. Replace this temporary shell
> with the actual helper process via 'exec'.
> 
> Signed-off-by: Olaf Hering <olaf@aepfle.de>

Acked-by: Wei Liu <wei.liu@kernel.org>

Re: [PATCH v1] tools/hv: reduce resouce usage in hv_kvp_daemon

[Wei Liu]

On Sat, Dec 07, 2024 at 07:18:17AM +0000, Wei Liu wrote:
> On Mon, Dec 02, 2024 at 01:35:16PM +0100, Olaf Hering wrote:
> > hv_kvp_daemon uses popen(3) and system(3) as convinience helper to
> > launch external helpers. These helpers are invoked via a
> > temporary shell process. There is no need to keep this temporary
> > process around while the helper runs. Replace this temporary shell
> > with the actual helper process via 'exec'.
> > 
> > Signed-off-by: Olaf Hering <olaf@aepfle.de>
> 
> Acked-by: Wei Liu <wei.liu@kernel.org>

There's one conflict caused by an earlier patch by Vitaly. I've resolved
the conflict and applied the patch to hyperv-fixes. Please check the
final result.

Thanks,
Wei.

Re: [PATCH v1] tools/hv: reduce resouce usage in hv_kvp_daemon

[Olaf Hering]

[-- Attachment #1: Type: text/plain, Size: 310 bytes --]

Sun, 8 Dec 2024 23:52:54 +0000 Wei Liu <wei.liu@kernel.org>:

> There's one conflict caused by an earlier patch by Vitaly. I've resolved
> the conflict and applied the patch to hyperv-fixes. Please check the
> final result.

Commit b8ea8cd0fbd358feee3e9172c5ef8afd671e0d11 looks good, thanks.


Olaf

[-- Attachment #2: Digitale Signatur von OpenPGP --]
[-- Type: application/pgp-signature, Size: 833 bytes --]