public inbox for linux-hyperv@vger.kernel.org
 help / color / mirror / Atom feed
From: Wei Liu <wei.liu@kernel.org>
To: Vitaly Kuznetsov <vkuznets@redhat.com>
Cc: linux-hyperv@vger.kernel.org, mhklinux@outlook.com,
	"K. Y. Srinivasan" <kys@microsoft.com>,
	Haiyang Zhang <haiyangz@microsoft.com>,
	Wei Liu <wei.liu@kernel.org>, Dexuan Cui <decui@microsoft.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] hv/hv_kvp_daemon: Pass NIC name to hv_get_dns_info as well
Date: Sat, 7 Dec 2024 07:56:13 +0000	[thread overview]
Message-ID: <Z1P_naD-PjHimswj@liuwe-devbox-debian-v2> (raw)
In-Reply-To: <20241112150401.217094-1-vkuznets@redhat.com>

On Tue, Nov 12, 2024 at 04:04:01PM +0100, Vitaly Kuznetsov wrote:
> The reference implementation of hv_get_dns_info which is in the tree uses
> /etc/resolv.conf to get DNS servers and this does not require to know which
> NIC is queried. Distro specific implementations, however, may want to
> provide per-NIC, fine grained information. E.g. NetworkManager keeps track
> of DNS servers per connection.
> 
> Similar to hv_get_dhcp_info, pass NIC name as a parameter to
> hv_get_dns_info script.
> 
> Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com>

Applied. Thanks.

> ---
>  tools/hv/hv_kvp_daemon.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/hv/hv_kvp_daemon.c b/tools/hv/hv_kvp_daemon.c
> index ae57bf69ad4a..296a7a62c54d 100644
> --- a/tools/hv/hv_kvp_daemon.c
> +++ b/tools/hv/hv_kvp_daemon.c
> @@ -725,7 +725,7 @@ static void kvp_get_ipconfig_info(char *if_name,
>  	 * .
>  	 */
>  
> -	sprintf(cmd, KVP_SCRIPTS_PATH "%s",  "hv_get_dns_info");
> +	sprintf(cmd, KVP_SCRIPTS_PATH "%s %s", "hv_get_dns_info", if_name);
>  
>  	/*
>  	 * Execute the command to gather DNS info.
> -- 
> 2.47.0
> 

      reply	other threads:[~2024-12-07  7:56 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-12 15:04 [PATCH] hv/hv_kvp_daemon: Pass NIC name to hv_get_dns_info as well Vitaly Kuznetsov
2024-12-07  7:56 ` Wei Liu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z1P_naD-PjHimswj@liuwe-devbox-debian-v2 \
    --to=wei.liu@kernel.org \
    --cc=decui@microsoft.com \
    --cc=haiyangz@microsoft.com \
    --cc=kys@microsoft.com \
    --cc=linux-hyperv@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mhklinux@outlook.com \
    --cc=vkuznets@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox