From: Wei Liu <wei.liu@kernel.org>
To: Roman Kisel <romank@linux.microsoft.com>
Cc: Wei Liu <wei.liu@kernel.org>,
hpa@zytor.com, kys@microsoft.com, bp@alien8.de,
dave.hansen@linux.intel.com, decui@microsoft.com,
eahariha@linux.microsoft.com, haiyangz@microsoft.com,
mingo@redhat.com, mhklinux@outlook.com,
nunodasneves@linux.microsoft.com, tglx@linutronix.de,
tiala@microsoft.com, linux-hyperv@vger.kernel.org,
linux-kernel@vger.kernel.org, x86@kernel.org,
apais@microsoft.com, benhill@microsoft.com,
ssengar@microsoft.com, sunilmut@microsoft.com, vdso@hexbites.dev
Subject: Re: [PATCH v6 0/5] hyperv: Fixes for get_vtl(), hv_vtl_apicid_to_vp_id()
Date: Thu, 9 Jan 2025 21:56:51 +0000 [thread overview]
Message-ID: <Z4BGI-yoptUPbF3v@liuwe-devbox-debian-v2> (raw)
In-Reply-To: <dead87fe-c765-4bcc-a097-fc247ee1adf2@linux.microsoft.com>
On Thu, Jan 09, 2025 at 01:40:34PM -0800, Roman Kisel wrote:
>
>
> On 1/9/2025 12:18 PM, Wei Liu wrote:
> > On Wed, Jan 08, 2025 at 02:21:33PM -0800, Roman Kisel wrote:
> > [...]
> > > Roman Kisel (5):
> > > hyperv: Define struct hv_output_get_vp_registers
> > > hyperv: Fix pointer type in get_vtl(void)
> > > hyperv: Enable the hypercall output page for the VTL mode
> > > hyperv: Do not overlap the hvcall IO areas in get_vtl()
> > > hyperv: Do not overlap the hvcall IO areas in hv_vtl_apicid_to_vp_id()
> >
> > The patches have been pushed to hyperv-next. Roman and Nuno, please
> > check the tree for correctness.
>
> This
>
> ```c
> union hv_arm64_pending_synthetic_exception_event {
> u64 as_uint64[2];
> struct {
> u8 event_pending : 1;
> u8 event_type : 3;
> u8 reserved : 4;
> u8 rsvd[3];
> u64 context;
> } __packed;
> };
> ```
>
> needs to have the `u32 exception_type;` field:
>
> ```c
> union hv_arm64_pending_synthetic_exception_event {
> u64 as_uint64[2];
> struct {
> u8 event_pending : 1;
> u8 event_type : 3;
> u8 reserved : 4;
> u8 rsvd[3];
> u32 exception_type;
> u64 context;
> } __packed;
> };
> ```
> as otherwise the struct won't cover the array.
> Testing the VMs currently with the latest hyperv-next.
Fixed. I c&p'ed the code then deleted the right version of the struct.
Thanks for checking.
Wei.
next prev parent reply other threads:[~2025-01-09 21:56 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-08 22:21 [PATCH v6 0/5] hyperv: Fixes for get_vtl(), hv_vtl_apicid_to_vp_id() Roman Kisel
2025-01-08 22:21 ` [PATCH v6 1/5] hyperv: Define struct hv_output_get_vp_registers Roman Kisel
2025-01-08 23:25 ` Nuno Das Neves
2025-01-09 5:50 ` Wei Liu
2025-01-09 17:25 ` Roman Kisel
2025-01-09 19:09 ` Wei Liu
2025-01-08 22:21 ` [PATCH v6 2/5] hyperv: Fix pointer type in get_vtl(void) Roman Kisel
2025-01-08 22:21 ` [PATCH v6 3/5] hyperv: Enable the hypercall output page for the VTL mode Roman Kisel
2025-01-08 23:27 ` Nuno Das Neves
2025-01-08 22:21 ` [PATCH v6 4/5] hyperv: Do not overlap the hvcall IO areas in get_vtl() Roman Kisel
2025-01-08 22:21 ` [PATCH v6 5/5] hyperv: Do not overlap the hvcall IO areas in hv_vtl_apicid_to_vp_id() Roman Kisel
2025-01-08 23:34 ` Nuno Das Neves
2025-01-09 20:18 ` [PATCH v6 0/5] hyperv: Fixes for get_vtl(), hv_vtl_apicid_to_vp_id() Wei Liu
2025-01-09 20:28 ` Nuno Das Neves
2025-01-09 21:28 ` Roman Kisel
2025-01-09 21:40 ` Roman Kisel
2025-01-09 21:56 ` Wei Liu [this message]
2025-01-09 22:19 ` Roman Kisel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z4BGI-yoptUPbF3v@liuwe-devbox-debian-v2 \
--to=wei.liu@kernel.org \
--cc=apais@microsoft.com \
--cc=benhill@microsoft.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=decui@microsoft.com \
--cc=eahariha@linux.microsoft.com \
--cc=haiyangz@microsoft.com \
--cc=hpa@zytor.com \
--cc=kys@microsoft.com \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mhklinux@outlook.com \
--cc=mingo@redhat.com \
--cc=nunodasneves@linux.microsoft.com \
--cc=romank@linux.microsoft.com \
--cc=ssengar@microsoft.com \
--cc=sunilmut@microsoft.com \
--cc=tglx@linutronix.de \
--cc=tiala@microsoft.com \
--cc=vdso@hexbites.dev \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).