linux-hyperv.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Wei Liu <wei.liu@kernel.org>
To: Shradha Gupta <shradhagupta@linux.microsoft.com>
Cc: linux-kernel@vger.kernel.org, linux-hyperv@vger.kernel.org,
	"K. Y. Srinivasan" <kys@microsoft.com>,
	Haiyang Zhang <haiyangz@microsoft.com>,
	Stephen Hemminger <sthemmin@microsoft.com>,
	Wei Liu <wei.liu@kernel.org>, Dexuan Cui <decui@microsoft.com>,
	Long Li <longli@microsoft.com>,
	Michael Kelley <mikelley@microsoft.com>
Subject: Re: [PATCH] hv/hv_kvp_daemon: Add support for keyfile config based connection profile in NM
Date: Mon, 6 Mar 2023 15:40:54 +0000	[thread overview]
Message-ID: <ZAYJhm9fVAgCtTiC@liuwe-devbox-debian-v2> (raw)
In-Reply-To: <1677133334-6958-1-git-send-email-shradhagupta@linux.microsoft.com>

On Wed, Feb 22, 2023 at 10:22:14PM -0800, Shradha Gupta wrote:
> As communicated in BZ <2122115>, ifcfg config file support in

What is BZ <2122115>? I guess that's Red Hat's bugzilla?

I don't think this is useful information for the commit message, since
the community cannot access that ticket.

> NetworkManger is deprecated. This patch provides support for the
> new keyfile config format for connection profiles in NetworkManager.
> The patch modifies the hv_kvp_daemon code to generate the new network
> configuration in keyfile format(.ini-style format) instead of ifcfg
> format.

Okay, so the wire protocol for the KVP daemon is not changed. It is just
the intermediate file format that's changed.

> This configuration is stored in a temp file which is further translated
> using the hv_set_ifconfig.sh script. This script is implemented by
> individual distros based on the network management commands supported.
> For example, RHEL's implementation could be found here:
> https://gitlab.com/redhat/centos-stream/src/hyperv-daemons/-/blob/c9s/hv_set_ifconfig.sh
> Debian's implementation could be found here:
> https://github.com/endlessm/linux/blob/master/debian/cloud-tools/hv_set_ifconfig
> 
> The next part of this support is to inform the Distro vendors to
> modify these implementations to consume the new configuration format.
> 

I guess they will figure out the format has changed when they upgrade to
a new kernel?

Thanks,
Wei.

  reply	other threads:[~2023-03-06 15:42 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-23  6:22 [PATCH] hv/hv_kvp_daemon: Add support for keyfile config based connection profile in NM Shradha Gupta
2023-03-06 15:40 ` Wei Liu [this message]
2023-03-07  5:24   ` Shradha Gupta
2023-04-13  1:31     ` Wei Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZAYJhm9fVAgCtTiC@liuwe-devbox-debian-v2 \
    --to=wei.liu@kernel.org \
    --cc=decui@microsoft.com \
    --cc=haiyangz@microsoft.com \
    --cc=kys@microsoft.com \
    --cc=linux-hyperv@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=longli@microsoft.com \
    --cc=mikelley@microsoft.com \
    --cc=shradhagupta@linux.microsoft.com \
    --cc=sthemmin@microsoft.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).