From: Wei Liu <wei.liu@kernel.org>
To: Ani Sinha <anisinha@redhat.com>
Cc: "K. Y. Srinivasan" <kys@microsoft.com>,
Haiyang Zhang <haiyangz@microsoft.com>,
Wei Liu <wei.liu@kernel.org>, Dexuan Cui <decui@microsoft.com>,
linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] vmbus_testing: fix wrong python syntax for integer value comparison
Date: Sun, 23 Jul 2023 23:19:47 +0000 [thread overview]
Message-ID: <ZL21k2GWKgZldIq4@liuwe-devbox-debian-v2> (raw)
In-Reply-To: <761F02E9-7A80-486B-8CB4-B5E067D7F587@redhat.com>
On Mon, Jul 17, 2023 at 01:13:25PM +0530, Ani Sinha wrote:
>
>
> > On 05-Jul-2023, at 7:14 PM, Ani Sinha <anisinha@redhat.com> wrote:
> >
> > It is incorrect in python to compare integer values using the "is" keyword.
> > The "is" keyword in python is used to compare references to two objects,
> > not their values. Newer version of python3 (version 3.8) throws a warning
> > when such incorrect comparison is made. For value comparison, "==" should
> > be used.
> >
> > Fix this in the code and suppress the following warning:
> >
> > /usr/sbin/vmbus_testing:167: SyntaxWarning: "is" with a literal. Did you mean "=="?
>
> Ping …
>
Applied to hyperv-fixes. Thanks.
prev parent reply other threads:[~2023-07-23 23:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-05 13:44 [PATCH] vmbus_testing: fix wrong python syntax for integer value comparison Ani Sinha
2023-07-17 7:43 ` Ani Sinha
2023-07-23 23:19 ` Wei Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZL21k2GWKgZldIq4@liuwe-devbox-debian-v2 \
--to=wei.liu@kernel.org \
--cc=anisinha@redhat.com \
--cc=decui@microsoft.com \
--cc=haiyangz@microsoft.com \
--cc=kys@microsoft.com \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox