From: Wei Liu <wei.liu@kernel.org>
To: Saurabh Sengar <ssengar@linux.microsoft.com>
Cc: kys@microsoft.com, haiyangz@microsoft.com, wei.liu@kernel.org,
decui@microsoft.com, tglx@linutronix.de, mingo@redhat.com,
bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org,
hpa@zytor.com, linux-hyperv@vger.kernel.org,
linux-kernel@vger.kernel.org, mikelley@microsoft.com,
vkuznets@redhat.com, ssengar@microsoft.com
Subject: Re: [PATCH v3] x86/hyperv: Restrict get_vtl to only VTL platforms
Date: Fri, 22 Sep 2023 18:41:55 +0000 [thread overview]
Message-ID: <ZQ3f8wY0R8OqEmIl@liuwe-devbox-debian-v2> (raw)
In-Reply-To: <1695182675-13405-1-git-send-email-ssengar@linux.microsoft.com>
On Tue, Sep 19, 2023 at 09:04:35PM -0700, Saurabh Sengar wrote:
> When Linux runs in a non-default VTL (CONFIG_HYPERV_VTL_MODE=y),
> get_vtl() must never fail as its return value is used in negotiations
> with the host. In the more generic case, (CONFIG_HYPERV_VTL_MODE=n) the
> VTL is always zero so there's no need to do the hypercall.
>
> Make get_vtl() BUG() in case of failure and put the implementation under
> "if IS_ENABLED(CONFIG_HYPERV_VTL_MODE)" to avoid the call altogether in
> the most generic use case.
>
> Signed-off-by: Saurabh Sengar <ssengar@linux.microsoft.com>
> Reviewed-by: Vitaly Kuznetsov <vkuznets@redhat.com>
Applied to hyperv-fixes. Thanks.
prev parent reply other threads:[~2023-09-22 18:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-20 4:04 [PATCH v3] x86/hyperv: Restrict get_vtl to only VTL platforms Saurabh Sengar
2023-09-22 18:41 ` Wei Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZQ3f8wY0R8OqEmIl@liuwe-devbox-debian-v2 \
--to=wei.liu@kernel.org \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=decui@microsoft.com \
--cc=haiyangz@microsoft.com \
--cc=hpa@zytor.com \
--cc=kys@microsoft.com \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mikelley@microsoft.com \
--cc=mingo@redhat.com \
--cc=ssengar@linux.microsoft.com \
--cc=ssengar@microsoft.com \
--cc=tglx@linutronix.de \
--cc=vkuznets@redhat.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).