* [PATCH] hyperv: rndis_filter needs to select NLS
@ 2023-09-30 2:32 Randy Dunlap
2023-10-03 10:29 ` Simon Horman
2023-10-03 17:12 ` Michael Kelley (LINUX)
0 siblings, 2 replies; 3+ messages in thread
From: Randy Dunlap @ 2023-09-30 2:32 UTC (permalink / raw)
To: linux-kernel
Cc: Randy Dunlap, Haiyang Zhang, K . Y . Srinivasan, Wei Liu,
Dexuan Cui, linux-hyperv, David S . Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni, netdev
rndis_filter uses utf8s_to_utf16s() which is provided by setting
NLS, so select NLS to fix the build error:
ERROR: modpost: "utf8s_to_utf16s" [drivers/net/hyperv/hv_netvsc.ko] undefined!
Fixes: 1ce09e899d28 ("hyperv: Add support for setting MAC from within guests")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Cc: K. Y. Srinivasan <kys@microsoft.com>
Cc: Wei Liu <wei.liu@kernel.org>
Cc: Dexuan Cui <decui@microsoft.com>
Cc: linux-hyperv@vger.kernel.org
Cc: David S. Miller <davem@davemloft.net>
Cc: Eric Dumazet <edumazet@google.com>
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: Paolo Abeni <pabeni@redhat.com>
Cc: netdev@vger.kernel.org
---
drivers/net/hyperv/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff -- a/drivers/net/hyperv/Kconfig b/drivers/net/hyperv/Kconfig
--- a/drivers/net/hyperv/Kconfig
+++ b/drivers/net/hyperv/Kconfig
@@ -3,5 +3,6 @@ config HYPERV_NET
tristate "Microsoft Hyper-V virtual network driver"
depends on HYPERV
select UCS2_STRING
+ select NLS
help
Select this option to enable the Hyper-V virtual network driver.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] hyperv: rndis_filter needs to select NLS
2023-09-30 2:32 [PATCH] hyperv: rndis_filter needs to select NLS Randy Dunlap
@ 2023-10-03 10:29 ` Simon Horman
2023-10-03 17:12 ` Michael Kelley (LINUX)
1 sibling, 0 replies; 3+ messages in thread
From: Simon Horman @ 2023-10-03 10:29 UTC (permalink / raw)
To: Randy Dunlap
Cc: linux-kernel, Haiyang Zhang, K . Y . Srinivasan, Wei Liu,
Dexuan Cui, linux-hyperv, David S . Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni, netdev
On Fri, Sep 29, 2023 at 07:32:34PM -0700, Randy Dunlap wrote:
> rndis_filter uses utf8s_to_utf16s() which is provided by setting
> NLS, so select NLS to fix the build error:
>
> ERROR: modpost: "utf8s_to_utf16s" [drivers/net/hyperv/hv_netvsc.ko] undefined!
>
> Fixes: 1ce09e899d28 ("hyperv: Add support for setting MAC from within guests")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Reviewed-by: Simon Horman <horms@kernel.org>
Tested-by: Simon Horman <horms@kernel.org> # build-tested
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [PATCH] hyperv: rndis_filter needs to select NLS
2023-09-30 2:32 [PATCH] hyperv: rndis_filter needs to select NLS Randy Dunlap
2023-10-03 10:29 ` Simon Horman
@ 2023-10-03 17:12 ` Michael Kelley (LINUX)
1 sibling, 0 replies; 3+ messages in thread
From: Michael Kelley (LINUX) @ 2023-10-03 17:12 UTC (permalink / raw)
To: Randy Dunlap, linux-kernel@vger.kernel.org
Cc: Haiyang Zhang, KY Srinivasan, Wei Liu, Dexuan Cui,
linux-hyperv@vger.kernel.org, David S . Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni, netdev@vger.kernel.org
From: Randy Dunlap <rdunlap@infradead.org> Sent: Friday, September 29, 2023 7:33 PM
>
Patches for this driver usually use the subject prefix "hv_netvsc: ", not "hyperv".
Other than that minor tweak,
Reviewed-by: Michael Kelley <mikelley@microsoft.com>
> rndis_filter uses utf8s_to_utf16s() which is provided by setting
> NLS, so select NLS to fix the build error:
>
> ERROR: modpost: "utf8s_to_utf16s" [drivers/net/hyperv/hv_netvsc.ko] undefined!
>
> Fixes: 1ce09e899d28 ("hyperv: Add support for setting MAC from within guests")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Haiyang Zhang <haiyangz@microsoft.com>
> Cc: K. Y. Srinivasan <kys@microsoft.com>
> Cc: Wei Liu <wei.liu@kernel.org>
> Cc: Dexuan Cui <decui@microsoft.com>
> Cc: linux-hyperv@vger.kernel.org
> Cc: David S. Miller <davem@davemloft.net>
> Cc: Eric Dumazet <edumazet@google.com>
> Cc: Jakub Kicinski <kuba@kernel.org>
> Cc: Paolo Abeni <pabeni@redhat.com>
> Cc: netdev@vger.kernel.org
> ---
> drivers/net/hyperv/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff -- a/drivers/net/hyperv/Kconfig b/drivers/net/hyperv/Kconfig
> --- a/drivers/net/hyperv/Kconfig
> +++ b/drivers/net/hyperv/Kconfig
> @@ -3,5 +3,6 @@ config HYPERV_NET
> tristate "Microsoft Hyper-V virtual network driver"
> depends on HYPERV
> select UCS2_STRING
> + select NLS
> help
> Select this option to enable the Hyper-V virtual network driver.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-10-03 17:13 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-09-30 2:32 [PATCH] hyperv: rndis_filter needs to select NLS Randy Dunlap
2023-10-03 10:29 ` Simon Horman
2023-10-03 17:12 ` Michael Kelley (LINUX)
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).