From: Wei Liu <wei.liu@kernel.org>
To: Boqun Feng <boqun.feng@gmail.com>
Cc: pmartincic@linux.microsoft.com,
"K. Y. Srinivasan" <kys@microsoft.com>,
Haiyang Zhang <haiyangz@microsoft.com>,
Wei Liu <wei.liu@kernel.org>, Dexuan Cui <decui@microsoft.com>,
linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] hv_utils: Allow implicit ICTIMESYNCFLAG_SYNC
Date: Mon, 4 Dec 2023 05:51:48 +0000 [thread overview]
Message-ID: <ZW1o9BviMl35Da7A@liuwe-devbox-debian-v2> (raw)
In-Reply-To: <ZWjfm25xAqvbQYSf@boqun-archlinux>
On Thu, Nov 30, 2023 at 11:16:43AM -0800, Boqun Feng wrote:
> On Mon, Nov 27, 2023 at 01:35:24PM -0800, pmartincic@linux.microsoft.com wrote:
> > From: Peter Martincic <pmartincic@microsoft.com>
> >
> > Hyper-V hosts can omit the _SYNC flag to due a bug on resume from modern
> > suspend. In such a case, the guest may fail to update its time-of-day to
> > account for the period when it was suspended, and could proceed with a
> > significantly wrong time-of-day. In such a case when the guest is
> > significantly behind, fix it by treating a _SAMPLE the same as if _SYNC
> > was received so that the guest time-of-day is updated.
> >
> > This is hidden behind param hv_utils.timesync_implicit.
> >
> > Signed-off-by: Peter Martincic <pmartincic@microsoft.com>
>
> Looks good to me.
>
> Acked-by: Boqun Feng <boqun.feng@gmail.com>
Applied to hyperv-fixes, thanks!
prev parent reply other threads:[~2023-12-04 5:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-27 21:35 [PATCH v2] hv_utils: Allow implicit ICTIMESYNCFLAG_SYNC pmartincic
2023-11-30 19:16 ` Boqun Feng
2023-12-04 5:51 ` Wei Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZW1o9BviMl35Da7A@liuwe-devbox-debian-v2 \
--to=wei.liu@kernel.org \
--cc=boqun.feng@gmail.com \
--cc=decui@microsoft.com \
--cc=haiyangz@microsoft.com \
--cc=kys@microsoft.com \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmartincic@linux.microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).