linux-hyperv.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Wei Liu <wei.liu@kernel.org>
To: Michael Kelley <mhklinux@outlook.com>
Cc: Wei Liu <wei.liu@kernel.org>,
	Roman Kisel <romank@linux.microsoft.com>,
	"kys@microsoft.com" <kys@microsoft.com>,
	"haiyangz@microsoft.com" <haiyangz@microsoft.com>,
	"decui@microsoft.com" <decui@microsoft.com>,
	"tglx@linutronix.de" <tglx@linutronix.de>,
	"mingo@redhat.com" <mingo@redhat.com>,
	"bp@alien8.de" <bp@alien8.de>,
	"dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
	"x86@kernel.org" <x86@kernel.org>,
	"hpa@zytor.com" <hpa@zytor.com>,
	"linux-hyperv@vger.kernel.org" <linux-hyperv@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/1] x86/hyperv: Set X86_FEATURE_TSC_KNOWN_FREQ when Hyper-V provides frequency
Date: Fri, 23 Aug 2024 21:51:44 +0000	[thread overview]
Message-ID: <ZskEcN2e6-aY4kQV@liuwe-devbox-debian-v2> (raw)
In-Reply-To: <SN6PR02MB4157E061956EF4D394E587D8D4BF2@SN6PR02MB4157.namprd02.prod.outlook.com>

On Tue, Aug 06, 2024 at 02:01:55AM +0000, Michael Kelley wrote:
> From: Wei Liu <wei.liu@kernel.org> Sent: Friday, August 2, 2024 4:50 PM
> > 
> > On Tue, Jun 11, 2024 at 07:51:48AM -0700, Roman Kisel wrote:
> > >
> > >
> > > On 6/5/2024 7:55 PM, mhkelley58@gmail.com wrote:
> > > > From: Michael Kelley <mhklinux@outlook.com>
> > > >
> > > > A Linux guest on Hyper-V gets the TSC frequency from a synthetic MSR, if
> > > > available. In this case, set X86_FEATURE_TSC_KNOWN_FREQ so that Linux
> > > > doesn't unnecessarily do refined TSC calibration when setting up the TSC
> > > > clocksource.
> > > >
> > > > With this change, a message such as this is no longer output during boot
> > > > when the TSC is used as the clocksource:
> > > >
> > > > [    1.115141] tsc: Refined TSC clocksource calibration: 2918.408 MHz
> > > >
> > > > Furthermore, the guest and host will have exactly the same view of the
> > > > TSC frequency, which is important for features such as the TSC deadline
> > > > timer that are emulated by the Hyper-V host.
> > > >
> > > > Signed-off-by: Michael Kelley <mhklinux@outlook.com>
> > > > ---
> > > >   arch/x86/kernel/cpu/mshyperv.c | 1 +
> > > >   1 file changed, 1 insertion(+)
> > > >
> > > > diff --git a/arch/x86/kernel/cpu/mshyperv.c b/arch/x86/kernel/cpu/mshyperv.c
> > > > index e0fd57a8ba84..c3e38eaf6d2f 100644
> > > > --- a/arch/x86/kernel/cpu/mshyperv.c
> > > > +++ b/arch/x86/kernel/cpu/mshyperv.c
> > > > @@ -424,6 +424,7 @@ static void __init ms_hyperv_init_platform(void)
> > > >   	    ms_hyperv.misc_features & HV_FEATURE_FREQUENCY_MSRS_AVAILABLE) {
> > > >   		x86_platform.calibrate_tsc = hv_get_tsc_khz;
> > > >   		x86_platform.calibrate_cpu = hv_get_tsc_khz;
> > > > +		setup_force_cpu_cap(X86_FEATURE_TSC_KNOWN_FREQ);
> > > >   	}
> > > >   	if (ms_hyperv.priv_high & HV_ISOLATION) {
> > >
> > > LGTM
> > >
> > > Reviewed-by: Roman Kisel <romank@linux.microsoft.com>
> > 
> > Applied to hyperv-fixes. Thanks!
> 
> Wei --
> 
> hyperv-fixes isn't showing this patch, or any of the others that your
> emails said you applied last Friday.  Hence the patches aren't in
> linux-next either.  Did something go awry?

The push was not successful. They should show up now.

Sorry for the delay.

Thanks,
Wei.

> 
> Michael

      reply	other threads:[~2024-08-23 21:51 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-06  2:55 [PATCH 1/1] x86/hyperv: Set X86_FEATURE_TSC_KNOWN_FREQ when Hyper-V provides frequency mhkelley58
2024-06-11 14:51 ` Roman Kisel
2024-08-02 23:49   ` Wei Liu
2024-08-06  2:01     ` Michael Kelley
2024-08-23 21:51       ` Wei Liu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZskEcN2e6-aY4kQV@liuwe-devbox-debian-v2 \
    --to=wei.liu@kernel.org \
    --cc=bp@alien8.de \
    --cc=dave.hansen@linux.intel.com \
    --cc=decui@microsoft.com \
    --cc=haiyangz@microsoft.com \
    --cc=hpa@zytor.com \
    --cc=kys@microsoft.com \
    --cc=linux-hyperv@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mhklinux@outlook.com \
    --cc=mingo@redhat.com \
    --cc=romank@linux.microsoft.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).