[PATCH] tools: hv: rm .*.cmd when make clean

linux-hyperv.vger.kernel.org archive mirror
 help / color / mirror / Atom feed

* [PATCH] tools: hv: rm .*.cmd when make clean
@ 2024-09-02  4:21 zhangjiao2
  2024-09-05  5:02 ` Saurabh Singh Sengar
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: zhangjiao2 @ 2024-09-02  4:21 UTC (permalink / raw)
  To: kys; +Cc: haiyangz, wei.liu, decui, linux-hyperv, linux-kernel, zhang jiao

From: zhang jiao <zhangjiao2@cmss.chinamobile.com>

rm .*.cmd when make clean

Signed-off-by: zhang jiao <zhangjiao2@cmss.chinamobile.com>
---
 tools/hv/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/hv/Makefile b/tools/hv/Makefile
index 2e60e2c212cd..34ffcec264ab 100644
--- a/tools/hv/Makefile
+++ b/tools/hv/Makefile
@@ -52,7 +52,7 @@ $(OUTPUT)hv_fcopy_uio_daemon: $(HV_FCOPY_UIO_DAEMON_IN)
 
 clean:
 	rm -f $(ALL_PROGRAMS)
-	find $(or $(OUTPUT),.) -name '*.o' -delete -o -name '\.*.d' -delete
+	find $(or $(OUTPUT),.) -name '*.o' -delete -o -name '\.*.d' -delete -o -name '\.*.cmd' -delete
 
 install: $(ALL_PROGRAMS)
 	install -d -m 755 $(DESTDIR)$(sbindir); \
-- 
2.33.0




^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] tools: hv: rm .*.cmd when make clean
  2024-09-02  4:21 [PATCH] tools: hv: rm .*.cmd when make clean zhangjiao2
@ 2024-09-05  5:02 ` Saurabh Singh Sengar
  2024-09-05  5:20 ` Naman Jain
  2024-09-05  7:24 ` Wei Liu
  2 siblings, 0 replies; 4+ messages in thread
From: Saurabh Singh Sengar @ 2024-09-05  5:02 UTC (permalink / raw)
  To: zhangjiao2; +Cc: kys, haiyangz, wei.liu, decui, linux-hyperv, linux-kernel

On Mon, Sep 02, 2024 at 12:21:03PM +0800, zhangjiao2 wrote:
> From: zhang jiao <zhangjiao2@cmss.chinamobile.com>
> 
> rm .*.cmd when make clean
> 
> Signed-off-by: zhang jiao <zhangjiao2@cmss.chinamobile.com>
> ---
>  tools/hv/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/hv/Makefile b/tools/hv/Makefile
> index 2e60e2c212cd..34ffcec264ab 100644
> --- a/tools/hv/Makefile
> +++ b/tools/hv/Makefile
> @@ -52,7 +52,7 @@ $(OUTPUT)hv_fcopy_uio_daemon: $(HV_FCOPY_UIO_DAEMON_IN)
>  
>  clean:
>  	rm -f $(ALL_PROGRAMS)
> -	find $(or $(OUTPUT),.) -name '*.o' -delete -o -name '\.*.d' -delete
> +	find $(or $(OUTPUT),.) -name '*.o' -delete -o -name '\.*.d' -delete -o -name '\.*.cmd' -delete
>  
>  install: $(ALL_PROGRAMS)
>  	install -d -m 755 $(DESTDIR)$(sbindir); \
> -- 
> 2.33.0
> 
> 

Reviewed-by: Saurabh Sengar <ssengar@linux.microsoft.com> 

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] tools: hv: rm .*.cmd when make clean
  2024-09-02  4:21 [PATCH] tools: hv: rm .*.cmd when make clean zhangjiao2
  2024-09-05  5:02 ` Saurabh Singh Sengar
@ 2024-09-05  5:20 ` Naman Jain
  2024-09-05  7:24 ` Wei Liu
  2 siblings, 0 replies; 4+ messages in thread
From: Naman Jain @ 2024-09-05  5:20 UTC (permalink / raw)
  To: zhangjiao2, kys; +Cc: haiyangz, wei.liu, decui, linux-hyperv, linux-kernel



On 9/2/2024 9:51 AM, zhangjiao2 wrote:
> From: zhang jiao <zhangjiao2@cmss.chinamobile.com>
> 
> rm .*.cmd when make clean
> 
> Signed-off-by: zhang jiao <zhangjiao2@cmss.chinamobile.com>
> ---
>   tools/hv/Makefile | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/hv/Makefile b/tools/hv/Makefile
> index 2e60e2c212cd..34ffcec264ab 100644
> --- a/tools/hv/Makefile
> +++ b/tools/hv/Makefile
> @@ -52,7 +52,7 @@ $(OUTPUT)hv_fcopy_uio_daemon: $(HV_FCOPY_UIO_DAEMON_IN)
>   
>   clean:
>   	rm -f $(ALL_PROGRAMS)
> -	find $(or $(OUTPUT),.) -name '*.o' -delete -o -name '\.*.d' -delete
> +	find $(or $(OUTPUT),.) -name '*.o' -delete -o -name '\.*.d' -delete -o -name '\.*.cmd' -delete
>   
>   install: $(ALL_PROGRAMS)
>   	install -d -m 755 $(DESTDIR)$(sbindir); \

While your patch is supposed to work, below code is another alternative.

diff --git a/tools/hv/Makefile b/tools/hv/Makefile
index 2e60e2c212cd..be90be9d788f 100644
--- a/tools/hv/Makefile
+++ b/tools/hv/Makefile
@@ -52,7 +52,7 @@ $(OUTPUT)hv_fcopy_uio_daemon: $(HV_FCOPY_UIO_DAEMON_IN)

  clean:
         rm -f $(ALL_PROGRAMS)
-       find $(or $(OUTPUT),.) -name '*.o' -delete -o -name '\.*.d' -delete
+       find $(or $(OUTPUT),.) -name '*.o*' -delete


Regards,
Naman

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] tools: hv: rm .*.cmd when make clean
  2024-09-02  4:21 [PATCH] tools: hv: rm .*.cmd when make clean zhangjiao2
  2024-09-05  5:02 ` Saurabh Singh Sengar
  2024-09-05  5:20 ` Naman Jain
@ 2024-09-05  7:24 ` Wei Liu
  2 siblings, 0 replies; 4+ messages in thread
From: Wei Liu @ 2024-09-05  7:24 UTC (permalink / raw)
  To: zhangjiao2; +Cc: kys, haiyangz, wei.liu, decui, linux-hyperv, linux-kernel

On Mon, Sep 02, 2024 at 12:21:03PM +0800, zhangjiao2 wrote:
> From: zhang jiao <zhangjiao2@cmss.chinamobile.com>
> 
> rm .*.cmd when make clean
> 
> Signed-off-by: zhang jiao <zhangjiao2@cmss.chinamobile.com>
> ---
>  tools/hv/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/hv/Makefile b/tools/hv/Makefile
> index 2e60e2c212cd..34ffcec264ab 100644
> --- a/tools/hv/Makefile
> +++ b/tools/hv/Makefile
> @@ -52,7 +52,7 @@ $(OUTPUT)hv_fcopy_uio_daemon: $(HV_FCOPY_UIO_DAEMON_IN)
>  
>  clean:
>  	rm -f $(ALL_PROGRAMS)
> -	find $(or $(OUTPUT),.) -name '*.o' -delete -o -name '\.*.d' -delete
> +	find $(or $(OUTPUT),.) -name '*.o' -delete -o -name '\.*.d' -delete -o -name '\.*.cmd' -delete

Applied to hyperv-fixes. Thanks.

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2024-09-05  7:24 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-09-02  4:21 [PATCH] tools: hv: rm .*.cmd when make clean zhangjiao2
2024-09-05  5:02 ` Saurabh Singh Sengar
2024-09-05  5:20 ` Naman Jain
2024-09-05  7:24 ` Wei Liu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).