From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f202.google.com (mail-pf1-f202.google.com [209.85.210.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BE1CE21325A for ; Tue, 29 Apr 2025 14:05:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.202 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745935539; cv=none; b=mQhfzZ0bXFQIQKsOdHcRv1H0M5bNrnPycvLa36Js/mRAFaJxzrDAp23PiNk1wrlVm0cibTjlAn2V5d6CUJBRpw7mcjTr0AiVwWlrUs8V+vPAqU0CyW4REe+9pzHwO7OEjQQXFTgu8DDScAJyC0lYnT1usLUSFO427/7ULyIyEhk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745935539; c=relaxed/simple; bh=KXkWYlsKpNS7N/qD4ZVXK0LUxaL12ArIUs7VrBlL4YE=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=pc1SCfZPeiWSyaTXRPEiO+eE+KKodFuOvz5FEbVoSsjgcIhfe+L3qN9BkYJEjTcLRClYabqNTJQqDjQT/bgK1wnBTUcsnnExXAyKkKpTZ5OSdf+HVKDabIGVSfWdPChrX4S3COhr8RT+93OHodQffuT48wnHeOUz5C+H3sNc7R8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=gX5PRhX1; arc=none smtp.client-ip=209.85.210.202 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="gX5PRhX1" Received: by mail-pf1-f202.google.com with SMTP id d2e1a72fcca58-739515de999so4687526b3a.1 for ; Tue, 29 Apr 2025 07:05:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1745935537; x=1746540337; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=e3iRogAF7jMgKnBN33JdvjDUDJ4zwxPn8g8eIzFTGjk=; b=gX5PRhX1YoS7a2WlhZXTf6DIeoTRjNLsiV6nrF0Wry6tcLheIt5W4tYOeqAxM+B0ob SNR6TfVfn9ti8GVV52OTR3gDfXgTX1scN6nhnK97vbVHSdVvhOR8po416MYxmQpqGPy3 uVcci5Og8ERFeyblLtEn9pqr5xTf6dlp2uitBBtABEUwGfU+gcroXWenhYTUD3DNKSAU Mq8fhMVMMW2NA3G7S2jKlzOw42ugWUImB5y8G0qQsfpl8cklIWazJi03FNqoTe1F18IJ 6t5EFUQLVRLtxvQmQvUvBfEcm5zOOu0JEOZikfUmfHP6ilCkIGx1mRMLe7JCmgXR4mTd uo+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745935537; x=1746540337; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=e3iRogAF7jMgKnBN33JdvjDUDJ4zwxPn8g8eIzFTGjk=; b=a/Qqnj8LlC81ZVgYecMbqMXPBcTW0frNAsErNjdTQI/Rz0k30I1oePF73BuvnhNw/V MF70JsyugMf3Y2JYV9GdbTNWYPXa3eVphw2MYRQyuEXbKRvNu7IlzUcvpxEQsLUXtIfU yBNSZcBRWFlyS3vTwPGCd9U4jxpwDxLDxdpT9+j04Xprk50OXi74wVacRyxY3VtjkEBk m551vJ0Gvec6rgg8AllhsQnW2pja8V3R6OKE+IA8JwiUZaMKMd59z+IYTKENpvNKyK0Z UkoP05hPC95RoGgmFkkwCzVZqtY3QBUksPrhqh2994LJXqe1+kObJogNKcfT93r/56YY 2Rbw== X-Forwarded-Encrypted: i=1; AJvYcCWKgufD+55+XglQDYtfj2uen3fJ79dICw4qbWcD5KsYlt8exeBSmfwDtyh8AhJBEhWN38oIjVDYbKqoGPU=@vger.kernel.org X-Gm-Message-State: AOJu0YxjrkM9L9AmXOJfaRLYuRJnh8aXNZ71rKv5t9HCikmZvYC1llRz dhFyoIwQHccY7qigBtxa+gC6oHjO03b1ApMaRW2wvhBzH6vL1Phd4Lx4iZyMPnJn+vAefWnAZTI rQg== X-Google-Smtp-Source: AGHT+IHPyWKc1pFYiTsLltKjh9fqoRS9IPxep5Tbp0bhwmCfOvbTbBn36Xk8y6s9Kw1UL81V/oIiaLfCk1c= X-Received: from pfbb10.prod.google.com ([2002:a05:6a00:ac8a:b0:730:7485:6b59]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a00:2e9b:b0:736:4ebd:e5a with SMTP id d2e1a72fcca58-74027231530mr5583562b3a.20.1745935536957; Tue, 29 Apr 2025 07:05:36 -0700 (PDT) Date: Tue, 29 Apr 2025 07:05:35 -0700 In-Reply-To: <20250429100919.GH4198@noisy.programming.kicks-ass.net> Precedence: bulk X-Mailing-List: linux-hyperv@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20250414111140.586315004@infradead.org> <20250414113754.172767741@infradead.org> <7vfbchsyhlsvdl4hszdtmapdghw32nrj2qd652f3pjzg3yb6vn@po3bsa54b6ta> <20250415074421.GI5600@noisy.programming.kicks-ass.net> <20250416083859.GH4031@noisy.programming.kicks-ass.net> <20250426100134.GB4198@noisy.programming.kicks-ass.net> <20250429100919.GH4198@noisy.programming.kicks-ass.net> Message-ID: Subject: Re: [PATCH 3/6] x86/kvm/emulate: Avoid RET for fastops From: Sean Christopherson To: Peter Zijlstra Cc: Josh Poimboeuf , x86@kernel.org, kys@microsoft.com, haiyangz@microsoft.com, wei.liu@kernel.org, decui@microsoft.com, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, hpa@zytor.com, pawan.kumar.gupta@linux.intel.com, pbonzini@redhat.com, ardb@kernel.org, kees@kernel.org, Arnd Bergmann , gregkh@linuxfoundation.org, linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, linux-efi@vger.kernel.org, samitolvanen@google.com, ojeda@kernel.org Content-Type: text/plain; charset="us-ascii" On Tue, Apr 29, 2025, Peter Zijlstra wrote: > On Mon, Apr 28, 2025 at 10:13:31AM -0700, Sean Christopherson wrote: > > On Sat, Apr 26, 2025, Peter Zijlstra wrote: > > > On Wed, Apr 16, 2025 at 10:38:59AM +0200, Peter Zijlstra wrote: > > > > > > > Yeah, I finally got there. I'll go cook up something else. > > > > > > Sean, Paolo, can I once again ask how best to test this fastop crud? > > > > Apply the below, build KVM selftests, > > Patch applied, my own hackery applied, host kernel built and booted, > foce_emulation_prefix set, but now I'm stuck at this seemingly simple > step.. > > $ cd tools/testing/selftests/kvm/ > $ make > ... metric ton of fail ... > > Clearly I'm doing something wrong :/ Did you install headers in the top level directory? I.e. make headers_install. The selftests build system was change a while back to require users to manually install headers (I forget why, but it is indeed annoying).