From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 77B302627E9; Tue, 20 May 2025 18:55:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=13.77.154.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747767353; cv=none; b=ATHJi09OS8+inAk0TCRP/4jCClU1G6XMSYpU69R+og/ho6OxzBaUeUat7qTR9a+ud96M27dejZxaea/hcsjX9QcDjVVVEAPQ2oETJK7w9e8u9txyOPnkBg/xisLYJ07wUDOOOBA+hozGALUQzBMltQSlMHYkoYtPB4AlFy9b/kc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747767353; c=relaxed/simple; bh=JO3/PFMj7GaFtU0wAdne8S+wB1wMnfPJJ06xM5LKk7Q=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Pq8aBdfOBjQORiZttelqeRlIkS0mVIxtQre3IWjrIQUo5RmCEa7u+9aqsdSlzRRMpG9mXGrf0uSIf0fihh7ExjYwCqPGBiKMsLzcZqNVav6zTgWSfm/CnxXN6U9utwD5dWqAGMx+Fqi/iWV6iarnjnBDh1b5RvqugaON9bq2lKU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.microsoft.com; spf=pass smtp.mailfrom=linux.microsoft.com; dkim=pass (1024-bit key) header.d=linux.microsoft.com header.i=@linux.microsoft.com header.b=RkF1JE4k; arc=none smtp.client-ip=13.77.154.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.microsoft.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.microsoft.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.microsoft.com header.i=@linux.microsoft.com header.b="RkF1JE4k" Received: from skinsburskii. (unknown [20.236.11.42]) by linux.microsoft.com (Postfix) with ESMTPSA id D5C6C201DB29; Tue, 20 May 2025 11:55:50 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com D5C6C201DB29 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1747767351; bh=rnzuHWLBs6fMHhLe9DNedat8OC9NDm47VDb4X1fbsu4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=RkF1JE4k6zHDa7y0B69rbUrNktJv9csOFMAL5qCTK3fehwWmrE0X7RmvpcF84I0Er +tc+nlyim/BVCP+gUwmjOx8EdATJx9jjgyxFYIV3wFF9y/wRfuuI681zdk4ayYtKUK hQsGEXcuolmZI/P7+Xp1OaAV2vKCR4h99s9J2XBw= Date: Tue, 20 May 2025 11:55:46 -0700 From: Stanislav Kinsburskii To: Naman Jain Cc: "K . Y . Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Roman Kisel , Anirudh Rayabharam , Saurabh Sengar , Nuno Das Neves , ALOK TIWARI , linux-kernel@vger.kernel.org, linux-hyperv@vger.kernel.org Subject: Re: [PATCH v3 2/2] Drivers: hv: Introduce mshv_vtl driver Message-ID: References: <20250519045642.50609-1-namjain@linux.microsoft.com> <20250519045642.50609-3-namjain@linux.microsoft.com> Precedence: bulk X-Mailing-List: linux-hyperv@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250519045642.50609-3-namjain@linux.microsoft.com> On Mon, May 19, 2025 at 10:26:42AM +0530, Naman Jain wrote: > Provide an interface for Virtual Machine Monitor like OpenVMM and its > use as OpenHCL paravisor to control VTL0 (Virtual trust Level). > Expose devices and support IOCTLs for features like VTL creation, > VTL0 memory management, context switch, making hypercalls, > mapping VTL0 address space to VTL2 userspace, getting new VMBus > messages and channel events in VTL2 etc. > > Co-developed-by: Roman Kisel > Signed-off-by: Roman Kisel > Co-developed-by: Saurabh Sengar > Signed-off-by: Saurabh Sengar > Reviewed-by: Roman Kisel > Reviewed-by: Alok Tiwari > Message-ID: <20250512140432.2387503-3-namjain@linux.microsoft.com> > Signed-off-by: Naman Jain > --- > drivers/hv/Kconfig | 20 + > drivers/hv/Makefile | 7 +- > drivers/hv/mshv_vtl.h | 52 + > drivers/hv/mshv_vtl_main.c | 1783 +++++++++++++++++++++++++++++++++++ > include/hyperv/hvgdk_mini.h | 81 ++ > include/hyperv/hvhdk.h | 1 + > include/uapi/linux/mshv.h | 82 ++ > 7 files changed, 2025 insertions(+), 1 deletion(-) > create mode 100644 drivers/hv/mshv_vtl.h > create mode 100644 drivers/hv/mshv_vtl_main.c > > diff --git a/drivers/hv/Kconfig b/drivers/hv/Kconfig > index eefa0b559b73..21cee5564d70 100644 > --- a/drivers/hv/Kconfig > +++ b/drivers/hv/Kconfig > @@ -72,4 +72,24 @@ config MSHV_ROOT > > If unsure, say N. > > +config MSHV_VTL > + tristate "Microsoft Hyper-V VTL driver" > + depends on HYPERV && X86_64 > + depends on TRANSPARENT_HUGEPAGE Why does it depend on TRANSPARENT_HUGEPAGE? > diff --git a/include/hyperv/hvgdk_mini.h b/include/hyperv/hvgdk_mini.h > index 1be7f6a02304..cc11000e39f4 100644 > --- a/include/hyperv/hvgdk_mini.h > +++ b/include/hyperv/hvgdk_mini.h > @@ -882,6 +882,23 @@ struct hv_get_vp_from_apic_id_in { > u32 apic_ids[]; > } __packed; > > +union hv_register_vsm_partition_config { > + __u64 as_u64; Please, follow the file pattern: as_u64 -> as_uint64 > + struct { > + __u64 enable_vtl_protection : 1; Ditto: __u64 -> u64 > + __u64 default_vtl_protection_mask : 4; > + __u64 zero_memory_on_reset : 1; > + __u64 deny_lower_vtl_startup : 1; > + __u64 intercept_acceptance : 1; > + __u64 intercept_enable_vtl_protection : 1; > + __u64 intercept_vp_startup : 1; > + __u64 intercept_cpuid_unimplemented : 1; > + __u64 intercept_unrecoverable_exception : 1; > + __u64 intercept_page : 1; > + __u64 mbz : 51; > + }; > +}; > + > /* > diff --git a/include/hyperv/hvhdk.h b/include/hyperv/hvhdk.h > index b4067ada02cf..9b890126e8e8 100644 > --- a/include/hyperv/hvhdk.h > +++ b/include/hyperv/hvhdk.h > @@ -479,6 +479,7 @@ struct hv_connection_info { > #define HV_EVENT_FLAGS_COUNT (256 * 8) > #define HV_EVENT_FLAGS_BYTE_COUNT (256) > #define HV_EVENT_FLAGS32_COUNT (256 / sizeof(u32)) > +#define HV_EVENT_FLAGS_LONG_COUNT (HV_EVENT_FLAGS_BYTE_COUNT / sizeof(__u64)) Ditto > > /* linux side we create long version of flags to use long bit ops on flags */ > #define HV_EVENT_FLAGS_UL_COUNT (256 / sizeof(ulong)) > diff --git a/include/uapi/linux/mshv.h b/include/uapi/linux/mshv.h > index 876bfe4e4227..a8c39b08b39a 100644 > --- a/include/uapi/linux/mshv.h > +++ b/include/uapi/linux/mshv.h > @@ -288,4 +288,86 @@ struct mshv_get_set_vp_state { > * #define MSHV_ROOT_HVCALL _IOWR(MSHV_IOCTL, 0x07, struct mshv_root_hvcall) > */ > > +/* Structure definitions, macros and IOCTLs for mshv_vtl */ > + > +#define MSHV_CAP_CORE_API_STABLE 0x0 > +#define MSHV_CAP_REGISTER_PAGE 0x1 > +#define MSHV_CAP_VTL_RETURN_ACTION 0x2 > +#define MSHV_CAP_DR6_SHARED 0x3 > +#define MSHV_MAX_RUN_MSG_SIZE 256 > + > +#define MSHV_VP_MAX_REGISTERS 128 > + > +struct mshv_vp_registers { > + __u32 count; /* at most MSHV_VP_MAX_REGISTERS */ Same here: __u{32,64} -> u{32,64}. Please, address everywhere. > + > +/* vtl device */ > +#define MSHV_CREATE_VTL _IOR(MSHV_IOCTL, 0x1D, char) > +#define MSHV_VTL_ADD_VTL0_MEMORY _IOW(MSHV_IOCTL, 0x21, struct mshv_vtl_ram_disposition) > +#define MSHV_VTL_SET_POLL_FILE _IOW(MSHV_IOCTL, 0x25, struct mshv_vtl_set_poll_file) > +#define MSHV_VTL_RETURN_TO_LOWER_VTL _IO(MSHV_IOCTL, 0x27) > +#define MSHV_GET_VP_REGISTERS _IOWR(MSHV_IOCTL, 0x05, struct mshv_vp_registers) > +#define MSHV_SET_VP_REGISTERS _IOW(MSHV_IOCTL, 0x06, struct mshv_vp_registers) > + > +/* VMBus device IOCTLs */ > +#define MSHV_SINT_SIGNAL_EVENT _IOW(MSHV_IOCTL, 0x22, struct mshv_vtl_signal_event) > +#define MSHV_SINT_POST_MESSAGE _IOW(MSHV_IOCTL, 0x23, struct mshv_vtl_sint_post_msg) > +#define MSHV_SINT_SET_EVENTFD _IOW(MSHV_IOCTL, 0x24, struct mshv_vtl_set_eventfd) > +#define MSHV_SINT_PAUSE_MESSAGE_STREAM _IOW(MSHV_IOCTL, 0x25, struct mshv_sint_mask) > + > +/* hv_hvcall device */ > +#define MSHV_HVCALL_SETUP _IOW(MSHV_IOCTL, 0x1E, struct mshv_vtl_hvcall_setup) > +#define MSHV_HVCALL _IOWR(MSHV_IOCTL, 0x1F, struct mshv_vtl_hvcall) How many of these ioctls are actually used by the mshv root driver? Should those which are VTl-specific be named as such (like MSHV_VTL_SET_POLL_FILE)? Another option would be to keep all the names generic. Thanks, Stanislav > #endif > -- > 2.34.1 >