From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f73.google.com (mail-pj1-f73.google.com [209.85.216.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3FBCA2DC32C for ; Fri, 14 Nov 2025 18:35:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.73 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763145344; cv=none; b=te2RuocxnDWUWbLtNWSBlmKPH0X1vD/ZFAGVCDssE1pVnCtY1NrkOh/uQpxCDHc29YQRRjvJAaStaSfR6Cda8F3ROdFzGOhk9h4D2vEgvGb0wBOUfooyH+9huwnIJsHNjCqoEWIwyy6Lv6Hwip6EXMvepNdimKognBZdIEGtTTQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763145344; c=relaxed/simple; bh=KyhFs8L8GdU7c1klqSuB5uwPjA7wvbExcuBhsYGxqZM=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=LjmHiYp3qHPnZCWYRjgpgd06bvNY93/ojc+4vUN37b92hFutC69vaiQO2NPGFqk+Fidc/NRwO4LVkUXAMeOkt48LHKi6IDkJp/JVF4b96ZCmMbZw6cZ3y3eNLFk1w9Dkzhn7zAl+8GZ3KIQnViE299qs4jK4/7x5ZFZZnypTsaA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=JvXbwxTi; arc=none smtp.client-ip=209.85.216.73 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="JvXbwxTi" Received: by mail-pj1-f73.google.com with SMTP id 98e67ed59e1d1-342701608e2so2774937a91.1 for ; Fri, 14 Nov 2025 10:35:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1763145342; x=1763750142; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=lh4Z8xcO9m7bNqIc8uInEiX49gZLzo1eqW42/iCQjS8=; b=JvXbwxTirRLLD7fvS54MiRdoPCPxaHcW09XvtnLF5zmjrGLY/AaaCQFaGWKb3vW+Le 6xYQ9OZQjkaJEOBnf/T0WKOU+hh8hUNsAYGBb9yPsRnERbkt79x0NLsravy38kvSHap7 7f6SQ6axuVy2SwCHBDRBTRnuPz22TuHaXRWAOkDHvotYV0eOh3Dmt0EWqgr1LhedtvM/ o/YYIeLuHmmMd6OPWQYzm7i1ceq1e3Fvt77wTKkfJD7A3IX/XZIdQwny+ilLw7+XXW5k SsIfZZ9m64RfEnFp6T1Nif/hbQFTY7ew+BghD95uyWi46aHcJqquTAGbluSYa+UBRY+o IfCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763145342; x=1763750142; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=lh4Z8xcO9m7bNqIc8uInEiX49gZLzo1eqW42/iCQjS8=; b=CasEXw+EBCQnR48O9janDDqVfmdSDtHIS0ddLQbBmHmyeXvdPu8iUihsqH8rqC2+w+ hklDr6XZdgC+hx86Svsjgun59XaxrCQF5C3mvaxmPV/tNw4VcYdcGSQ9CVT6VAeF9D20 g2FCSTrHj/twpagI/3YG5W/p54cZV5FDgxdC6mFMnd4sIVuWwVM8YfxBoaIhoCF1Ukel njIKsY42eKSNPnDhDnYDxL7P47P1F65R8XJqTO2m7xc42/KR0JgMX4bFJfm4dhF6abOD Ga72baP3x0fTTcv76eUvldouUAB3RQ74G0IFEBjkyPe4c4kxvqAiQnuTjnvdGYWIXxcL eRAA== X-Forwarded-Encrypted: i=1; AJvYcCVEgRAlm5r+kEAaolYejUogaZWHtmE1glSSVCBOkivi0kTCjusflf6turBJzqUQUr3QOGFETSKJWj2NeHY=@vger.kernel.org X-Gm-Message-State: AOJu0Yx3Oo1JQqRhwfIMuTUVkbwzZR3sUlDKeWg1fbysrbf5c90kZ6ls Ak+7o8I5UGFot6WVJEUfGpqEtLCR+hZOx4wPXTwneIgONiEEaCo7FstQgkchuva7Yvq3HBzj89S 2r76MrA== X-Google-Smtp-Source: AGHT+IFshqMuynYh4GEeQYqlqgZcZ72XH4rEskiUXOCzisvk31oYAN2aB7kGMtDQLc0ydZlOgGkfzKUUpEM= X-Received: from pjbcz5.prod.google.com ([2002:a17:90a:d445:b0:340:bde5:c9ee]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a17:90b:2890:b0:340:bb5c:7dd7 with SMTP id 98e67ed59e1d1-343f9e92771mr4385141a91.5.1763145342586; Fri, 14 Nov 2025 10:35:42 -0800 (PST) Date: Fri, 14 Nov 2025 10:35:41 -0800 In-Reply-To: <20251114182921.GB1725668@liuwe-devbox-debian-v2.local> Precedence: bulk X-Mailing-List: linux-hyperv@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20251113225621.1688428-1-seanjc@google.com> <20251113225621.1688428-8-seanjc@google.com> <20251114182921.GB1725668@liuwe-devbox-debian-v2.local> Message-ID: Subject: Re: [PATCH 7/9] KVM: SVM: Treat exit_code as an unsigned 64-bit value through all of KVM From: Sean Christopherson To: Wei Liu Cc: Michael Kelley , Paolo Bonzini , Vitaly Kuznetsov , "K. Y. Srinivasan" , Haiyang Zhang , Dexuan Cui , Nuno Das Neves , "kvm@vger.kernel.org" , "linux-hyperv@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Jim Mattson , Yosry Ahmed Content-Type: text/plain; charset="us-ascii" On Fri, Nov 14, 2025, Wei Liu wrote: > On Fri, Nov 14, 2025 at 07:22:41AM -0800, Sean Christopherson wrote: > > Ah, my PDF copy is just stale, it's indeed > > defined as a synthetic exit. > > > > https://learn.microsoft.com/en-us/virtualization/hyper-v-on-windows/tlfs/nested-virtualization#synthetic-vm-exit > > > > Anyways, I'm in favor of making HV_SVM_EXITCODE_ENL an ull, though part of me > > wonders if we should do: > > > > #define HV_SVM_EXITCODE_ENL SVM_EXIT_SW > > I know this is very tempting, but these headers are supposed to mirror > Microsoft's internal headers, so we would like to keep them > self-contained for ease of tracking. Ya, no argument from me. Aha! Even better, what I can do is have KVM assert that HV_SVM_EXITCODE_ENL == SVM_EXIT_SW in the KVM Hyper-V code, because what I really want to do is connect the dots for KVM folks. > It should be fine to add the "ull" suffix here. I briefly talked to a > hypervisor developer and they agreed. Nice, thanks much!