From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f74.google.com (mail-pj1-f74.google.com [209.85.216.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 009CA32C950 for ; Fri, 14 Nov 2025 15:27:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.74 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763134063; cv=none; b=hO12waiEdSRxOixhpk6FqnsTCGebwoc0dIjMAa5U3m/cJ83KZuUbgJww/1cTDHrEb9jTm0fdAVQFmQd99TZF7ay5ojQzPpFV4RJcusJHKyxe3V5QUqF/XfBHbQMG0lGiPHdFmFTbaQGKg1EmwrrScOA3lSaYK7YSVxi7MDhDmVo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763134063; c=relaxed/simple; bh=Js8j/NG9gqdlcvCQlJveM0zst979u1fWcjgGE8CbeDM=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Content-Type; b=jU7SXhQN6GqwAORcExFfx85VuV/Z9giLN6aZiMESza1mrjFp9pzDBDTRJBGZKB7oSdXe4aLZysMPfsGmYmX4NCJPp0RdBmaGBAYAzsr+hYg0p3+zt+fl7TiKOWqVaS4F/NMOz2NtXudncHpl1mUTKIcy8oS0WH/5Pqy1esIeoR0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=hD8rCw8G; arc=none smtp.client-ip=209.85.216.74 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="hD8rCw8G" Received: by mail-pj1-f74.google.com with SMTP id 98e67ed59e1d1-34378c914b4so3428381a91.1 for ; Fri, 14 Nov 2025 07:27:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1763134061; x=1763738861; darn=vger.kernel.org; h=to:from:subject:message-id:references:mime-version:in-reply-to:date :from:to:cc:subject:date:message-id:reply-to; bh=P7qur3oNJDjn0ufieeTMCoxJ9koWZdOXvP4VkDtArKY=; b=hD8rCw8GtND9oje3xhdCOQOLibtfYhx3FpA3wxm494z2o5mZugDhPz/Q5xFFUlwIxH CRcyRQrVsCt2obW/qn5ZDdOywbZUISCCcsYAO0m/VQrFEsxFmOxsW1D0sKGOjvHopYUZ O+KcudTGXpMmicXibIuLrDZuSomBseKX9tp5xpiJswAv4xdkKgAI9qyBNH+gYepnHUJ2 +17M3QqAO4R+hB9f8nL8JompXAaEMK1gimOq15pxoaHmw+O5SKYm151HnaqBtNdE48kn 5bpHwz/sBtkFXIaubm/sbBCIPUu4+MbnE3yBtJ8j9wYeSiMdSaN47twyLMNAyJH8v2pA biAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763134061; x=1763738861; h=to:from:subject:message-id:references:mime-version:in-reply-to:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=P7qur3oNJDjn0ufieeTMCoxJ9koWZdOXvP4VkDtArKY=; b=o+i+ejrzRcw/pQVzmJKz7T54bYU+2yFW+N6Tg6e8xztDNDwZGHT7wXg6vtJCnV71ez xS+UgcURXhR7ekzR6ktcDuKZFQKvuixm+mvVigG4JFSvYfmozHN4wtpfQwonrhIqftlW unpz96csa75PEed3rr3NvIvaKxNINMKe/t7EYARS0ZKhHq1HzzlvHTHS0ZoOCnG+k0Aj +eJ/Knkf8V7OhqwM7ISmceMM0AVc7p7ijUjhBEq2XZlA+jx5gq7GUzMFCYa+jQeggKzc 3SeTt80I4O6WcpeYyk9HR1NeaFZ1fvyhT9nRMTxbfuDBwmgcQ7glIxCaDrp2WMMUI50y BZ5g== X-Forwarded-Encrypted: i=1; AJvYcCVe0EoCMOguJURi6zfyV8Er0lFr26xFhbEt+uxOuGGNxwmqjfb72dzb3BKUTiAZndj6AQmmomHgQ3vSPSo=@vger.kernel.org X-Gm-Message-State: AOJu0YzdftR8L0SJv/yuYGb1PZsnwl9kCnzWrBZKj3DFU/AyQCWViTr4 eIK8iBBOpEmTz+FcL9XKhWEmBnGXzi3y84++FRUhReKGHj02SDiWNSoEt8Vu6WWvulmvNEuzBvV KUmMe4Q== X-Google-Smtp-Source: AGHT+IGaZMsok9zj7+AIZxZQZifyj8jg6T9CJOKyvCnzF6EFugGvhUwNvNxHTPEHPKDJPPYyf/bpN+dPvCQ= X-Received: from pjoa6.prod.google.com ([2002:a17:90a:8c06:b0:342:b238:e0ad]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a17:90b:2685:b0:33b:b078:d6d3 with SMTP id 98e67ed59e1d1-343fa62bf74mr3886801a91.23.1763134061288; Fri, 14 Nov 2025 07:27:41 -0800 (PST) Date: Fri, 14 Nov 2025 07:27:39 -0800 In-Reply-To: <20251113225621.1688428-8-seanjc@google.com> Precedence: bulk X-Mailing-List: linux-hyperv@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20251113225621.1688428-1-seanjc@google.com> <20251113225621.1688428-8-seanjc@google.com> Message-ID: Subject: Re: [PATCH 7/9] KVM: SVM: Treat exit_code as an unsigned 64-bit value through all of KVM From: Sean Christopherson To: Paolo Bonzini , Vitaly Kuznetsov , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , kvm@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org, Jim Mattson , Yosry Ahmed Content-Type: text/plain; charset="us-ascii" On Thu, Nov 13, 2025, Sean Christopherson wrote: > Fix KVM's long-standing buggy handling of SVM's exit_code as a 32-bit > value. Per the APM and Xen commit d1bd157fbc ("Big merge the HVM > full-virtualisation abstractions.") (which is arguably more trustworthy > than KVM), offset 0x70 is a single 64-bit value: > > 070h 63:0 EXITCODE > > Track exit_code as a single u64 to prevent reintroducing bugs where KVM > neglects to correctly set bits 63:32. > > Fixes: 6aa8b732ca01 ("[PATCH] kvm: userspace interface") > Cc: Jim Mattson > Cc: Yosry Ahmed > Signed-off-by: Sean Christopherson > --- ... > diff --git a/arch/x86/kvm/trace.h b/arch/x86/kvm/trace.h > index e79bc9cb7162..4c7a5cd10990 100644 > --- a/arch/x86/kvm/trace.h > +++ b/arch/x86/kvm/trace.h > @@ -781,7 +781,7 @@ TRACE_EVENT_KVM_EXIT(kvm_nested_vmexit); > * Tracepoint for #VMEXIT reinjected to the guest > */ > TRACE_EVENT(kvm_nested_vmexit_inject, > - TP_PROTO(__u32 exit_code, > + TP_PROTO(__u64 exit_code, > __u64 exit_info1, __u64 exit_info2, > __u32 exit_int_info, __u32 exit_int_info_err, __u32 isa), > TP_ARGS(exit_code, exit_info1, exit_info2, As pointed out by the test bot[*], the trace macro to print exit reasons needs to use 64-bit variants to play nice with 32-bit builds. And now I'm questioning all of my testing, because my build setup detects that as well, _and_ the hyperv_svm_test selftest fails. *sigh* diff --git a/arch/x86/kvm/trace.h b/arch/x86/kvm/trace.h index 4c7a5cd10990..0fd72ce83926 100644 --- a/arch/x86/kvm/trace.h +++ b/arch/x86/kvm/trace.h @@ -383,10 +383,10 @@ TRACE_EVENT(kvm_apic, #define kvm_print_exit_reason(exit_reason, isa) \ (isa == KVM_ISA_VMX) ? \ __print_symbolic(exit_reason & 0xffff, VMX_EXIT_REASONS) : \ - __print_symbolic(exit_reason, SVM_EXIT_REASONS), \ + __print_symbolic64(exit_reason, SVM_EXIT_REASONS), \ (isa == KVM_ISA_VMX && exit_reason & ~0xffff) ? " " : "", \ (isa == KVM_ISA_VMX) ? \ - __print_flags(exit_reason & ~0xffff, " ", VMX_EXIT_REASON_FLAGS) : "" + __print_flags64(exit_reason & ~0xffff, " ", VMX_EXIT_REASON_FLAGS) : "" #define TRACE_EVENT_KVM_EXIT(name) \ TRACE_EVENT(name, [*] https://lore.kernel.org/all/202511141707.t4ad044J-lkp@intel.com