From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B4E98C54EE9 for ; Sun, 18 Sep 2022 14:05:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229501AbiIROFf (ORCPT ); Sun, 18 Sep 2022 10:05:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51128 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229781AbiIROFe (ORCPT ); Sun, 18 Sep 2022 10:05:34 -0400 Received: from fanzine2.igalia.com (fanzine.igalia.com [178.60.130.6]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6FCD3175B0; Sun, 18 Sep 2022 07:05:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=oqYUV0dWvcAo5VH7CFm/kLo2npwHY9kSddzY1OFsLfY=; b=UCgpbY6iwSSbEjm0uugXupccuO /lpQvNeWhP9/TfyCqoizhm6858ZNRSEeaQJYMCSVwsj/4UlJBP8nyESONeNp1HUuwStFD50uCGR1T 08kEXe2PM2g73CwCScXcvthVd+D0nna9bnbHMvSD92cxC08Xt/3gNgPbORYTdAmU9BabBtZ43d5eA cABINOw87ofdrfB5BwdVaGEn4lJADJ927HqqT0D4CUh4xhQgnHJbgeJDDuMb3kpCgeXNCJ2on8cVb VGuvsSm/K+mUtlpn6zhKBSxfSHCBHYgent29etDa1GxW8ot9ijBmlOYteMYuMxI63Vcpfo8xiwx2x FuPaZ43g==; Received: from 201-27-35-168.dsl.telesp.net.br ([201.27.35.168] helo=[192.168.1.60]) by fanzine2.igalia.com with esmtpsa (Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_128_GCM:128) (Exim) id 1oZuvC-0081LD-2V; Sun, 18 Sep 2022 16:05:21 +0200 Message-ID: Date: Sun, 18 Sep 2022 11:04:49 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH V3 06/11] tracing: Improve panic/die notifiers Content-Language: en-US To: rostedt@goodmis.org, stern@rowland.harvard.edu Cc: kexec@lists.infradead.org, pmladek@suse.com, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-hyperv@vger.kernel.org, netdev@vger.kernel.org, x86@kernel.org, kernel-dev@igalia.com, kernel@gpiccoli.net, halves@canonical.com, fabiomirmar@gmail.com, bhe@redhat.com, alejandro.j.jimenez@oracle.com, andriy.shevchenko@linux.intel.com, arnd@arndb.de, bp@alien8.de, corbet@lwn.net, d.hatayama@jp.fujitsu.com, dave.hansen@linux.intel.com, dyoung@redhat.com, feng.tang@intel.com, gregkh@linuxfoundation.org, mikelley@microsoft.com, hidehiro.kawai.ez@hitachi.com, jgross@suse.com, john.ogness@linutronix.de, keescook@chromium.org, luto@kernel.org, mhiramat@kernel.org, mingo@redhat.com, paulmck@kernel.org, peterz@infradead.org, senozhatsky@chromium.org, tglx@linutronix.de, vgoyal@redhat.com, vkuznets@redhat.com, will@kernel.org, xuqiang36@huawei.com, Sergei Shtylyov References: <20220819221731.480795-1-gpiccoli@igalia.com> <20220819221731.480795-7-gpiccoli@igalia.com> From: "Guilherme G. Piccoli" In-Reply-To: <20220819221731.480795-7-gpiccoli@igalia.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-hyperv@vger.kernel.org On 19/08/2022 19:17, Guilherme G. Piccoli wrote: > Currently the tracing dump_on_oops feature is implemented through > separate notifiers, one for die/oops and the other for panic; > given they have the same functionality, let's unify them. > > Also improve the function comment and change the priority of the > notifier to make it execute earlier, avoiding showing useless trace > data (like the callback names for the other notifiers); finally, > we also removed an unnecessary header inclusion. > > Cc: Petr Mladek > Cc: Sergei Shtylyov > Cc: Steven Rostedt > Signed-off-by: Guilherme G. Piccoli > > --- > > V3: > - Removed goto usage, as per Steven suggestion (thanks!). > > V2: > - Different approach; instead of using IDs to distinguish die and > panic events, rely on address comparison like other notifiers do > and as per Petr's suggestion; > > - Removed ACK from Steven since the code changed. > > [...] Hi Steve, Alan - sorry for the ping (and I'm aware you're OOO Steve, saw your auto-response email heh). So, is this version good enough? Appreciate the reviews and in case it's good, let me know your preference for picking it in your tree - I could resend the patch alone if you prefer (not in the series), for example. Thanks, Guilherme