From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6A9C1C2BA19 for ; Tue, 14 Apr 2020 15:43:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4D86220678 for ; Tue, 14 Apr 2020 15:43:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2440791AbgDNPnC (ORCPT ); Tue, 14 Apr 2020 11:43:02 -0400 Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:32052 "EHLO mail3-relais-sop.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2407442AbgDNPm4 (ORCPT ); Tue, 14 Apr 2020 11:42:56 -0400 X-IronPort-AV: E=Sophos;i="5.72,382,1580770800"; d="scan'208";a="345880051" Received: from abo-173-121-68.mrs.modulonet.fr (HELO hadrien) ([85.68.121.173]) by mail3-relais-sop.national.inria.fr with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 Apr 2020 17:42:50 +0200 Date: Tue, 14 Apr 2020 17:42:50 +0200 (CEST) From: Julia Lawall X-X-Sender: jll@hadrien To: Colin King cc: "K . Y . Srinivasan" , Haiyang Zhang , Stephen Hemminger , Wei Liu , linux-hyperv@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH][next] drivers: hv: remove redundant assignment to pointer primary_channel In-Reply-To: <20200414152343.243166-1-colin.king@canonical.com> Message-ID: References: <20200414152343.243166-1-colin.king@canonical.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-hyperv-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-hyperv@vger.kernel.org On Tue, 14 Apr 2020, Colin King wrote: > From: Colin Ian King > > The pointer primary_channel is being assigned with a value that is never, never -> never used :) > The assignment is redundant and can be removed. > > Addresses-Coverity: ("Unused value") > Signed-off-by: Colin Ian King > --- > drivers/hv/channel_mgmt.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/hv/channel_mgmt.c b/drivers/hv/channel_mgmt.c > index ffd7fffa5f83..f7bbb8dc4b0f 100644 > --- a/drivers/hv/channel_mgmt.c > +++ b/drivers/hv/channel_mgmt.c > @@ -425,8 +425,6 @@ void hv_process_channel_removal(struct vmbus_channel *channel) > > if (channel->primary_channel == NULL) { > list_del(&channel->listentry); > - > - primary_channel = channel; > } else { > primary_channel = channel->primary_channel; > spin_lock_irqsave(&primary_channel->lock, flags); > -- > 2.25.1 > >