From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0288E25B082 for ; Mon, 7 Sep 2026 21:01:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788814867; cv=none; b=eGq3k67KshdNPhRhLYn5870ZeWw/3bkR7kip921lRuS3CYSHRWxrn4WYbvciFptF/DpNv6Wns+Bf82SFjbmRujuLOlZjKSj59CL6lDAUQUDSHQ5PetAORHIHLlvzMerSdyJyRA7Cyo3/0Ecn0hZ2+HPVzg1uXEqrCEZpVtg8/YA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788814867; c=relaxed/simple; bh=Pfp4fHaGp3DYNoQNsq++Hih2POFfdEHNA9k/g4/DYlk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=cY8b05PHAUANfUQADwetj5NY9ZCoZiVcLyRscPiL9KW0eVrqRw1j18TBHhPsSDGBe8KVlS2FCUx6nJJJQ2KqwC49Uw8yuEd77pUi2UCUnn6eW0fQRvcsWM3L264rkywTUFsU+uELehDHfn8BpU19TRjl5iLT8kQI5MTuxxq3qTc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=E4srLzoR; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=eFb3gEgc; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="E4srLzoR"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="eFb3gEgc" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1788814864; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=km54XNA3pesnlH9MUSOEbKUzj91GMmwN/4bvXZLN1Qw=; b=E4srLzoRT2lSFcaQysiCLk/7gYWQXXHBWble0pc3yRK0BKbcUWXlkkenZdQBdblXltv429 aq23hN2ImYmLgJhVNpUkK9ErT/FV8Sa0bc3WYo3Bf/cgSD4jChuPK5MW4huzJs8Xh8G3m2 v2U/A6AYyGRGC393cggcW25+9qGapb4= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-55-Z5a9XI4NNj-yQk4pN59m0A-1; Mon, 07 Sep 2026 17:01:02 -0400 X-MC-Unique: Z5a9XI4NNj-yQk4pN59m0A-1 X-Mimecast-MFC-AGG-ID: Z5a9XI4NNj-yQk4pN59m0A_1788814862 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-4957287363bso31423275e9.0 for ; Mon, 07 Sep 2026 14:01:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1788814862; x=1789419662; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=km54XNA3pesnlH9MUSOEbKUzj91GMmwN/4bvXZLN1Qw=; b=eFb3gEgcK3PB9MrfTHHThNcTr92004RvKuJ7uQwqQ3zoZ7OpJ1R7BPd8FvfmFxrl1h nExdIw/Pf64APOUElzXVszf8Z/bLMrjDYGro+gxFk3eIKe+kvhj2IB8lSL2BlD+ZIQW/ sdkg+IjrmSSiahvTjLw32xG2CzD+GoXUxS2jj41mqgvtOOhUOA3AezChvYwsAcck82zI R8Qp2eVUoycJOT4nbsMOPyqRJSzwZjPX62S4veWmMlcAj5GMvzgVfhx2lUPn+2YQB2jd tEc6d0iHztEydGJgr9YF0mER6V2Nt6x2AB18PD42SQieJO4kg5XA+eKCw5FGTPbEsnwu 1FIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788814862; x=1789419662; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=km54XNA3pesnlH9MUSOEbKUzj91GMmwN/4bvXZLN1Qw=; b=T/DhuS2BN7z907Alu5Dh9zKqbgNPM77PagDJioCOv5sbrI2184BKliQvizqk3fCQHA uJR4WkabYZ93N95nRPI1fIW9czvFA5qHPXkvjUf/q+1v4aOAS/JXNco0DBzc7/4oCZwb CR601xJY1OC5C1GNsAkCTptI+4TJCtX8ns+H4IHmDHCgUZbi/qGZAWEIwj2syPeXoFdG bbwO9hqwQn+KxiwwdMxbAvx5ixYQe44dfOFN6R8drFjI7drV0NwLSXAfdxCy10WfXNOb JBwGdOyK0DoFWKJ1Ug7uUpJcjrkEg7bsa+iHRStSor4iGD8xosIXNiiKieA8Z7MVjkMy Ud4Q== X-Forwarded-Encrypted: i=1; AKwUvBwJlQbPrMAh+rE/K2d1YGPPSMwI8+hVffYy8tO9USgxP1KvTS3EXn706adCwN9FDBJNphH0vXTb/ElwEYg=@vger.kernel.org X-Gm-Message-State: AFuF++kuDIgFSgpL7JbklDvVlaiXhQIFSK/mUgU+WpZ6rM+TynjjgWgj WGM8iawHxK/MfJAMGKyPcvUsEP2zDYwjRpMz4XaC/kj2DUIpZhxGF3DbhKbntK1EZJjJelJiDKj 7VkOiy2E+Fi3Bt8X8qGOBnwDyOlxMLzWqumNLyPi316PK+PewTH3cYyRNuHeemf2NaiqsHRfoZ5 cs X-Gm-Gg: AYBFou0NYOLiEn/uPkLmUV+tDZRy4b5mg8XZXLxu15oiL/V6awY39cXuweCPSar6WP7 Y4VBm0puY2QIib6NRl1d/bRRnT3YBC3AqMa25PJbBVFxIx6+Fnp5q2NeV4lBWD6R8irwicP7+zN Y5T1M7tRsbKlm1YpmEhFOm2+zjig+tQ8rGWAK88TiWIbRMVpffFqMO11j54jHiyumKLGCGmTD9j l0bGGN3gPXldRmyYTWlUmhRkvLwiAoyKWlDWCuUY1vpauJ1AHi3nlLvjzbiwuisAF5e5CQYdWlN j+4MK35lmF9enWyqdCVxFYNgCKisUcVGzdpa/7Xl7YeH6recfR8ElHtjaLYJ/99kPfy5YtXF92b EaN55ENpx+tcmKxrAkBKdFtzTZ+bLpT3gTqI3RGbLL/mIEFdO X-Received: by 2002:a05:600d:8649:10b0:49c:fa20:cc0a with SMTP id 5b1f17b1804b1-49cfa20cd58mr167275225e9.33.1788814861733; Mon, 07 Sep 2026 14:01:01 -0700 (PDT) X-Received: by 2002:a05:600d:8649:10b0:49c:fa20:cc0a with SMTP id 5b1f17b1804b1-49cfa20cd58mr167274945e9.33.1788814861409; Mon, 07 Sep 2026 14:01:01 -0700 (PDT) Received: from ?IPV6:2a01:e0a:11aa:87f0:ea69:b2b0:2dae:5ef9? ([2a01:e0a:11aa:87f0:ea69:b2b0:2dae:5ef9]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49cf7703cefsm458086515e9.5.2026.09.07.14.00.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 07 Sep 2026 14:01:00 -0700 (PDT) Message-ID: Date: Mon, 7 Sep 2026 23:00:54 +0200 Precedence: bulk X-Mailing-List: linux-hyperv@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 01/14] drm/panic: Do not use un-escaped URL as format string To: Thomas Zimmermann , javierm@redhat.com, airlied@gmail.com, simona@ffwll.ch, maarten.lankhorst@linux.intel.com, mripard@kernel.org, geert@linux-m68k.org, rdunlap@infradead.org Cc: dri-devel@lists.freedesktop.org, linux-doc@vger.kernel.org, amd-gfx@lists.freedesktop.org, rust-for-linux@vger.kernel.org, linux-hyperv@vger.kernel.org, intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, nouveau@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, virtualization@lists.linux.dev, sashiko-reviews@lists.linux.dev, stable@vger.kernel.org References: <20260902121930.597222-1-tzimmermann@suse.de> <20260902121930.597222-2-tzimmermann@suse.de> Content-Language: en-US, fr From: Jocelyn Falempe In-Reply-To: <20260902121930.597222-2-tzimmermann@suse.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 9/2/26 14:13, Thomas Zimmermann wrote: > Replace the direct use of DRM_PANIC_SCREEN_QR_CODE_URL in snprintf() > with a %s conversion specifier. Avoids a possible vulnerabilty from > a crafted URL string. > > As the attacker needs to control the kernel at the Kconfig level, the > potential for an exploit is likely low. Thanks, it looks good to me. Reviewed-by: Jocelyn Falempe > > Signed-off-by: Thomas Zimmermann > Fixes: cb5164ac43d0 ("drm/panic: Add a QR code panic screen") > Cc: Javier Martinez Canillas > Cc: Jocelyn Falempe > Cc: dri-devel@lists.freedesktop.org > Cc: # v6.12+ > --- > drivers/gpu/drm/drm_panic.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/drm_panic.c b/drivers/gpu/drm/drm_panic.c > index e576c4791861..ba21df4be338 100644 > --- a/drivers/gpu/drm/drm_panic.c > +++ b/drivers/gpu/drm/drm_panic.c > @@ -658,7 +658,8 @@ static int drm_panic_get_qr_code_url(u8 **qr_image) > char *kmsg; > int max_qr_data_size, url_len; > > - url_len = snprintf(url, sizeof(url), CONFIG_DRM_PANIC_SCREEN_QR_CODE_URL "?a=%s&v=%s&z=", > + url_len = snprintf(url, sizeof(url), "%s?a=%s&v=%s&z=", > + CONFIG_DRM_PANIC_SCREEN_QR_CODE_URL, > utsname()->machine, utsname()->release); > > max_qr_data_size = drm_panic_qr_max_data_size(panic_qr_version, url_len);