From: Roman Kisel <romank@linux.microsoft.com>
To: "Arnd Bergmann" <arnd@arndb.de>,
bhelgaas@google.com, "Borislav Petkov" <bp@alien8.de>,
"Catalin Marinas" <catalin.marinas@arm.com>,
"Conor Dooley" <conor+dt@kernel.org>,
"Dave Hansen" <dave.hansen@linux.intel.com>,
"Dexuan Cui" <decui@microsoft.com>,
"Haiyang Zhang" <haiyangz@microsoft.com>,
"H. Peter Anvin" <hpa@zytor.com>,
"Joey Gouly" <joey.gouly@arm.com>,
krzk+dt@kernel.org, "Krzysztof Wilczyński" <kw@linux.com>,
"K. Y. Srinivasan" <kys@microsoft.com>,
"Len Brown" <lenb@kernel.org>,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Manivannan Sadhasivam" <manivannan.sadhasivam@linaro.org>,
"Mark Rutland" <mark.rutland@arm.com>,
"Marc Zyngier" <maz@kernel.org>, "Ingo Molnar" <mingo@redhat.com>,
"Oliver Upton" <oliver.upton@linux.dev>,
"Rafael J . Wysocki" <rafael@kernel.org>,
"Rob Herring" <robh@kernel.org>,
ssengar@linux.microsoft.com,
"Sudeep Holla" <sudeep.holla@arm.com>,
"Suzuki K Poulose" <suzuki.poulose@arm.com>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Wei Liu" <wei.liu@kernel.org>, "Will Deacon" <will@kernel.org>,
"Zenghui Yu" <yuzenghui@huawei.com>,
devicetree@vger.kernel.org, kvmarm@lists.linux.dev,
linux-acpi@vger.kernel.org,
Linux-Arch <linux-arch@vger.kernel.org>,
linux-arm-kernel@lists.infradead.org,
linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-pci@vger.kernel.org, x86@kernel.org
Cc: apais@microsoft.com, benhill@microsoft.com,
bperkins@microsoft.com, sunilmut@microsoft.com
Subject: Re: [PATCH hyperv-next v5 08/11] Drivers: hv: vmbus: Get the IRQ number from DeviceTree
Date: Mon, 10 Mar 2025 10:36:21 -0700 [thread overview]
Message-ID: <b3d1609e-4f64-4a88-b453-cb79936cb469@linux.microsoft.com> (raw)
In-Reply-To: <29bb5b7a-b31f-4b32-92c6-e2588a0f965a@app.fastmail.com>
On 3/8/2025 1:11 PM, Arnd Bergmann wrote:
> On Fri, Mar 7, 2025, at 23:03, Roman Kisel wrote:
>>
>> +static int __maybe_unused vmbus_set_irq(struct platform_device *pdev)
>
> Instead of the __maybe_unused annotation here
>
>>
>> +#ifndef HYPERVISOR_CALLBACK_VECTOR
>> + ret = vmbus_set_irq(pdev);
>> + if (ret)
>> + return ret;
>> +#endif
>> +
>
> you can use
>
> if (!__is_defined(HYPERVISOR_CALLBACK_VECTOR))
> ret = vmbus_set_irq(pdev);
>
> and make it a little more readable.
>
Thanks you very much, will update! Very neat :)
> Arnd
--
Thank you,
Roman
next prev parent reply other threads:[~2025-03-10 17:36 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-07 22:02 [PATCH hyperv-next v5 00/11] arm64: hyperv: Support Virtual Trust Level Boot Roman Kisel
2025-03-07 22:02 ` [PATCH hyperv-next v5 01/11] arm64: kvm, smccc: Introduce and use API for detectting hypervisor presence Roman Kisel
2025-03-08 21:08 ` Arnd Bergmann
2025-03-10 21:16 ` Michael Kelley
2025-03-10 21:54 ` Roman Kisel
2025-03-07 22:02 ` [PATCH hyperv-next v5 02/11] arm64: hyperv: Use SMCCC to detect " Roman Kisel
2025-03-10 21:17 ` Michael Kelley
2025-03-07 22:02 ` [PATCH hyperv-next v5 03/11] Drivers: hv: Enable VTL mode for arm64 Roman Kisel
2025-03-08 21:05 ` Arnd Bergmann
2025-03-10 17:35 ` Roman Kisel
2025-03-10 21:01 ` Michael Kelley
2025-03-10 21:20 ` Arnd Bergmann
2025-03-10 22:18 ` Michael Kelley
2025-03-12 18:33 ` Roman Kisel
2025-03-12 20:25 ` Arnd Bergmann
2025-03-12 21:21 ` Roman Kisel
2025-03-13 5:10 ` Michael Kelley
2025-03-12 20:31 ` Wei Liu
2025-03-12 21:30 ` Roman Kisel
2025-03-07 22:02 ` [PATCH hyperv-next v5 04/11] Drivers: hv: Provide arch-neutral implementation of get_vtl() Roman Kisel
2025-03-10 13:44 ` Tianyu Lan
2025-03-07 22:02 ` [PATCH hyperv-next v5 05/11] arm64: hyperv: Initialize the Virtual Trust Level field Roman Kisel
2025-03-10 23:07 ` Michael Kelley
2025-03-07 22:02 ` [PATCH hyperv-next v5 06/11] arm64, x86: hyperv: Report the VTL the system boots in Roman Kisel
2025-03-10 0:31 ` Wei Liu
2025-03-10 16:42 ` Roman Kisel
2025-03-10 16:53 ` Wei Liu
2025-03-10 17:20 ` Roman Kisel
2025-03-07 22:02 ` [PATCH hyperv-next v5 07/11] dt-bindings: microsoft,vmbus: Add interrupts and DMA coherence Roman Kisel
2025-03-10 9:28 ` Krzysztof Kozlowski
2025-03-10 17:05 ` Roman Kisel
2025-03-10 17:40 ` Krzysztof Kozlowski
2025-03-10 18:07 ` Roman Kisel
2025-03-10 21:17 ` Krzysztof Kozlowski
2025-03-10 21:51 ` Roman Kisel
2025-03-07 22:03 ` [PATCH hyperv-next v5 08/11] Drivers: hv: vmbus: Get the IRQ number from DeviceTree Roman Kisel
2025-03-08 21:11 ` Arnd Bergmann
2025-03-10 17:36 ` Roman Kisel [this message]
2025-03-10 23:09 ` Michael Kelley
2025-03-13 18:44 ` Rob Herring
2025-03-13 18:46 ` Roman Kisel
2025-03-07 22:03 ` [PATCH hyperv-next v5 09/11] Drivers: hv: vmbus: Introduce hv_get_vmbus_root_device() Roman Kisel
2025-03-10 13:41 ` Tianyu Lan
2025-03-10 17:09 ` Roman Kisel
2025-03-10 23:12 ` Michael Kelley
2025-03-07 22:03 ` [PATCH hyperv-next v5 10/11] ACPI: irq: Introduce acpi_get_gsi_dispatcher() Roman Kisel
2025-03-10 23:26 ` Michael Kelley
2025-03-07 22:03 ` [PATCH hyperv-next v5 11/11] PCI: hv: Get vPCI MSI IRQ domain from DeviceTree Roman Kisel
2025-03-10 16:41 ` Bjorn Helgaas
2025-03-10 17:15 ` Roman Kisel
2025-03-10 23:42 ` Michael Kelley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b3d1609e-4f64-4a88-b453-cb79936cb469@linux.microsoft.com \
--to=romank@linux.microsoft.com \
--cc=apais@microsoft.com \
--cc=arnd@arndb.de \
--cc=benhill@microsoft.com \
--cc=bhelgaas@google.com \
--cc=bp@alien8.de \
--cc=bperkins@microsoft.com \
--cc=catalin.marinas@arm.com \
--cc=conor+dt@kernel.org \
--cc=dave.hansen@linux.intel.com \
--cc=decui@microsoft.com \
--cc=devicetree@vger.kernel.org \
--cc=haiyangz@microsoft.com \
--cc=hpa@zytor.com \
--cc=joey.gouly@arm.com \
--cc=krzk+dt@kernel.org \
--cc=kvmarm@lists.linux.dev \
--cc=kw@linux.com \
--cc=kys@microsoft.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=mark.rutland@arm.com \
--cc=maz@kernel.org \
--cc=mingo@redhat.com \
--cc=oliver.upton@linux.dev \
--cc=rafael@kernel.org \
--cc=robh@kernel.org \
--cc=ssengar@linux.microsoft.com \
--cc=sudeep.holla@arm.com \
--cc=sunilmut@microsoft.com \
--cc=suzuki.poulose@arm.com \
--cc=tglx@linutronix.de \
--cc=wei.liu@kernel.org \
--cc=will@kernel.org \
--cc=x86@kernel.org \
--cc=yuzenghui@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).