From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by smtp.subspace.kernel.org (Postfix) with ESMTP id C0E4B233155; Mon, 10 Mar 2025 17:36:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=13.77.154.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741628184; cv=none; b=WuISTSx9u3Yg0xLIjBbLUerGf41Yvul0Qf48OpNQQjBxR5R+a5SNqi7Lrj9rbnnW+25n/4pv6ON3SXWJA37YC4cf+NRBV6GgwqMdOEgyJZW+1PYfRsYzAT8H7B3tn+5M1S3YmVyZLHEia+Am3Ehw37D7PXn22bouTsSyfDmc1Us= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741628184; c=relaxed/simple; bh=vkV3yV+zbwQIpGXrfh8VQUyHDFkE7/JX95cxpROdv/Y=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=j0QzllmMqARFsTYRlfNXCmXK+hS6XOKyHUfIoFiQAwfpy+QWgmBnvwqzWFHFGMQFH9rMdcImZKn0tujZ7gxh+WwJZzf+QHdWHkNkzK8MVNZgTLWnmnBLL5YvN3eyvAS/p+q2sWsh+Jsp3JDZB4cfuOicxPLuWa4ViYnGP9d4l7E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.microsoft.com; spf=pass smtp.mailfrom=linux.microsoft.com; dkim=pass (1024-bit key) header.d=linux.microsoft.com header.i=@linux.microsoft.com header.b=eN2UJ3y3; arc=none smtp.client-ip=13.77.154.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.microsoft.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.microsoft.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.microsoft.com header.i=@linux.microsoft.com header.b="eN2UJ3y3" Received: from [10.137.184.60] (unknown [131.107.160.188]) by linux.microsoft.com (Postfix) with ESMTPSA id 1DFE72038F33; Mon, 10 Mar 2025 10:36:22 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 1DFE72038F33 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1741628182; bh=iZEKwdOofjp6NDR+2hlCzSLPGInK74STCfZGhKf2O+k=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=eN2UJ3y3nG1bAmMoF3LcnG5o5qMeihqJMUFoq8f8VQkTQKjrwMphlZxBpakvB6lYA cSNptejg8D34S3125VES0nI3+8se2yDSJeQJmJrUFy33o/Z7zwGERJrRVw8E/zoDSv 1g3S3ylZGCNVS7jCVQd173bGvBEvgxrxkXMhTQwI= Message-ID: Date: Mon, 10 Mar 2025 10:36:21 -0700 Precedence: bulk X-Mailing-List: linux-hyperv@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH hyperv-next v5 08/11] Drivers: hv: vmbus: Get the IRQ number from DeviceTree To: Arnd Bergmann , bhelgaas@google.com, Borislav Petkov , Catalin Marinas , Conor Dooley , Dave Hansen , Dexuan Cui , Haiyang Zhang , "H. Peter Anvin" , Joey Gouly , krzk+dt@kernel.org, =?UTF-8?Q?Krzysztof_Wilczy=C5=84ski?= , "K. Y. Srinivasan" , Len Brown , Lorenzo Pieralisi , Manivannan Sadhasivam , Mark Rutland , Marc Zyngier , Ingo Molnar , Oliver Upton , "Rafael J . Wysocki" , Rob Herring , ssengar@linux.microsoft.com, Sudeep Holla , Suzuki K Poulose , Thomas Gleixner , Wei Liu , Will Deacon , Zenghui Yu , devicetree@vger.kernel.org, kvmarm@lists.linux.dev, linux-acpi@vger.kernel.org, Linux-Arch , linux-arm-kernel@lists.infradead.org, linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, x86@kernel.org Cc: apais@microsoft.com, benhill@microsoft.com, bperkins@microsoft.com, sunilmut@microsoft.com References: <20250307220304.247725-1-romank@linux.microsoft.com> <20250307220304.247725-9-romank@linux.microsoft.com> <29bb5b7a-b31f-4b32-92c6-e2588a0f965a@app.fastmail.com> Content-Language: en-US From: Roman Kisel In-Reply-To: <29bb5b7a-b31f-4b32-92c6-e2588a0f965a@app.fastmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 3/8/2025 1:11 PM, Arnd Bergmann wrote: > On Fri, Mar 7, 2025, at 23:03, Roman Kisel wrote: >> >> +static int __maybe_unused vmbus_set_irq(struct platform_device *pdev) > > Instead of the __maybe_unused annotation here > >> >> +#ifndef HYPERVISOR_CALLBACK_VECTOR >> + ret = vmbus_set_irq(pdev); >> + if (ret) >> + return ret; >> +#endif >> + > > you can use > > if (!__is_defined(HYPERVISOR_CALLBACK_VECTOR)) > ret = vmbus_set_irq(pdev); > > and make it a little more readable. > Thanks you very much, will update! Very neat :) > Arnd -- Thank you, Roman