From: Naman Jain <namjain@linux.microsoft.com>
To: Ben Hutchings <benh@debian.org>,
"K. Y. Srinivasan" <kys@microsoft.com>,
Haiyang Zhang <haiyangz@microsoft.com>,
Wei Liu <wei.liu@kernel.org>, Dexuan Cui <decui@microsoft.com>,
Long Li <longli@microsoft.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-hyperv@vger.kernel.org
Subject: Re: [PATCH] uio_hv_generic: Bind to FCopy device by default
Date: Tue, 26 May 2026 12:15:08 +0530 [thread overview]
Message-ID: <b9943717-d804-4496-bf85-54f2a8b988ec@linux.microsoft.com> (raw)
In-Reply-To: <ahQ6xuhSReidmN-3@decadent.org.uk>
On 5/25/2026 5:34 PM, Ben Hutchings wrote:
> The Hyper-V kernel-mode fcopy driver was removed in 6.10 and the new
> fcopy daemon requires this uio driver to function. However, by
> default the driver does not bind to any devices, and must be
> configured through the sysfs "new_id" file.
>
> Since the FCopy device is now only usable through this driver, add its
> ID to the driver's ID table so that the daemon will work "out of the
> box".
>
> Signed-off-by: Ben Hutchings <benh@debian.org>
> Fixes: ec314f61e4fc ("Drivers: hv: Remove fcopy driver")
> ---
> --- a/drivers/uio/uio_hv_generic.c
> +++ b/drivers/uio/uio_hv_generic.c
> @@ -395,9 +395,15 @@ hv_uio_remove(struct hv_device *dev)
> vmbus_free_ring(dev->channel);
> }
>
> +static const struct hv_vmbus_device_id hv_uio_id_table[] = {
> + { HV_FCOPY_GUID },
> + {}
> +};
> +MODULE_DEVICE_TABLE(vmbus, hv_uio_id_table);
> +
> static struct hv_driver hv_uio_drv = {
> .name = "uio_hv_generic",
> - .id_table = NULL, /* only dynamic id's */
> + .id_table = hv_uio_id_table,
> .probe = hv_uio_probe,
> .remove = hv_uio_remove,
> };
Two things worth considering before applying:
1. Please add Cc: stable@vger.kernel.org or is it that we do not want
this to be ported to older kernels?
2. Every Hyper-V guest (with UIO_HV_GENERIC enabled) will now have an
additional auto-bound /dev/uio0 node for FCopy. Anything that hardcodes
/dev/uio0 (e.g. ad-hoc DPDK scripts that bind a NetVSC NIC via
uio_hv_generic + new_id) may see its index shift, since FCopy now wins
uio0 at boot. The fix for such consumers is the same thing DPDK and the
in-tree daemon already do: resolve uio via
/sys/bus/vmbus/devices/<guid>/uio/ rather than by number. This is not a
regression in the patch, but it's a behavior change worth calling out.
Regards,
Naman
next prev parent reply other threads:[~2026-05-26 6:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-25 12:04 [PATCH] uio_hv_generic: Bind to FCopy device by default Ben Hutchings
2026-05-26 6:45 ` Naman Jain [this message]
[not found] ` <afdcb1775e7a60b7824b5c540a44f0148abe3e1c.camel@debian.org>
2026-05-26 10:10 ` Naman Jain
2026-05-26 15:15 ` Michael Kelley
2026-05-26 15:49 ` Naman Jain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b9943717-d804-4496-bf85-54f2a8b988ec@linux.microsoft.com \
--to=namjain@linux.microsoft.com \
--cc=benh@debian.org \
--cc=decui@microsoft.com \
--cc=gregkh@linuxfoundation.org \
--cc=haiyangz@microsoft.com \
--cc=kys@microsoft.com \
--cc=linux-hyperv@vger.kernel.org \
--cc=longli@microsoft.com \
--cc=wei.liu@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox