From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A17BC48BDF for ; Tue, 15 Jun 2021 09:25:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 069FD6142E for ; Tue, 15 Jun 2021 09:25:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231152AbhFOJ1d (ORCPT ); Tue, 15 Jun 2021 05:27:33 -0400 Received: from smtp-out1.suse.de ([195.135.220.28]:38992 "EHLO smtp-out1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231238AbhFOJ1c (ORCPT ); Tue, 15 Jun 2021 05:27:32 -0400 Received: from imap.suse.de (imap-alt.suse-dmz.suse.de [192.168.254.47]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id DA9E5219D9; Tue, 15 Jun 2021 09:25:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1623749127; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Wkrt2I7n4dqe/apiwY6bErCGbPoxzB9wmIHRvqFeTUk=; b=KPw+PR0I7Ui6aI5VMEpGCUYtCc1YQUamG6vEkNWwcTx/HEJqoIvBhR7p6l2aFjr6XpcO92 ltwhlIHRvrSjlukY7sxCiDzDZTEbdo2v3qH8d/IDIG76AH9LPhlqCH6AhbeftehFpVOqRY CrLl7nqo4bP2x2A6cEDRl4Kj3Xh4qoo= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1623749127; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Wkrt2I7n4dqe/apiwY6bErCGbPoxzB9wmIHRvqFeTUk=; b=Cp/UPq4BCBgiwlrvmcPb0HPvrbfK9sLEEPW7dF8RycIh/l8c7iVSZWwaFMPX4uFnNt0Ewg 2XZZSS+zDOrZpbAQ== Received: from imap3-int (imap-alt.suse-dmz.suse.de [192.168.254.47]) by imap.suse.de (Postfix) with ESMTP id B28A2118DD; Tue, 15 Jun 2021 09:25:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1623749127; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Wkrt2I7n4dqe/apiwY6bErCGbPoxzB9wmIHRvqFeTUk=; b=KPw+PR0I7Ui6aI5VMEpGCUYtCc1YQUamG6vEkNWwcTx/HEJqoIvBhR7p6l2aFjr6XpcO92 ltwhlIHRvrSjlukY7sxCiDzDZTEbdo2v3qH8d/IDIG76AH9LPhlqCH6AhbeftehFpVOqRY CrLl7nqo4bP2x2A6cEDRl4Kj3Xh4qoo= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1623749127; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Wkrt2I7n4dqe/apiwY6bErCGbPoxzB9wmIHRvqFeTUk=; b=Cp/UPq4BCBgiwlrvmcPb0HPvrbfK9sLEEPW7dF8RycIh/l8c7iVSZWwaFMPX4uFnNt0Ewg 2XZZSS+zDOrZpbAQ== Received: from director2.suse.de ([192.168.254.72]) by imap3-int with ESMTPSA id sPysKgdyyGCzeQAALh3uQQ (envelope-from ); Tue, 15 Jun 2021 09:25:27 +0000 Subject: Re: [PATCH v2 -next] drm/hyperv: Fix unused const variable 'hyperv_modifiers' To: Pu Lehui , drawat.floss@gmail.com, airlied@linux.ie, daniel@ffwll.ch Cc: zhangjinhao2@huawei.com, linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org References: <20210609024940.34933-1-pulehui@huawei.com> <20210615031401.231751-1-pulehui@huawei.com> From: Thomas Zimmermann Message-ID: Date: Tue, 15 Jun 2021 11:25:27 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.2 MIME-Version: 1.0 In-Reply-To: <20210615031401.231751-1-pulehui@huawei.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ndFCefi0rNgLGvXQF3Uw0UuWJRtVF2RX4" Precedence: bulk List-ID: X-Mailing-List: linux-hyperv@vger.kernel.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --ndFCefi0rNgLGvXQF3Uw0UuWJRtVF2RX4 Content-Type: multipart/mixed; boundary="zEJlwBFnUtuFl5yIxH4kjjKDlu3GQO33D"; protected-headers="v1" From: Thomas Zimmermann To: Pu Lehui , drawat.floss@gmail.com, airlied@linux.ie, daniel@ffwll.ch Cc: zhangjinhao2@huawei.com, linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Message-ID: Subject: Re: [PATCH v2 -next] drm/hyperv: Fix unused const variable 'hyperv_modifiers' References: <20210609024940.34933-1-pulehui@huawei.com> <20210615031401.231751-1-pulehui@huawei.com> In-Reply-To: <20210615031401.231751-1-pulehui@huawei.com> --zEJlwBFnUtuFl5yIxH4kjjKDlu3GQO33D Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable Hi Am 15.06.21 um 05:14 schrieb Pu Lehui: > There is a gcc '-Wunused-const-variable' warning: > drivers/gpu/drm/hyperv/hyperv_drm_modeset.c:152:23: warning: > 'hyperv_modifiers' defined but not used [-Wunused-const-variable=3D= ] >=20 > while the variable should be used in drm_simple_display_pipe_init() > as suggested by Thomas, let's fix it. Thanks a lot! I added your patch to drm-misc-next-fixes. Best regards Thomas >=20 > Fixes: 76c56a5affeb ("drm/hyperv: Add DRM driver for hyperv synthetic v= ideo device") > Signed-off-by: Pu Lehui > --- > drivers/gpu/drm/hyperv/hyperv_drm_modeset.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/drivers/gpu/drm/hyperv/hyperv_drm_modeset.c b/drivers/gpu/= drm/hyperv/hyperv_drm_modeset.c > index 02718e3e859e..3aaee4730ec6 100644 > --- a/drivers/gpu/drm/hyperv/hyperv_drm_modeset.c > +++ b/drivers/gpu/drm/hyperv/hyperv_drm_modeset.c > @@ -163,7 +163,7 @@ static inline int hyperv_pipe_init(struct hyperv_dr= m_device *hv) > &hyperv_pipe_funcs, > hyperv_formats, > ARRAY_SIZE(hyperv_formats), > - NULL, > + hyperv_modifiers, > &hv->connector); > if (ret) > return ret; >=20 --=20 Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany (HRB 36809, AG N=C3=BCrnberg) Gesch=C3=A4ftsf=C3=BChrer: Felix Imend=C3=B6rffer --zEJlwBFnUtuFl5yIxH4kjjKDlu3GQO33D-- --ndFCefi0rNgLGvXQF3Uw0UuWJRtVF2RX4 Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsF5BAABCAAjFiEExndm/fpuMUdwYFFolh/E3EQov+AFAmDIcgcFAwAAAAAACgkQlh/E3EQov+BD Bw//Xqc6PQ7vXQPGpR0cdFSqVsZ/bQtd3M97nBU4bLbHf7pVoq8r6uTaxsO9L2oB8bEuoUdI0uct MaccFeHxIKNuOQEKrztR3OhwjRA18HNyEa/BrKyCn3Vl4rySgBdpyxk3Wz4dYrQDGuirAlts3+Sy zE/T0FS4OKCeUPZB3CEnmMTPazlUz4mPNTX7BNb0Lu4EN3mFMUlC0olHLzySwuvumNX7dJ1fssww 2bFQT+a1awY5actNRIJHkROEdt8Ahls41E3ArlZ8lEe74TbIEsYyOvB70IuuLeUQlTRmk/dnbb4G N/xln9Jpb+UAOM6oc3D7MbPBqtYWcfSqrhmpL29bybjwumz70awDy1LknbxYrQP1TkMrmgajRrus lOJoRri4+iDlPlVA4J4zxJ4Za/Y1n89uivOgHbnZVUJXPbG/Zega7i8nuIoVn76Ts1+y3mpqhhgg yWYZ7AhpgNvD47GgAFmYrcPcqrArpo8en5sk6FngOth8DZ/ln1ugd9vIwHpYjs0HwlS8VQzG7SRo cCeQxCdvES+5QAhzgNpCab3RbCGstW3BOkFgpeClD1Gjwki6zbfWrfFJEpXaPGnhVJX80APKGi9L Hpt+x0cD8uRJnUFdlHT7IHm+YC2FxLWg2shKbQPBDqcl/RWfa+n6towlmJvIThcsg0jJVFzjK4P2 dfI= =zEWF -----END PGP SIGNATURE----- --ndFCefi0rNgLGvXQF3Uw0UuWJRtVF2RX4--