linux-hyperv.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Markus Elfring <Markus.Elfring@web.de>
To: linux-hyperv@vger.kernel.org,
	Michael Kelley <mhklinux@outlook.com>,
	Dexuan Cui <decui@microsoft.com>,
	Haiyang Zhang <haiyangz@microsoft.com>,
	Wei Liu <wei.liu@kernel.org>,
	Dan Carpenter <dan.carpenter@linaro.org>,
	kernel-janitors@vger.kernel.org
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] Drivers: hv: vmbus: Remove duplication and cleanup code in create_gpadl_header()
Date: Fri, 12 Jan 2024 09:06:25 +0100	[thread overview]
Message-ID: <de6c23b2-aa27-494a-a0ec-fe14a4289b38@web.de> (raw)
In-Reply-To: <20240111165451.269418-1-mhklinux@outlook.com>

…
> Eliminate the duplication by making minor tweaks to the logic and
> associated comments. While here, simplify the handling of memory
> allocation errors, and use umin() instead of open coding it.
…

I got the impression that the adjustment for the mentioned macro
should be performed in a separate update step of the presented patch series.
https://elixir.bootlin.com/linux/v6.7/source/include/linux/minmax.h#L95

See also:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.7#n81

Regards,
Markus

  parent reply	other threads:[~2024-01-12  8:06 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-11 16:54 [PATCH 1/2] Drivers: hv: vmbus: Remove duplication and cleanup code in create_gpadl_header() mhkelley58
2024-01-11 16:54 ` [PATCH 2/2] Drivers: hv: vmbus: Update indentation " mhkelley58
2024-01-12  8:06 ` Markus Elfring [this message]
2024-01-12 16:19   ` [PATCH 1/2] Drivers: hv: vmbus: Remove duplication and cleanup code " Michael Kelley
2024-02-09 15:33     ` Michael Kelley
2024-03-01  9:25       ` Wei Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=de6c23b2-aa27-494a-a0ec-fe14a4289b38@web.de \
    --to=markus.elfring@web.de \
    --cc=dan.carpenter@linaro.org \
    --cc=decui@microsoft.com \
    --cc=haiyangz@microsoft.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-hyperv@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mhklinux@outlook.com \
    --cc=wei.liu@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).