From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 61AD41BD9D0 for ; Tue, 27 May 2025 07:02:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748329360; cv=none; b=oBN65d1rIhDckjS+TApBTDQ9biqWbpWhQ3iZnEfI30URoq1fyo0tAipM+dzmHydCVtrDfR2oRDX2PTZigcDIRqnrXfWYZOBNJ2wJiFWiJS33bkeyEtOJYgMo2QkrxAfzFFnwN9RwutsaLE9MXu52KRjq/q3myAcvVuGu/Ld45ww= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748329360; c=relaxed/simple; bh=uerM567QcQCVqLcNbyZwn68Uozgpe9FXmx2lyhpHDvY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=lLW8upo6Gl3E/zoYE1BKP0xXZKXGKamjDIj72ogqxoIKWKT/WBp7xYTkj44XaYFqQdPYXQM8AclTu29g1MitCZomfXQTRDE4CXjfN0hWPT9DUJy5nNffdBgSwiDHQ2H6ec+98Vqa+Jj6kQ7ZQTErxuWYUPROMlyz6yVGGVx78xU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=ikjz3TI2; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="ikjz3TI2" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1748329357; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lPj65lDKBn8X+w6dITxUNDiVhmFCDqyup7L8wrKjKWs=; b=ikjz3TI2RNF/P/IQm7jZhhyyq/ZfulKQ2wJ5drc/IDwl7zP1qZP5RdDhfUDLrv7bmy1YAO Ip/lLhyR8Vd38TcClkZZ5pVVxNzT5YTjNcgETdwbyAowODJs197GtAexiTnJnZGT/iSnQZ 8jnc/bZ30tStRVRL3hscPSEqz+C6bSc= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-638-zYHF8qFENDue-NHjEizm-w-1; Tue, 27 May 2025 03:02:34 -0400 X-MC-Unique: zYHF8qFENDue-NHjEizm-w-1 X-Mimecast-MFC-AGG-ID: zYHF8qFENDue-NHjEizm-w_1748329354 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-3a371fb826cso1179118f8f.1 for ; Tue, 27 May 2025 00:02:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748329353; x=1748934153; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=lPj65lDKBn8X+w6dITxUNDiVhmFCDqyup7L8wrKjKWs=; b=mj3qfAMTQHygIdLS2Gd8IjBN7Vgq9bf9R3Jl9hkoAK6kmk4CJjywzG6HrkJj4reUAM 3jeiHuLVnWjXvczbzlINhNScjLUgFlBPvBla1nazBBQh9ljNXbuzKFNR6f5bcreD1G8n nAIKs8GvivQnWf+98rWhm8XWCL3JLQMIX/l3/7uO1bZwJJvk9jpFRHyAdcK3t5+x8BLb JGb9mamEbbz9F/+sAj2DO0oPmOxarhwdwIsUH0U8zehvoe1OHtAXzVKHz/LI2+LCFzcY y3vUsqYOFh7imb4UAidqM7DLiehhGRsdYOMY4v9Gq8a7+v0ZjOyyqnAEcB9dc9OEYk8G Hr5A== X-Forwarded-Encrypted: i=1; AJvYcCXQ4gRCeXGdThHdbX8RstUObcTqSER7LWSCJlw9FEF3iUnOFvb1eNfW/FCgAyFqmsyxbR9SzowSAmVWtYk=@vger.kernel.org X-Gm-Message-State: AOJu0YwV3cluVbcJHz6ANLhopw+aWmSAiCyB8iAt+BZlWNKXUID3H/TK OPZyRkGylKpDx8BRq775wNlBg2EiDUBK2gr4JtB9iZEQyFOum9vzpGY7MHf9KdLqnmZyGpMJ9wv M4TYq6eqygaA4IJiZe7vmD222wrAHPrZxYWHJLlYc2D4zGcT8cGd3KBqQn8tcWMQ30w== X-Gm-Gg: ASbGnctOPTic4okERnu7UIHzAYJ11Jr8nUZzjwunOLXdM2DQPiesG2K7Ze0PHXuLVzq Sz4/KX2gdFWtllTQwMzIo6Y7HBhPblTqIXBpU7en11z6Y9ivvBT/3Ojml9Q3N5mpzcVTKJ4ll4g X5V7BbaRdjc3SV0hBTEb/47evMIkxhg7pC9gvnER9gNbUH6wa+cF+6N1dq2Dzr/HTTOYBKN9Pmg H4DCBQYe0PTfaU+JeVXG7MPMUVcNvuCm7TAE5qxiJS4VCx/xHD8LJ/e/DB1muc0JzSzdYbLJfC4 nBy00LBQ0AflToCXAR8pnOeMj2fhrmX/ThAYGOe66hCAXP4FJNpRxAvGRTo= X-Received: by 2002:a5d:5543:0:b0:3a4:cf66:efbb with SMTP id ffacd0b85a97d-3a4cf66f1f6mr7608633f8f.57.1748329353541; Tue, 27 May 2025 00:02:33 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGex5mHhM/OYaq2gRKUAD/HxHUJY3MptMrHBU8jm/eQhY8uxpjEvS25/QUCzUXZRuezIVGAwQ== X-Received: by 2002:a5d:5543:0:b0:3a4:cf66:efbb with SMTP id ffacd0b85a97d-3a4cf66f1f6mr7608571f8f.57.1748329353087; Tue, 27 May 2025 00:02:33 -0700 (PDT) Received: from ?IPV6:2a0d:3344:2728:e810:827d:a191:aa5f:ba2f? ([2a0d:3344:2728:e810:827d:a191:aa5f:ba2f]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a4cc52ab88sm9930473f8f.11.2025.05.27.00.02.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 27 May 2025 00:02:32 -0700 (PDT) Message-ID: Date: Tue, 27 May 2025 09:02:28 +0200 Precedence: bulk X-Mailing-List: linux-hyperv@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v2 8/8] net: core: Convert dev_set_mac_address_user() to use struct sockaddr_storage To: Kees Cook , Kuniyuki Iwashima Cc: Willem de Bruijn , Jason Wang , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Simon Horman , Stanislav Fomichev , Cosmin Ratiu , Vladimir Oltean , Florian Fainelli , Kory Maincent , Maxim Georgiev , netdev@vger.kernel.org, "Martin K. Petersen" , Christoph Hellwig , Sagi Grimberg , Chaitanya Kulkarni , Mike Christie , Max Gurtovoy , Maurizio Lombardi , Dmitry Bogdanov , Mingzhe Zou , Christophe Leroy , "Dr. David Alan Gilbert" , "Gustavo A. R. Silva" , Lei Yang , Ido Schimmel , Samuel Mendoza-Jonas , Paul Fertser , Alexander Aring , Stefan Schmidt , Miquel Raynal , Hayes Wang , Douglas Anderson , Grant Grundler , Jay Vosburgh , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Jiri Pirko , Aleksander Jan Bajkowski , Philipp Hahn , Eric Biggers , Ard Biesheuvel , Al Viro , Ahmed Zaki , Alexander Lobakin , Xiao Liang , linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org, linux-scsi@vger.kernel.org, target-devel@vger.kernel.org, linux-wpan@vger.kernel.org, linux-usb@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-hardening@vger.kernel.org References: <20250521204310.it.500-kees@kernel.org> <20250521204619.2301870-8-kees@kernel.org> Content-Language: en-US From: Paolo Abeni In-Reply-To: <20250521204619.2301870-8-kees@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 5/21/25 10:46 PM, Kees Cook wrote: > diff --git a/net/core/dev_ioctl.c b/net/core/dev_ioctl.c > index fff13a8b48f1..616479e71466 100644 > --- a/net/core/dev_ioctl.c > +++ b/net/core/dev_ioctl.c > @@ -572,9 +572,11 @@ static int dev_ifsioc(struct net *net, struct ifreq *ifr, void __user *data, > return dev_set_mtu(dev, ifr->ifr_mtu); > > case SIOCSIFHWADDR: > - if (dev->addr_len > sizeof(struct sockaddr)) > + if (dev->addr_len > sizeof(ifr->ifr_hwaddr)) > return -EINVAL; > - return dev_set_mac_address_user(dev, &ifr->ifr_hwaddr, NULL); > + return dev_set_mac_address_user(dev, > + (struct sockaddr_storage *)&ifr->ifr_hwaddr, > + NULL); Side note for a possible follow-up: the above pattern is repeated a couple of times: IMHO consolidating it into an helper would be nice. Also such helper could/should explicitly convert ifr->ifr_hwaddr to sockaddr_storage and avoid the cast. /P