public inbox for linux-hyperv@vger.kernel.org
 help / color / mirror / Atom feed
From: Easwar Hariharan <eahariha@linux.microsoft.com>
To: yasuenag@gmail.com
Cc: kys@microsoft.com, haiyangz@microsoft.com, wei.liu@kernel.org,
	decui@microsoft.com, eahariha@linux.microsoft.com,
	linux-hyperv@vger.kernel.org, ssengar@linux.microsoft.com
Subject: Re: [PATCH v2 0/1] Path string from the host should not be treated
Date: Tue, 3 Jun 2025 14:26:02 -0700	[thread overview]
Message-ID: <e174e3b0-6b62-4996-9854-39c84e10a317@linux.microsoft.com> (raw)
In-Reply-To: <20250602235612.1542-1-yasuenag@gmail.com>

On 6/2/2025 4:56 PM, yasuenag@gmail.com wrote:
> From: Yasumasa Suenaga <yasuenag@gmail.com>
> 
> Hi,
> 
> Easwar, thanks a lot for your comment! I fixed where you pointed.
> Let me know if something wrong in this patch - this is my first
> contribution to Linux kernel...
> 
> Yasumasa Suenaga (1):
>   Path string from the host should not be treated as wchar_t
> 
>  tools/hv/hv_fcopy_uio_daemon.c | 36 +++++++++++++---------------------
>  1 file changed, 14 insertions(+), 22 deletions(-)
> 

Please run scripts/checkpatch.pl --strict on the patch and fix the reported
issues.

As I mentioned previously, https://www.kernel.org/doc/html/latest/process/submitting-patches.html
is a good reference for the expected format of the patch. Specifically:

"Describe your changes in imperative mood, e.g. "make xyzzy do frotz" instead 
of "[This patch] makes xyzzy do frotz" or "[I] changed xyzzy to do frotz", 
as if you are giving orders to the codebase to change its behaviour."

The same also applies to the subject line.

Thanks,
Easwar (he/him)

P.S: It's good etiquette to explicitly CC folks who have provided comments
on the subsequent versions



  parent reply	other threads:[~2025-06-03 21:26 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-01 13:45 [PATCH] Path string from the host should not be treated as wchar_t yasuenag
2025-06-02 16:39 ` Easwar Hariharan
2025-06-02 23:55   ` [PATCH v2 0/1] Path string from the host should not be treated yasuenag
2025-06-02 23:56   ` yasuenag
2025-06-02 23:56     ` [PATCH v2 1/1] Path string from the host should not be treated as wchar_t yasuenag
2025-06-03 21:26     ` Easwar Hariharan [this message]
2025-06-03 23:42       ` [PATCH v3 0/1] hv_fcopy_uio_daemon: Fix file copy failure between Windows host and Linux guest yasuenag
2025-06-03 23:43         ` [PATCH v3 1/1] " yasuenag
2025-06-04  6:19           ` Naman Jain
2025-06-04  9:10             ` Yasumasa Suenaga
2025-06-04 12:36               ` Naman Jain
2025-06-04 13:12                 ` Yasumasa Suenaga

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e174e3b0-6b62-4996-9854-39c84e10a317@linux.microsoft.com \
    --to=eahariha@linux.microsoft.com \
    --cc=decui@microsoft.com \
    --cc=haiyangz@microsoft.com \
    --cc=kys@microsoft.com \
    --cc=linux-hyperv@vger.kernel.org \
    --cc=ssengar@linux.microsoft.com \
    --cc=wei.liu@kernel.org \
    --cc=yasuenag@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox