From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D2E2F14AA0 for ; Tue, 14 Nov 2023 11:32:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="KFRNe8YN" Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.8]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CA5841AC; Tue, 14 Nov 2023 03:32:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1699961535; x=1731497535; h=date:from:to:cc:subject:in-reply-to:message-id: references:mime-version; bh=JTzcwCtdnMiga/o5pFKTO6FZ9pdO84nmnA+h3IRlPOg=; b=KFRNe8YNLdwG2ZO54UwlCsQHW8VCrWQl6X/U6zGCmsqih4v6lcyV8CZR KuPMyVQ7+o0a0VOF1MD0jqkVvFc3bs6XvcScY+YlY7yruaII5qnPwXNot 815pj4ymPXgmve+4RF4iyKXPsiwnmXfCItP4LpDc6ZwQ8OsGHLYt+qsOn 3jc0H+zE8Fjkaz6u9QkNL5PeqCNTJT5uLP7wMhOpMgeEE0AVWfrhWAsoa XSJJwdRw7+fn+QmItA82ON4tSdLOyPkg0DCKXziXX5afQFRCQ0tv6R6ma xUq6km09PbrCsBPw/LppOPlimN9P+BQcNr/fpVXk2h9rKjpgumCbQBVqd Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10893"; a="3696837" X-IronPort-AV: E=Sophos;i="6.03,301,1694761200"; d="scan'208";a="3696837" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmvoesa102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Nov 2023 03:32:12 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10893"; a="938052041" X-IronPort-AV: E=Sophos;i="6.03,301,1694761200"; d="scan'208";a="938052041" Received: from rauhjoha-mobl2.ger.corp.intel.com ([10.251.217.194]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Nov 2023 03:32:05 -0800 Date: Tue, 14 Nov 2023 13:32:03 +0200 (EET) From: =?ISO-8859-15?Q?Ilpo_J=E4rvinen?= To: Steve Wahl cc: Andrew Cooper , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Justin Ernst , Kyle Meyer , Dimitri Sivanich , Russ Anderson , Darren Hart , Andy Shevchenko , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Lorenzo Pieralisi , =?ISO-8859-2?Q?Krzysztof_Wilczy=F1ski?= , Rob Herring , Bjorn Helgaas , LKML , platform-driver-x86@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-pci@vger.kernel.org Subject: Re: [PATCH 3/3] x86/apic: Drop struct local_apic In-Reply-To: Message-ID: References: <20231102-x86-apic-v1-0-bf049a2a0ed6@citrix.com> <20231102-x86-apic-v1-3-bf049a2a0ed6@citrix.com> Precedence: bulk X-Mailing-List: linux-hyperv@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Fri, 3 Nov 2023, Steve Wahl wrote: > On Thu, Nov 02, 2023 at 12:26:21PM +0000, Andrew Cooper wrote: > > This type predates recorded history in tglx/history.git, making it older > > than Feb 5th 2002. > > > > This structure is literally old enough to drink in most juristictions in > > the world, and has not been used once in that time. > > > > Lay it to rest in /dev/null. > > > > Signed-off-by: Andrew Cooper > > --- > > There is perhaps something to be said for the longevity of the comment. > > "Not terribly well tested" certainly hasn't bitrotted in all this time. > > :-) !!! > > Reveiewed-by: Steve Wahl There's a typo in your tag (and it was copy-pasted to all patches of this series). -- i.