From: Naman Jain <namjain@linux.microsoft.com>
To: Peter Zijlstra <peterz@infradead.org>,
Michael Kelley <mhklinux@outlook.com>,
Paolo Bonzini <pbonzini@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Sean Christopherson <seanjc@google.com>,
"K . Y . Srinivasan" <kys@microsoft.com>,
Haiyang Zhang <haiyangz@microsoft.com>,
Wei Liu <wei.liu@kernel.org>, Dexuan Cui <decui@microsoft.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
"H . Peter Anvin" <hpa@zytor.com>,
"linux-hyperv@vger.kernel.org" <linux-hyperv@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"x86@kernel.org" <x86@kernel.org>,
Mukesh Rathor <mrathor@linux.microsoft.com>,
Stanislav Kinsburskii <skinsburskii@linux.microsoft.com>,
Nuno Das Neves <nunodasneves@linux.microsoft.com>,
Christoph Hellwig <hch@infradead.org>,
Saurabh Sengar <ssengar@linux.microsoft.com>,
ALOK TIWARI <alok.a.tiwari@oracle.com>
Subject: Re: [PATCH v11 2/2] Drivers: hv: Introduce mshv_vtl driver
Date: Wed, 12 Nov 2025 16:19:26 +0530 [thread overview]
Message-ID: <e7740f58-34cd-4bee-9786-8f3f6654ff3f@linux.microsoft.com> (raw)
In-Reply-To: <20251112101038.GE4067720@noisy.programming.kicks-ass.net>
On 11/12/2025 3:40 PM, Peter Zijlstra wrote:
> On Wed, Nov 12, 2025 at 09:44:20AM +0000, Michael Kelley wrote:
>
>> Thanks. If that symbol is referenced only by these few lines, I'd
>> go with something even shorter and simpler. Perhaps:
>>
>> .section .discard.addressable,"aw"
>> .align 8
>> .type vtl_return_sym, @object
>> .size vtl_return_sym, 8
>> vtl_return_sym:
>> .quad __SCK____mshv_vtl_return_hypercall
>>
>> Regardless of the choice of symbol name, add a comment about
>> mimicking __ADDRESSABLE(). That feels less messy to me, but
>> it's Naman's call.
>
> Right, that'll work.
Thanks Michael, Peter and Paolo for your inputs.
I'll use a simpler name and add a comment to explain it.
Regards,
Naman
prev parent reply other threads:[~2025-11-12 10:49 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-10 5:08 [PATCH v11 0/2] Drivers: hv: Introduce new driver - mshv_vtl Naman Jain
2025-11-10 5:08 ` [PATCH v11 1/2] Drivers: hv: Export some symbols for mshv_vtl Naman Jain
2025-11-10 5:08 ` [PATCH v11 2/2] Drivers: hv: Introduce mshv_vtl driver Naman Jain
2025-11-10 14:38 ` Peter Zijlstra
2025-11-11 6:55 ` Naman Jain
2025-11-11 8:13 ` Peter Zijlstra
2025-11-11 10:58 ` Naman Jain
2025-11-11 10:59 ` Peter Zijlstra
2025-11-12 4:12 ` Michael Kelley
2025-11-12 8:54 ` Paolo Bonzini
2025-11-12 9:37 ` Peter Zijlstra
2025-11-12 9:44 ` Michael Kelley
2025-11-12 10:10 ` Peter Zijlstra
2025-11-12 10:49 ` Naman Jain [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e7740f58-34cd-4bee-9786-8f3f6654ff3f@linux.microsoft.com \
--to=namjain@linux.microsoft.com \
--cc=alok.a.tiwari@oracle.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=decui@microsoft.com \
--cc=haiyangz@microsoft.com \
--cc=hch@infradead.org \
--cc=hpa@zytor.com \
--cc=kys@microsoft.com \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mhklinux@outlook.com \
--cc=mingo@redhat.com \
--cc=mrathor@linux.microsoft.com \
--cc=nunodasneves@linux.microsoft.com \
--cc=pbonzini@redhat.com \
--cc=peterz@infradead.org \
--cc=seanjc@google.com \
--cc=skinsburskii@linux.microsoft.com \
--cc=ssengar@linux.microsoft.com \
--cc=tglx@linutronix.de \
--cc=wei.liu@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).