From: "Woodhouse, David" <dwmw@amazon.co.uk>
To: "tglx@linutronix.de" <tglx@linutronix.de>,
"decui@microsoft.com" <decui@microsoft.com>,
"x86@kernel.org" <x86@kernel.org>,
"mikelley@microsoft.com" <mikelley@microsoft.com>,
"linux-hyperv@vger.kernel.org" <linux-hyperv@vger.kernel.org>
Cc: "sthemmin@microsoft.com" <sthemmin@microsoft.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Tianyu.Lan@microsoft.com" <Tianyu.Lan@microsoft.com>,
"vkuznets@redhat.com" <vkuznets@redhat.com>,
"kys@microsoft.com" <kys@microsoft.com>,
"haiyangz@microsoft.com" <haiyangz@microsoft.com>,
"wei.liu@kernel.org" <wei.liu@kernel.org>
Subject: Re: [PATCH] iommu/hyper-v: Fix panic on a host without the 15-bit APIC ID support
Date: Wed, 2 Dec 2020 01:28:20 +0000 [thread overview]
Message-ID: <eba320d980578ff37685967f8cafa5cf3ecb48e2.camel@amazon.co.uk> (raw)
In-Reply-To: <20201202004510.1818-1-decui@microsoft.com>
On Tue, 2020-12-01 at 16:45 -0800, Dexuan Cui wrote:
> The commit f36a74b9345a itself is good, but it causes a panic in a
> Linux VM that runs on a Hyper-V host that doesn't have the 15-bit
> Extended APIC ID support:
> kernel BUG at arch/x86/kernel/apic/io_apic.c:2408!
>
> This happens because the Hyper-V ioapic_ir_domain (which is defined in
> drivers/iommu/hyperv-iommu.c) can not be found. Fix the panic by
> properly claiming the only I/O APIC emulated by Hyper-V.
>
> Cc: David Woodhouse <dwmw@amazon.co.uk>
> Cc: Vitaly Kuznetsov <vkuznets@redhat.com>
> Fixes: f36a74b9345a ("x86/ioapic: Use I/O-APIC ID for finding irqdomain, not index")
> Signed-off-by: Dexuan Cui <decui@microsoft.com>
Oops, apologies for missing that.
Reviewed-by: David Woodhouse <dwmw@amazon.co.uk>
Amazon Development Centre (London) Ltd. Registered in England and Wales with registration number 04543232 with its registered office at 1 Principal Place, Worship Street, London EC2A 2FA, United Kingdom.
next prev parent reply other threads:[~2020-12-02 1:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-02 0:45 [PATCH] iommu/hyper-v: Fix panic on a host without the 15-bit APIC ID support Dexuan Cui
2020-12-02 1:28 ` Woodhouse, David [this message]
2020-12-02 9:56 ` Thomas Gleixner
2020-12-02 19:53 ` Dexuan Cui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eba320d980578ff37685967f8cafa5cf3ecb48e2.camel@amazon.co.uk \
--to=dwmw@amazon.co.uk \
--cc=Tianyu.Lan@microsoft.com \
--cc=decui@microsoft.com \
--cc=haiyangz@microsoft.com \
--cc=kys@microsoft.com \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mikelley@microsoft.com \
--cc=sthemmin@microsoft.com \
--cc=tglx@linutronix.de \
--cc=vkuznets@redhat.com \
--cc=wei.liu@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox