Linux-HyperV List
 help / color / mirror / Atom feed
From: Naman Jain <namjain@linux.microsoft.com>
To: Hemanth Selam <hemanth.selam@gmail.com>,
	"K . Y . Srinivasan" <kys@microsoft.com>,
	Haiyang Zhang <haiyangz@microsoft.com>,
	Wei Liu <wei.liu@kernel.org>, Dexuan Cui <decui@microsoft.com>,
	Long Li <longli@microsoft.com>
Cc: linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org,
	Michael Kelley <mhklinux@outlook.com>
Subject: Re: [PATCH v2 1/2] Drivers: hv: vmbus: fix typo "substract" in comment
Date: Mon, 7 Sep 2026 14:51:47 +0530	[thread overview]
Message-ID: <f307de11-8915-47f9-a743-250296f10804@linux.microsoft.com> (raw)
In-Reply-To: <20260907044946.10813-2-hemanth.selam@gmail.com>



On 9/7/2026 10:19 AM, Hemanth Selam wrote:
> Correct "substract" to "subtract", reported by scripts/checkpatch.pl using
> the misspelling list in scripts/spelling.txt.  Only touches a comment, no
> code changes.
> 
> The subject prefix changed since v1, from "hv:" to "Drivers: hv: vmbus:",
> for consistency with the rest of the subsystem's history as Michael Kelley
> pointed out.

Hi,
The change-log (these 3 lines) go after "---" line as a comment so that 
these do not get propagated to the git log in kernel tree.

> 
> Assisted-by: Cursor:claude-opus-5
> Reviewed-by: Michael Kelley <mhklinux@outlook.com>
> Signed-off-by: Hemanth Selam <hemanth.selam@gmail.com>
> ---

Here.

Refer: https://docs.kernel.org/process/submitting-patches.html#commentary

Example: 
https://lore.kernel.org/all/20260907054742.235389-1-namjain@linux.microsoft.com/

Regards,
Naman

>   drivers/hv/channel.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/hv/channel.c b/drivers/hv/channel.c
> index f4370617deac..c36ec14529b9 100644
> --- a/drivers/hv/channel.c
> +++ b/drivers/hv/channel.c
> @@ -79,7 +79,7 @@ static inline u32 hv_ring_gpadl_send_hvpgoffset(u32 offset)
>   	 * therefore leaving a (PAGE_SIZE - HV_HYP_PAGE_SIZE) gap.
>   	 *
>   	 * And to calculate the effective send offset in gpadl, we need to
> -	 * substract this gap.
> +	 * subtract this gap.
>   	 */
>   	return (offset - (PAGE_SIZE - HV_HYP_PAGE_SIZE)) >> HV_HYP_PAGE_SHIFT;
>   }


  reply	other threads:[~2026-09-07  9:21 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-07  4:49 [PATCH v2 0/2] Drivers: hv: fix typos in comments Hemanth Selam
2026-09-07  4:49 ` [PATCH v2 1/2] Drivers: hv: vmbus: fix typo "substract" in comment Hemanth Selam
2026-09-07  9:21   ` Naman Jain [this message]
2026-09-07 11:42     ` Hemanth Selam
2026-09-13 23:03   ` Wei Liu
2026-09-07  4:49 ` [PATCH v2 2/2] tools/hv: fix typo "retrive" " Hemanth Selam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f307de11-8915-47f9-a743-250296f10804@linux.microsoft.com \
    --to=namjain@linux.microsoft.com \
    --cc=decui@microsoft.com \
    --cc=haiyangz@microsoft.com \
    --cc=hemanth.selam@gmail.com \
    --cc=kys@microsoft.com \
    --cc=linux-hyperv@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=longli@microsoft.com \
    --cc=mhklinux@outlook.com \
    --cc=wei.liu@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox