From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 322FD1A9FAE; Fri, 10 Oct 2025 22:49:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=13.77.154.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760136560; cv=none; b=nwA7js6DiIrUNYKcMkhq03tHZQnx5RgKKwzci3PL0QNZh+uqiXDHMW2MiyqV/+mmQjfyf7btVsF9CHMITTKuXp1xC/9BlYy6/4JpDLgHOOoq/JREPy3gCk+/APxiKDHtwUuwcx+UMrtfvBkYX/AuBa9+gj1lRDnPxnDH5i5697s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760136560; c=relaxed/simple; bh=KozNHQmcVtSIEx78QGhSVjYy5z6nU4lTLrUBt1tKWAE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=l+lwy16WBnieLmzEOy92ZizcWCKJ2wdH4vwBtierBx8FuJyTBWuJD9ETcMN0E+bPiLwooEIOp4tawr7wppjowNRvxOdqt+9osEzdjZe61QQjOZHxJQyywUr5ngTy7lkNAIr4GBs09RyYdS4wYIw2/7hU6KXNT2rcFpXTuUXSRJo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.microsoft.com; spf=pass smtp.mailfrom=linux.microsoft.com; dkim=pass (1024-bit key) header.d=linux.microsoft.com header.i=@linux.microsoft.com header.b=SU6NncJY; arc=none smtp.client-ip=13.77.154.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.microsoft.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.microsoft.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.microsoft.com header.i=@linux.microsoft.com header.b="SU6NncJY" Received: from [100.65.97.55] (unknown [20.236.10.163]) by linux.microsoft.com (Postfix) with ESMTPSA id 5DE0C2016017; Fri, 10 Oct 2025 15:49:18 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 5DE0C2016017 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1760136558; bh=Lr94m1t+PlhRmS7fSVeu+YEHZpe7zKNJpQBqn2CbDP0=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=SU6NncJYDl+WHm71P0Bj0UawabwaRRQgT7jSvDi/0rgE+EHWr/4lSa9Zq2HtDVdOR zyXmLcIRNZLwDLDyWHJaCDYgu+LDMxGCQUqjdeHfqQ95zVPxRuQoRXPls9BeikEGs6 g8M0Oc+CCa+px8OEhaokA6d9OEQFoEYF3qO3lwrc= Message-ID: Date: Fri, 10 Oct 2025 15:49:17 -0700 Precedence: bulk X-Mailing-List: linux-hyperv@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH] Drivers: hv: Resolve ambiguity in hypervisor version log To: Stanislav Kinsburskii , kys@microsoft.com, haiyangz@microsoft.com, wei.liu@kernel.org, decui@microsoft.com Cc: linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org References: <175996340003.108050.17652201410306711595.stgit@skinsburskii-cloud-desktop.internal.cloudapp.net> Content-Language: en-US From: Nuno Das Neves In-Reply-To: <175996340003.108050.17652201410306711595.stgit@skinsburskii-cloud-desktop.internal.cloudapp.net> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 10/8/2025 3:43 PM, Stanislav Kinsburskii wrote: > Update the log message in hv_common_init to explicitly state that the > reported version is for the Microsoft Hypervisor, not the host OS. > > Previously, this message was accurate for guests running on Windows > hosts, where the host and hypervisor versions matched. With support for > Linux hosts running the Hyper-V hypervisor, the host OS and hypervisor > versions may differ. > > This change avoids confusion by making it clear that the version refers to > the Microsoft Hypervisor regardless of the host operating system. > > Signed-off-by: Stanislav Kinsburskii > --- > drivers/hv/hv_common.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/hv/hv_common.c b/drivers/hv/hv_common.c > index e109a620c83fc..0289ee4ed5ebf 100644 > --- a/drivers/hv/hv_common.c > +++ b/drivers/hv/hv_common.c > @@ -315,9 +315,9 @@ int __init hv_common_init(void) > int i; > union hv_hypervisor_version_info version; > > - /* Get information about the Hyper-V host version */ > + /* Get information about the Microsoft Hypervisor version */ > if (!hv_get_hypervisor_version(&version)) > - pr_info("Hyper-V: Host Build %d.%d.%d.%d-%d-%d\n", > + pr_info("Hyper-V: Hypervisor Build %d.%d.%d.%d-%d-%d\n", > version.major_version, version.minor_version, > version.build_number, version.service_number, > version.service_pack, version.service_branch); > > Looks like a good idea. Reviewed-by: Nuno Das Neves