Re: [PATCH net-next v6 2/4] net: mana: give each HWC message slot its own completion state

[sashiko-bot@kernel.org]

> From: Long Li <longli@microsoft.com>
> 
> Concurrent requests require the response handler and the waiting sender to
> agree on the lifetime and result state of each message slot.
> 
> Protect the caller's output buffer, Linux error and device status with a
> per-slot lock. Publish the output buffer only while the sender is waiting
> and withdraw it before every return. A late response therefore cannot copy
> through a pointer to caller storage whose lifetime has ended.
> 
> Reinitialize completion and result state when the slot is acquired. If
> the response records its result while the timed wait expires, return that
> result instead of reporting a false timeout.
> 
> HWC responses contain only the slot ID. After a genuine timeout, prevent
> the serialized bootstrap channel from reusing that ID until teardown. This
> keeps a stale response from completing a later request before the next
> patch replaces the depth-one latch with per-slot sender and response
> ownership.
> 
> Split response-status handling and request cleanup into helpers so the send
> path has structured returns rather than phase-jumping gotos.
> 
> Link: https://lore.kernel.org/r/20260908035201.402424-3-longli@microsoft.com
> Link: https://lore.kernel.org/r/20260908035201.402424-4-longli@microsoft.com
> Signed-off-by: Long Li <longli@microsoft.com>
> Signed-off-by: Wei Hu <weh@microsoft.com>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/cover.1790665894.git.weh@linux.microsoft.com?part=2