From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794204041; b=Fe/womsOYgs2GoX6qIQI1vaBeBjgn/p2mtGOP1326PeDGaXCwr0cFc4bQsKwaTzzNw5z /IrjIwl8OsKiRZwcpS4lSmDg3FdA3wSLr/b2XeNL8/m56RkXy0SWWj6feYtDa2fy8A3a5 2rv0Z/eQvPcjWd14nXGxWWo3CE45w8exLNU+y7zePKZ3I8BALV2AXfSAeWFQMs8sgHANQ 2/rhTkAQXONiMUh2aD1//lBVJM1CAdilpL8+j/0shj28re8K8fWFKcB/GtoqXOC8yILuz nYBfS1owv9ugG/dw/ZvHy2gxdXFGcLcc82lQHj9djjuBei2aBVgOQbdNffxDkdf2MsQ== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794204041; h=Received:DKIM-Signature:Message-ID:From:Subject:Reply-To:To:Cc: In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date; bh=u7aSiRAyqUJJCYptUrQffwehB1VQ0X01AiRX22xwuyM=; b=jpp1tGlpR6/d4lcDKP22/UaaEy+kT7w9I+kTFdT8i6NJWzHem0iy6B9tMuYMn6W4zNv/ D1KIP8eitMikqYufNBPVc4NbHIvy2mEhegA7h1jNK5QsAjxUFgTPfAQOdJ2U3oue1p/vO ULiZjtN4OOkWQMIpeTf7v5JWb4gSFZO7f3yEwO2qzh/NHCKF/PRfdnxwiMnBehH6veETS Y7MJtW9dl6uM6OXj93bgKCT2lW8y0W+9sjTqHWIOKb189UcchZHodsvlWAtOUUx5sS/mE 4HekgpBR4JxoUXYADnL4/+fC6DU/kHaqpth0TyfPaGivVW9McO0zuMtdKdg3H5pN1rg== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=mhCpmFyH; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9A115606A321; Mon, 9 Nov 2026 06:00:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=mhCpmFyH Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4ABB31F008A1; Mon, 9 Nov 2026 06:00:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1794204041; bh=u7aSiRAyqUJJCYptUrQffwehB1VQ0X01AiRX22xwuyM=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=mhCpmFyH7SOmyvOcs7GgLvFo4llqJQLn3JD9Ni+eLlL44nVNxcNUeVegJZSzxSMdc 4fJ85yE8c0ifBT0lCGnrINGc9IH004uFZD8R+b6P41elU0YmVXjixx42sa+uupOW5M t+DPMvcBgCziGhkh+DZuIoOOYMOLMaRbgFrBWnYpL64er4kcD3H71VgIaMyFEIbsWW 7vjbN496UkeAwpsdLUdqap0gmN2SIES3Plx7MWAv3GZQm9V4/nH/Gg4fWSNVombPOQ WGcmvMqaVR+eRUutu7SCemogVHTSWAObX2YQSSs55qVnnpCNvnODqGljh3ZINFQgOv Pm6DPq60Ltkhw== Message-ID: From: sashiko-bot@kernel.org Subject: Re: [PATCH net-next v2 1/5] net: skbuff: skip managed zerocopy frags in skb_frag_ref() Reply-To: sashiko-reviews@lists.linux.dev To: "Mina Almasry" Cc: "Jesper Dangaard Brouer" , "Ilias Apalodimas" , "David S. Miller" , "Eric Dumazet" , "Jakub Kicinski" , "Paolo Abeni" , "Simon Horman" , "Neal Cardwell" , "Kuniyuki Iwashima" , "Pavel Begunkov" , "Bobby Eshleman" , "Stanislav Fomichev" , "Steffen Klassert" , "Herbert Xu" , "Willem de Bruijn" , "John Fastabend" , "Sabrina Dubroca" , "Andrew Lunn" , "Michael S. Tsirkin" , "Jason Wang" , =?utf-8?b?RXVnZW5pbyBQw6lyZXo=?= , "Xuan Zhuo" , "Andrew Morton" , "David Hildenbrand" , "Lorenzo Stoakes" , "Liam R. Howlett" , "Vlastimil Babka" , "Mike Rapoport" , "Suren Baghdasaryan" , "Michal Hocko" , "Alexei Starovoitov" , "Daniel Borkmann" , "Johannes Berg" , "Byungchul Park" , "Zi Yan" , virtualization@lists.linux.dev, linux-mm@kvack.org, bpf@vger.kernel.org, "Jonathan Corbet" , "Shuah Khan" , "Randy Dunlap" , "Lorenzo Bianconi" , "Wen Gu" , "Philo Lu" , "Justin Chen" , "Florian Fainelli" , "Vikas Gupta" , "Michael Chan" , "Pavan Chebbi" , "Doug Berger" , "Nicolai Buchwitz" , "Broadcom internal kernel review list" , "Satish Kharat" , "Wei Fang" , "Frank Li" , "Shenwei Wang" , "Joshua Washington" , "Harshitha Ramamurthy" , "Jijie Shao" , "Jian Shen" , "Fan Gong" , "Tony Nguyen" , "Przemek Kitszel" , "Marcin Wojtas" , "Russell King" , "Sunil Goutham" , "Geetha sowjanya" , "Ratheesh Kannoth" , "Subbaraya Sundeep" , "Bharat Bhushan" , "Felix Fietkau" , "Matthias Brugger" , "AngeloGioacchino Del Regno" , "Tariq Toukan" , "Saeed Mahameed" , "Mark Bloch" , "Leon Romanovsky" , "Ido Schimmel" , "Petr Machata" , "Horatiu Vultur" , UNGLinuxDriver@microchip.com, "Daniel Machon" , "Steen Hegelund" , "Haiyang Zhang" , "Wei Liu" , "Dexuan Cui" , "Yibo Dong" , "Brett Creeley" , "Justin Lai" , "Larry Chiu" , =?utf-8?b?TmlrbGFzIFPDtmRlcmx1bmQ=?= , "Paul Barker" , "Masahisa Kojima" , "Maxime Chevallier" , "Maxime Coquelin" , "Alexandre Torgue" , "FUJITA Tomonori" , "Siddharth Vadapalli" , "Roger Quadros" , "MD Danish Anwar" , "Jiawen Wu" , "Mengyuan Lou" , "Ronak Doshi" , "Ryder Lee" , "Shayne Chen" , "Sean Wang" , "Juergen Gross" , "Stefano Stabellini" , "Oleksandr Tyshchenko" , "Jordan Rhee" , "Ankit Garg" , "Tim Hostetler" , "Eric Joyner" , "Prabu Thayalan" , "Nikhil P. Rao" , "Chintan Vankar" , "Nora Schiffer" , "Alexander Sverdlin" , "Kevin Hao" , "Karl Mehltretter" , "Aleksandr Loktionov" , "Meghana Malladi" , "Jacob Keller" , "StanleyYP Wang" , imx@lists.linux.dev, linux-rdma@vger.kernel.org, linux-hyperv@vger.kernel.org, Frank.Li@kernel.org, wsa+renesas@sang-engineering.com In-Reply-To: <20261108060016.2131509-2-almasrymina@google.com> References: <20261108060016.2131509-1-almasrymina@google.com> <20261108060016.2131509-2-almasrymina@google.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Mon, 09 Nov 2026 06:00:34 +0000 X-Mailing-List: linux-hyperv@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list Thank you for your contribution! Sashiko AI review found 1 potential issue to consider: - [Low] net: skbuff: missing Fixes trailers for skb_frag_ref() and iptfs fixes -- commit 289785b15a220a700e7ce94d6b9993ab94b82d49 Author: Mina Almasry > net: skbuff: skip managed zerocopy frags in skb_frag_ref() > > skb_frag_unref() and skb_release_data() skip releasing references on > managed zerocopy fragments (SKBFL_MANAGED_FRAG_REFS), whereas > skb_frag_ref() acquires a reference unconditionally. If skb_frag_ref() > is called on a managed zerocopy SKB, the acquired reference is never > released by skb_frag_unref() or skb_release_data(). > > Skip acquiring a reference in skb_frag_ref() when skb_zcopy_managed(skb) > is true so skb_frag_ref() matches skb_frag_unref() and > skb_release_data(), and disable share_ok in iptfs_output_queued() when > skb_zcopy_managed(skb) is true so iptfs_consume_frags() does not append > unreferenced fragments into a managed zerocopy outer SKB. > > Signed-off-by: Mina Almasry [Severity: Low] Since this fixes fragment reference accounting for SKBFL_MANAGED_FRAG_REFS = in skb_frag_ref() and fragment sharing in iptfs_output_queued(), should the commit message include: Fixes: 753f1ca4e1e5 ("net: introduce managed frags infrastructure") Fixes: b96ba312e21c ("xfrm: iptfs: share page fragments of inner packets") --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20261108060016.2131= 509-1-almasrymina@google.com?part=3D1