Linux-HyperV List
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Naman Jain" <namjain@linux.microsoft.com>
Cc: linux-hyperv@vger.kernel.org
Subject: Re: [PATCH v2 4/5] x86/hyperv: Filter TLB targets before building hypercalls
Date: Tue, 17 Nov 2026 09:24:26 +0000	[thread overview]
Message-ID: <sashiko-outbox-218478@kernel.org> (raw)
In-Reply-To: <20261117091507.2088642-5-namjain@linux.microsoft.com>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] x86/hyperv: missing Fixes tag for commit 209954cbc7d0
--

commit b708a994017fe50fc481b9fcff6a341c5d843b13
Author: Naman Jain <namjain@linux.microsoft.com>

> x86/hyperv: Filter TLB targets before building hypercalls
>
> SuperBench's eight-GPU PyTorch LSTM training on Azure MI300X VMs regressed
> between Linux 6.8 and 7.0. Recreating DataLoader workers each epoch caused
> host-to-GPU copy stalls and timeouts. The reported bisection identified
> commit 209954cbc7d0 ("x86/mm/tlb: Update mm_cpumask lazily").
>
> That change leaves a CPU's bit set after it switches to another mm.
> Native flush callbacks remove these stale bits, but successful Hyper-V
> hypercalls do not run those callbacks. A CPU actively running another
> mm need not be in lazy TLB mode, so the existing lazy-TLB check does not
> exclude it. If the mask includes all present CPUs, the backend selects
> the all-processors shortcut before checking individual CPUs.
>
> Use the native predicate to build a per-CPU target mask before selecting
> the all-processors shortcut or either hypercall format. Keep the full
> candidate mask when freeing page tables. Retain the empty basic-mask
> check because filtering can leave no targets.
>
> This patch does not change when trimming is requested.
>
> Signed-off-by: Naman Jain <namjain@linux.microsoft.com>

[Severity: Low]
Since this fixes the regression introduced by 209954cbc7d0 ("x86/mm/tlb:
Update mm_cpumask lazily"), should the commit message include a Fixes tag?

  Fixes: 209954cbc7d0 ("x86/mm/tlb: Update mm_cpumask lazily")

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261117091507.2088642-1-namjain@linux.microsoft.com?part=4

  reply	other threads:[~2026-11-17  9:24 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-17  9:15 [PATCH v2 0/5] x86/hyperv: Account for lazy mm_cpumask maintenance Naman Jain
2026-11-17  9:15 ` [PATCH v2 1/5] x86/hyperv: Reject unrepresentable TLB flush VP sets Naman Jain
2026-11-17  9:15 ` [PATCH v2 2/5] x86/tlb: Make the conditional flush predicate reusable Naman Jain
2026-11-17  9:15 ` [PATCH v2 3/5] x86/hyperv: Use native callbacks for trimming and ASID transitions Naman Jain
2026-11-17  9:15 ` [PATCH v2 4/5] x86/hyperv: Filter TLB targets before building hypercalls Naman Jain
2026-11-17  9:24   ` sashiko-bot [this message]
2026-11-17  9:15 ` [PATCH v2 5/5] x86/hyperv: Request mask cleanup when no remote target remains Naman Jain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-218478@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=linux-hyperv@vger.kernel.org \
    --cc=namjain@linux.microsoft.com \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox