From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Masayuki Ohtake" Subject: Re: [MeeGo-Dev][PATCH] Topcliff: Update PCH_I2C driver to 2.6.35 Date: Mon, 6 Sep 2010 09:43:08 +0900 Message-ID: <000a01cb4d5c$a1bcb520$66f8800a@maildom.okisemi.com> References: <4C80CBC0.5050908@dsn.okisemi.com> <20100903133613.1c519c49@lxorguk.ukuu.org.uk> Return-path: Sender: linux-i2c-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Alan Cox Cc: "Jean Delvare (PC drivers, core)" , "Ben Dooks (embedded platforms)" , Crane Cai , Samuel Ortiz , Linus Walleij , Ralf Baechle , srinidhi kasagar , linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org, yong.y.wang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, qi.wang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, andrew.chih.howe.khor-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, arjan-VuQAYsv1563Yd54FQh9/CA@public.gmane.org, Tomoya MORINAGA , Arnd Bergmann List-Id: linux-i2c@vger.kernel.org Hi Alan, Thank you for your comments. We will update and resubmit soon. Thanks, Ohtake(OKISemi) ----- Original Message ----- From: "Alan Cox" To: "Masayuki Ohtak" Cc: "Jean Delvare (PC drivers, core)" ; "Ben Dooks (embedded platforms)" ; "Crane Cai" ; "Samuel Ortiz" ; "Linus Walleij" ; "Ralf Baechle" ; "srinidhi kasagar" ; ; ; ; ; ; ; ; "Tomoya MORINAGA" ; "Arnd Bergmann" Sent: Friday, September 03, 2010 9:36 PM Subject: Re: [MeeGo-Dev][PATCH] Topcliff: Update PCH_I2C driver to 2.6.35 > > +config PCH_I2C_CH_COUNT > > + int "PCH I2C the number of channel count" > > + range 1 2 > > + depends on PCH_I2C > > + help > > + This driver is for PCH(Platform controller Hub) I2C of Topcliff which > > + is an IOH(Input/Output Hub) for x86 embedded processor. > > + The number of I2C buses/channels supported by the PCH I2C controller. > > + PCH I2C of Topcliff supports only one channel. > > These sort of settings need to be runtime so one kernel can be built for > many platform variants. In this case if I understand correctly the > current device only has one channel so the define could just be moved > into the driver for now and made a variable later as/when/if new hardware > with more channels appears. > > > > > +static s32 pch_wait_for_xfer_complete(struct i2c_algo_pch_data *adap) > > +{ > > + s32 ret; > > + ret = wait_event_interruptible_timeout(pch_event, > > + (adap->pch_event_flag != 0), msecs_to_jiffies(50)); > > + if (ret < 0) { > > + pch_err(adap, "timeout: %x\n", adap->pch_event_flag); > > + return ret; > > + } > > You are reporting a timeout when _interruptible can also be woken by a > signal to the process (eg the user hitting ^C) > >