From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jingoo Han Subject: Re: [PATCH] i2c: davinci: Fix bad dev_get_platdata() conversion Date: Fri, 06 Sep 2013 09:08:43 +0900 Message-ID: <001901ceaa95$3fca88d0$bf5f9a70$%han@samsung.com> References: <1378409024-13432-1-git-send-email-olof@lixom.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Return-path: In-reply-to: <1378409024-13432-1-git-send-email-olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org> Content-language: ko Sender: linux-i2c-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: 'Olof Johansson' Cc: 'Wolfram Sang' , 'Sekhar Nori' , 'Kevin Hilman' , linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, 'Jingoo Han' List-Id: linux-i2c@vger.kernel.org On Friday, September 06, 2013 4:24 AM, Olof Johansson wrote: > > commit 6d4028c644e (i2c: use dev_get_platdata()) did a bad conversion > of this one case: > > drivers/i2c/busses/i2c-davinci.c: In function 'davinci_i2c_probe': > drivers/i2c/busses/i2c-davinci.c:665:2: warning: passing argument 1 of > 'dev_get_platdata' from incompatible pointer type [enabled by default] > > Cc: Jingoo Han > Signed-off-by: Olof Johansson Reviewed-by: Jingoo Han Oh, it's my bad. :-( Thank you for fixing it. Best regards, Jingoo Han > --- > drivers/i2c/busses/i2c-davinci.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/i2c/busses/i2c-davinci.c b/drivers/i2c/busses/i2c-davinci.c > index 5747341..132369f 100644 > --- a/drivers/i2c/busses/i2c-davinci.c > +++ b/drivers/i2c/busses/i2c-davinci.c > @@ -662,7 +662,7 @@ static int davinci_i2c_probe(struct platform_device *pdev) > #endif > dev->dev = &pdev->dev; > dev->irq = irq->start; > - dev->pdata = dev_get_platdata(&dev->dev); > + dev->pdata = dev_get_platdata(&pdev->dev); > platform_set_drvdata(pdev, dev); > > if (!dev->pdata && pdev->dev.of_node) { > -- > 1.7.10.4