From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jingoo Han <jg1.han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
Subject: Re: [PATCH] i2c: davinci: Fix bad dev_get_platdata() conversion
Date: Wed, 11 Sep 2013 09:27:54 +0900
Message-ID: <002801ceae85$c1c13070$45439150$%han@samsung.com>
References: <1378409024-13432-1-git-send-email-olof@lixom.net>
 <20130910092001.GB4625@katana>
 <007401ceae07$a70b41e0$f521c5a0$%han@samsung.com>
 <CAOesGMiNaQyLz3bOQzu4bQ_jJBh=g8uLZxLtHvDEAxefEZYAVQ@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Return-path: <linux-i2c-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
In-reply-to: <CAOesGMiNaQyLz3bOQzu4bQ_jJBh=g8uLZxLtHvDEAxefEZYAVQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
Content-language: ko
Sender: linux-i2c-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
To: 'Olof Johansson' <olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org>
Cc: 'Wolfram Sang' <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>, 'Sekhar Nori' <nsekhar-l0cyMroinI0@public.gmane.org>, 'Kevin Hilman' <khilman-1D3HCaltpLuhEniVeURVKkEOCMrvLtNR@public.gmane.org>, linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, 'Jingoo Han' <jg1.han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
List-Id: linux-i2c@vger.kernel.org

On Wednesday, September 11, 2013 6:27 AM, Olof Johansson wrote:
> On Tue, Sep 10, 2013 at 2:25 AM, Jingoo Han <jg1.han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> wrote:
> > On Tuesday, September 10, 2013 6:20 PM, Wolfram Sang wrote:
> >> On Thu, Sep 05, 2013 at 12:23:44PM -0700, Olof Johansson wrote:
> >> > commit 6d4028c644e (i2c: use dev_get_platdata()) did a bad conversion
> >> > of this one case:
> >> >
> >> > drivers/i2c/busses/i2c-davinci.c: In function 'davinci_i2c_probe':
> >> > drivers/i2c/busses/i2c-davinci.c:665:2: warning: passing argument 1 of
> >> >     'dev_get_platdata' from incompatible pointer type [enabled by default]
> >> >
> >> > Cc: Jingoo Han <jg1.han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
> >> > Signed-off-by: Olof Johansson <olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org>
> >>
> >> Gosh, need to find out why my build-tests failed on that. Thanks!
> >>
> >> Acked-by: Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
> 
> Thanks, applied to arm-soc fixes branch.

Thank you very much! :-)

> 
> >>
> >> Jingoo Han: Did you buildtest?
> >
> > I always did builtest for the patch.
> > However, I cannot know why it makes build error.
> > Anyway, sorry for making this build error.
> 
> No worries, it happens. There was plenty of time to find it in
> linux-next, the warning started showing up there on 08/22. I should
> have been faster at noticing.
> 

Hi Olof,

I really appreciate your caring.
I will be more careful next time.
Thank you. :)

Best regards,
Jingoo Han