* [PATCH] i2c: davinci: Fix bad dev_get_platdata() conversion
@ 2013-09-05 19:23 Olof Johansson
[not found] ` <1378409024-13432-1-git-send-email-olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org>
0 siblings, 1 reply; 6+ messages in thread
From: Olof Johansson @ 2013-09-05 19:23 UTC (permalink / raw)
To: Wolfram Sang
Cc: Sekhar Nori, Kevin Hilman, linux-i2c-u79uwXL29TY76Z2rM5mHXA,
Olof Johansson, Jingoo Han
commit 6d4028c644e (i2c: use dev_get_platdata()) did a bad conversion
of this one case:
drivers/i2c/busses/i2c-davinci.c: In function 'davinci_i2c_probe':
drivers/i2c/busses/i2c-davinci.c:665:2: warning: passing argument 1 of
'dev_get_platdata' from incompatible pointer type [enabled by default]
Cc: Jingoo Han <jg1.han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
Signed-off-by: Olof Johansson <olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org>
---
drivers/i2c/busses/i2c-davinci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/i2c/busses/i2c-davinci.c b/drivers/i2c/busses/i2c-davinci.c
index 5747341..132369f 100644
--- a/drivers/i2c/busses/i2c-davinci.c
+++ b/drivers/i2c/busses/i2c-davinci.c
@@ -662,7 +662,7 @@ static int davinci_i2c_probe(struct platform_device *pdev)
#endif
dev->dev = &pdev->dev;
dev->irq = irq->start;
- dev->pdata = dev_get_platdata(&dev->dev);
+ dev->pdata = dev_get_platdata(&pdev->dev);
platform_set_drvdata(pdev, dev);
if (!dev->pdata && pdev->dev.of_node) {
--
1.7.10.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] i2c: davinci: Fix bad dev_get_platdata() conversion
[not found] ` <1378409024-13432-1-git-send-email-olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org>
@ 2013-09-06 0:08 ` Jingoo Han
2013-09-10 9:20 ` Wolfram Sang
1 sibling, 0 replies; 6+ messages in thread
From: Jingoo Han @ 2013-09-06 0:08 UTC (permalink / raw)
To: 'Olof Johansson'
Cc: 'Wolfram Sang', 'Sekhar Nori',
'Kevin Hilman', linux-i2c-u79uwXL29TY76Z2rM5mHXA,
'Jingoo Han'
On Friday, September 06, 2013 4:24 AM, Olof Johansson wrote:
>
> commit 6d4028c644e (i2c: use dev_get_platdata()) did a bad conversion
> of this one case:
>
> drivers/i2c/busses/i2c-davinci.c: In function 'davinci_i2c_probe':
> drivers/i2c/busses/i2c-davinci.c:665:2: warning: passing argument 1 of
> 'dev_get_platdata' from incompatible pointer type [enabled by default]
>
> Cc: Jingoo Han <jg1.han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
> Signed-off-by: Olof Johansson <olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org>
Reviewed-by: Jingoo Han <jg1.han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
Oh, it's my bad. :-(
Thank you for fixing it.
Best regards,
Jingoo Han
> ---
> drivers/i2c/busses/i2c-davinci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/i2c/busses/i2c-davinci.c b/drivers/i2c/busses/i2c-davinci.c
> index 5747341..132369f 100644
> --- a/drivers/i2c/busses/i2c-davinci.c
> +++ b/drivers/i2c/busses/i2c-davinci.c
> @@ -662,7 +662,7 @@ static int davinci_i2c_probe(struct platform_device *pdev)
> #endif
> dev->dev = &pdev->dev;
> dev->irq = irq->start;
> - dev->pdata = dev_get_platdata(&dev->dev);
> + dev->pdata = dev_get_platdata(&pdev->dev);
> platform_set_drvdata(pdev, dev);
>
> if (!dev->pdata && pdev->dev.of_node) {
> --
> 1.7.10.4
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] i2c: davinci: Fix bad dev_get_platdata() conversion
[not found] ` <1378409024-13432-1-git-send-email-olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org>
2013-09-06 0:08 ` Jingoo Han
@ 2013-09-10 9:20 ` Wolfram Sang
2013-09-10 9:25 ` Jingoo Han
1 sibling, 1 reply; 6+ messages in thread
From: Wolfram Sang @ 2013-09-10 9:20 UTC (permalink / raw)
To: Olof Johansson
Cc: Sekhar Nori, Kevin Hilman, linux-i2c-u79uwXL29TY76Z2rM5mHXA,
Jingoo Han
[-- Attachment #1: Type: text/plain, Size: 1375 bytes --]
On Thu, Sep 05, 2013 at 12:23:44PM -0700, Olof Johansson wrote:
> commit 6d4028c644e (i2c: use dev_get_platdata()) did a bad conversion
> of this one case:
>
> drivers/i2c/busses/i2c-davinci.c: In function 'davinci_i2c_probe':
> drivers/i2c/busses/i2c-davinci.c:665:2: warning: passing argument 1 of
> 'dev_get_platdata' from incompatible pointer type [enabled by default]
>
> Cc: Jingoo Han <jg1.han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
> Signed-off-by: Olof Johansson <olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org>
Gosh, need to find out why my build-tests failed on that. Thanks!
Acked-by: Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
Jingoo Han: Did you buildtest?
> ---
> drivers/i2c/busses/i2c-davinci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/i2c/busses/i2c-davinci.c b/drivers/i2c/busses/i2c-davinci.c
> index 5747341..132369f 100644
> --- a/drivers/i2c/busses/i2c-davinci.c
> +++ b/drivers/i2c/busses/i2c-davinci.c
> @@ -662,7 +662,7 @@ static int davinci_i2c_probe(struct platform_device *pdev)
> #endif
> dev->dev = &pdev->dev;
> dev->irq = irq->start;
> - dev->pdata = dev_get_platdata(&dev->dev);
> + dev->pdata = dev_get_platdata(&pdev->dev);
> platform_set_drvdata(pdev, dev);
>
> if (!dev->pdata && pdev->dev.of_node) {
> --
> 1.7.10.4
>
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] i2c: davinci: Fix bad dev_get_platdata() conversion
2013-09-10 9:20 ` Wolfram Sang
@ 2013-09-10 9:25 ` Jingoo Han
[not found] ` <007401ceae07$a70b41e0$f521c5a0$%han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
0 siblings, 1 reply; 6+ messages in thread
From: Jingoo Han @ 2013-09-10 9:25 UTC (permalink / raw)
To: 'Wolfram Sang', 'Olof Johansson'
Cc: 'Sekhar Nori', 'Kevin Hilman',
linux-i2c-u79uwXL29TY76Z2rM5mHXA, 'Jingoo Han'
On Tuesday, September 10, 2013 6:20 PM, Wolfram Sang wrote:
> On Thu, Sep 05, 2013 at 12:23:44PM -0700, Olof Johansson wrote:
> > commit 6d4028c644e (i2c: use dev_get_platdata()) did a bad conversion
> > of this one case:
> >
> > drivers/i2c/busses/i2c-davinci.c: In function 'davinci_i2c_probe':
> > drivers/i2c/busses/i2c-davinci.c:665:2: warning: passing argument 1 of
> > 'dev_get_platdata' from incompatible pointer type [enabled by default]
> >
> > Cc: Jingoo Han <jg1.han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
> > Signed-off-by: Olof Johansson <olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org>
>
> Gosh, need to find out why my build-tests failed on that. Thanks!
>
> Acked-by: Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
>
> Jingoo Han: Did you buildtest?
I always did builtest for the patch.
However, I cannot know why it makes build error.
Anyway, sorry for making this build error.
Best regards,
Jingoo Han
>
> > ---
> > drivers/i2c/busses/i2c-davinci.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/i2c/busses/i2c-davinci.c b/drivers/i2c/busses/i2c-davinci.c
> > index 5747341..132369f 100644
> > --- a/drivers/i2c/busses/i2c-davinci.c
> > +++ b/drivers/i2c/busses/i2c-davinci.c
> > @@ -662,7 +662,7 @@ static int davinci_i2c_probe(struct platform_device *pdev)
> > #endif
> > dev->dev = &pdev->dev;
> > dev->irq = irq->start;
> > - dev->pdata = dev_get_platdata(&dev->dev);
> > + dev->pdata = dev_get_platdata(&pdev->dev);
> > platform_set_drvdata(pdev, dev);
> >
> > if (!dev->pdata && pdev->dev.of_node) {
> > --
> > 1.7.10.4
> >
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] i2c: davinci: Fix bad dev_get_platdata() conversion
[not found] ` <007401ceae07$a70b41e0$f521c5a0$%han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
@ 2013-09-10 21:26 ` Olof Johansson
[not found] ` <CAOesGMiNaQyLz3bOQzu4bQ_jJBh=g8uLZxLtHvDEAxefEZYAVQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
0 siblings, 1 reply; 6+ messages in thread
From: Olof Johansson @ 2013-09-10 21:26 UTC (permalink / raw)
To: Jingoo Han
Cc: Wolfram Sang, Sekhar Nori, Kevin Hilman,
linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
On Tue, Sep 10, 2013 at 2:25 AM, Jingoo Han <jg1.han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> wrote:
> On Tuesday, September 10, 2013 6:20 PM, Wolfram Sang wrote:
>> On Thu, Sep 05, 2013 at 12:23:44PM -0700, Olof Johansson wrote:
>> > commit 6d4028c644e (i2c: use dev_get_platdata()) did a bad conversion
>> > of this one case:
>> >
>> > drivers/i2c/busses/i2c-davinci.c: In function 'davinci_i2c_probe':
>> > drivers/i2c/busses/i2c-davinci.c:665:2: warning: passing argument 1 of
>> > 'dev_get_platdata' from incompatible pointer type [enabled by default]
>> >
>> > Cc: Jingoo Han <jg1.han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
>> > Signed-off-by: Olof Johansson <olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org>
>>
>> Gosh, need to find out why my build-tests failed on that. Thanks!
>>
>> Acked-by: Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
Thanks, applied to arm-soc fixes branch.
>>
>> Jingoo Han: Did you buildtest?
>
> I always did builtest for the patch.
> However, I cannot know why it makes build error.
> Anyway, sorry for making this build error.
No worries, it happens. There was plenty of time to find it in
linux-next, the warning started showing up there on 08/22. I should
have been faster at noticing.
-Olof
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] i2c: davinci: Fix bad dev_get_platdata() conversion
[not found] ` <CAOesGMiNaQyLz3bOQzu4bQ_jJBh=g8uLZxLtHvDEAxefEZYAVQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
@ 2013-09-11 0:27 ` Jingoo Han
0 siblings, 0 replies; 6+ messages in thread
From: Jingoo Han @ 2013-09-11 0:27 UTC (permalink / raw)
To: 'Olof Johansson'
Cc: 'Wolfram Sang', 'Sekhar Nori',
'Kevin Hilman', linux-i2c-u79uwXL29TY76Z2rM5mHXA,
'Jingoo Han'
On Wednesday, September 11, 2013 6:27 AM, Olof Johansson wrote:
> On Tue, Sep 10, 2013 at 2:25 AM, Jingoo Han <jg1.han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> wrote:
> > On Tuesday, September 10, 2013 6:20 PM, Wolfram Sang wrote:
> >> On Thu, Sep 05, 2013 at 12:23:44PM -0700, Olof Johansson wrote:
> >> > commit 6d4028c644e (i2c: use dev_get_platdata()) did a bad conversion
> >> > of this one case:
> >> >
> >> > drivers/i2c/busses/i2c-davinci.c: In function 'davinci_i2c_probe':
> >> > drivers/i2c/busses/i2c-davinci.c:665:2: warning: passing argument 1 of
> >> > 'dev_get_platdata' from incompatible pointer type [enabled by default]
> >> >
> >> > Cc: Jingoo Han <jg1.han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
> >> > Signed-off-by: Olof Johansson <olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org>
> >>
> >> Gosh, need to find out why my build-tests failed on that. Thanks!
> >>
> >> Acked-by: Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
>
> Thanks, applied to arm-soc fixes branch.
Thank you very much! :-)
>
> >>
> >> Jingoo Han: Did you buildtest?
> >
> > I always did builtest for the patch.
> > However, I cannot know why it makes build error.
> > Anyway, sorry for making this build error.
>
> No worries, it happens. There was plenty of time to find it in
> linux-next, the warning started showing up there on 08/22. I should
> have been faster at noticing.
>
Hi Olof,
I really appreciate your caring.
I will be more careful next time.
Thank you. :)
Best regards,
Jingoo Han
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-09-11 0:27 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-05 19:23 [PATCH] i2c: davinci: Fix bad dev_get_platdata() conversion Olof Johansson
[not found] ` <1378409024-13432-1-git-send-email-olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org>
2013-09-06 0:08 ` Jingoo Han
2013-09-10 9:20 ` Wolfram Sang
2013-09-10 9:25 ` Jingoo Han
[not found] ` <007401ceae07$a70b41e0$f521c5a0$%han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2013-09-10 21:26 ` Olof Johansson
[not found] ` <CAOesGMiNaQyLz3bOQzu4bQ_jJBh=g8uLZxLtHvDEAxefEZYAVQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-09-11 0:27 ` Jingoo Han
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).